From: "Nuno Sá" <nuno.sa@analog.com>
To: <openbmc@lists.ozlabs.org>, <linux-imx@nxp.com>,
<linux-stm32@st-md-mailman.stormreply.com>,
<linux-iio@vger.kernel.org>, <linux-mips@vger.kernel.org>,
<linux-renesas-soc@vger.kernel.org>,
<linux-mediatek@lists.infradead.org>,
<chrome-platform@lists.linux.dev>,
<linux-arm-kernel@lists.infradead.org>,
Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>,
<linux-arm-msm@vger.kernel.org>
Cc: Gwendal Grignou <gwendal@chromium.org>,
Jonathan Cameron <jic23@kernel.org>,
Saravanan Sekar <sravanhome@gmail.com>,
Tomer Maimon <tmaimon77@gmail.com>,
Maxime Coquelin <mcoquelin.stm32@gmail.com>,
Alexandre Torgue <alexandre.torgue@foss.st.com>,
Lorenzo Bianconi <lorenzo@kernel.org>,
Fabio Estevam <festevam@gmail.com>,
Shawn Guo <shawnguo@kernel.org>,
Olivier Moysan <olivier.moysan@foss.st.com>,
Tali Perry <tali.perry1@gmail.com>,
Thara Gopinath <thara.gopinath@linaro.org>,
Bjorn Andersson <bjorn.andersson@linaro.org>,
Arnd Bergmann <arnd@arndb.de>,
Benjamin Fair <benjaminfair@google.com>,
Nicolas Ferre <nicolas.ferre@microchip.com>,
"Rafael J. Wysocki" <rafael@kernel.org>,
Patrick Venture <venture@google.com>,
Pengutronix Kernel Team <kernel@pengutronix.de>,
Fabrice Gasnier <fabrice.gasnier@foss.st.com>,
Daniel Lezcano <daniel.lezcano@linaro.org>,
Benson Leung <bleung@chromium.org>, Nancy Yuen <yuenn@google.com>,
Miquel Raynal <miquel.raynal@bootlin.com>,
Alexandre Belloni <alexandre.belloni@bootlin.com>,
Zhang Rui <rui.zhang@intel.com>,
Linus Walleij <linus.walleij@linaro.org>,
Christophe Branchereau <cbranchereau@gmail.com>,
Cai Huoqing <cai.huoqing@linux.dev>,
Avi Fishman <avifishman70@gmail.com>,
Eugen Hristev <eugen.hristev@microchip.com>,
Matthias Brugger <matthias.bgg@gmail.com>,
Sascha Hauer <s.hauer@pengutronix.de>,
Lars-Peter Clausen <lars@metafoo.de>,
Andy Shevchenko <andy.shevchenko@gmail.com>,
Guenter Roeck <groeck@chromium.org>,
Paul Cercueil <paul@crapouillou.net>,
Claudiu Beznea <claudiu.beznea@microchip.com>,
Andy Gross <agross@kernel.org>, Amit Kucheria <amitk@kernel.org>,
Michael Hennerich <Michael.Hennerich@analog.com>,
Haibo Chen <haibo.chen@nxp.com>,
Jishnu Prakash <quic_jprakash@quicinc.com>
Subject: [PATCH v3 11/15] iio: adc: qcom-spmi-vadc: convert to device properties
Date: Fri, 15 Jul 2022 14:28:59 +0200 [thread overview]
Message-ID: <20220715122903.332535-12-nuno.sa@analog.com> (raw)
In-Reply-To: <20220715122903.332535-1-nuno.sa@analog.com>
Make the conversion to firmware agnostic device properties. As part of
the conversion the IIO inkern interface 'of_xlate()' is also converted to
'fwnode_xlate()'. The goal is to completely drop 'of_xlate' and hence OF
dependencies from IIO.
Signed-off-by: Nuno Sá <nuno.sa@analog.com>
Acked-by: Linus Walleij <linus.walleij@linaro.org>
Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com>
---
drivers/iio/adc/qcom-spmi-vadc.c | 44 ++++++++++++++++----------------
1 file changed, 22 insertions(+), 22 deletions(-)
diff --git a/drivers/iio/adc/qcom-spmi-vadc.c b/drivers/iio/adc/qcom-spmi-vadc.c
index 34202ba52469..bcff0f62b70e 100644
--- a/drivers/iio/adc/qcom-spmi-vadc.c
+++ b/drivers/iio/adc/qcom-spmi-vadc.c
@@ -13,8 +13,9 @@
#include <linux/kernel.h>
#include <linux/math64.h>
#include <linux/module.h>
-#include <linux/of.h>
+#include <linux/mod_devicetable.h>
#include <linux/platform_device.h>
+#include <linux/property.h>
#include <linux/regmap.h>
#include <linux/slab.h>
#include <linux/log2.h>
@@ -481,8 +482,8 @@ static int vadc_read_raw(struct iio_dev *indio_dev,
return ret;
}
-static int vadc_of_xlate(struct iio_dev *indio_dev,
- const struct of_phandle_args *iiospec)
+static int vadc_fwnode_xlate(struct iio_dev *indio_dev,
+ const struct fwnode_reference_args *iiospec)
{
struct vadc_priv *vadc = iio_priv(indio_dev);
unsigned int i;
@@ -496,7 +497,7 @@ static int vadc_of_xlate(struct iio_dev *indio_dev,
static const struct iio_info vadc_info = {
.read_raw = vadc_read_raw,
- .of_xlate = vadc_of_xlate,
+ .fwnode_xlate = vadc_fwnode_xlate,
};
struct vadc_channels {
@@ -647,15 +648,15 @@ static const struct vadc_channels vadc_chans[] = {
VADC_CHAN_NO_SCALE(LR_MUX3_BUF_PU1_PU2_XO_THERM, 0)
};
-static int vadc_get_dt_channel_data(struct device *dev,
+static int vadc_get_fw_channel_data(struct device *dev,
struct vadc_channel_prop *prop,
- struct device_node *node)
+ struct fwnode_handle *fwnode)
{
- const char *name = node->name;
+ const char *name = fwnode_get_name(fwnode);
u32 chan, value, varr[2];
int ret;
- ret = of_property_read_u32(node, "reg", &chan);
+ ret = fwnode_property_read_u32(fwnode, "reg", &chan);
if (ret) {
dev_err(dev, "invalid channel number %s\n", name);
return ret;
@@ -669,7 +670,7 @@ static int vadc_get_dt_channel_data(struct device *dev,
/* the channel has DT description */
prop->channel = chan;
- ret = of_property_read_u32(node, "qcom,decimation", &value);
+ ret = fwnode_property_read_u32(fwnode, "qcom,decimation", &value);
if (!ret) {
ret = qcom_vadc_decimation_from_dt(value);
if (ret < 0) {
@@ -682,7 +683,7 @@ static int vadc_get_dt_channel_data(struct device *dev,
prop->decimation = VADC_DEF_DECIMATION;
}
- ret = of_property_read_u32_array(node, "qcom,pre-scaling", varr, 2);
+ ret = fwnode_property_read_u32_array(fwnode, "qcom,pre-scaling", varr, 2);
if (!ret) {
ret = vadc_prescaling_from_dt(varr[0], varr[1]);
if (ret < 0) {
@@ -695,7 +696,7 @@ static int vadc_get_dt_channel_data(struct device *dev,
prop->prescale = vadc_chans[prop->channel].prescale_index;
}
- ret = of_property_read_u32(node, "qcom,hw-settle-time", &value);
+ ret = fwnode_property_read_u32(fwnode, "qcom,hw-settle-time", &value);
if (!ret) {
ret = vadc_hw_settle_time_from_dt(value);
if (ret < 0) {
@@ -708,7 +709,7 @@ static int vadc_get_dt_channel_data(struct device *dev,
prop->hw_settle_time = VADC_DEF_HW_SETTLE_TIME;
}
- ret = of_property_read_u32(node, "qcom,avg-samples", &value);
+ ret = fwnode_property_read_u32(fwnode, "qcom,avg-samples", &value);
if (!ret) {
ret = vadc_avg_samples_from_dt(value);
if (ret < 0) {
@@ -721,7 +722,7 @@ static int vadc_get_dt_channel_data(struct device *dev,
prop->avg_samples = VADC_DEF_AVG_SAMPLES;
}
- if (of_property_read_bool(node, "qcom,ratiometric"))
+ if (fwnode_property_read_bool(fwnode, "qcom,ratiometric"))
prop->calibration = VADC_CALIB_RATIOMETRIC;
else
prop->calibration = VADC_CALIB_ABSOLUTE;
@@ -731,16 +732,16 @@ static int vadc_get_dt_channel_data(struct device *dev,
return 0;
}
-static int vadc_get_dt_data(struct vadc_priv *vadc, struct device_node *node)
+static int vadc_get_fw_data(struct vadc_priv *vadc)
{
const struct vadc_channels *vadc_chan;
struct iio_chan_spec *iio_chan;
struct vadc_channel_prop prop;
- struct device_node *child;
+ struct fwnode_handle *child;
unsigned int index = 0;
int ret;
- vadc->nchannels = of_get_available_child_count(node);
+ vadc->nchannels = device_get_child_node_count(vadc->dev);
if (!vadc->nchannels)
return -EINVAL;
@@ -756,10 +757,10 @@ static int vadc_get_dt_data(struct vadc_priv *vadc, struct device_node *node)
iio_chan = vadc->iio_chans;
- for_each_available_child_of_node(node, child) {
- ret = vadc_get_dt_channel_data(vadc->dev, &prop, child);
+ device_for_each_child_node(vadc->dev, child) {
+ ret = vadc_get_fw_channel_data(vadc->dev, &prop, child);
if (ret) {
- of_node_put(child);
+ fwnode_handle_put(child);
return ret;
}
@@ -848,7 +849,6 @@ static int vadc_check_revision(struct vadc_priv *vadc)
static int vadc_probe(struct platform_device *pdev)
{
- struct device_node *node = pdev->dev.of_node;
struct device *dev = &pdev->dev;
struct iio_dev *indio_dev;
struct vadc_priv *vadc;
@@ -860,7 +860,7 @@ static int vadc_probe(struct platform_device *pdev)
if (!regmap)
return -ENODEV;
- ret = of_property_read_u32(node, "reg", ®);
+ ret = device_property_read_u32(dev, "reg", ®);
if (ret < 0)
return ret;
@@ -880,7 +880,7 @@ static int vadc_probe(struct platform_device *pdev)
if (ret)
return ret;
- ret = vadc_get_dt_data(vadc, node);
+ ret = vadc_get_fw_data(vadc);
if (ret)
return ret;
--
2.37.1
next prev parent reply other threads:[~2022-07-15 12:30 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-15 12:28 [PATCH v3 00/15] make iio inkern interface firmware agnostic Nuno Sá
2022-07-15 12:28 ` [PATCH v3 01/15] iio: inkern: only release the device node when done with it Nuno Sá
2022-07-15 12:28 ` [PATCH v3 02/15] iio: inkern: fix return value in devm_of_iio_channel_get_by_name() Nuno Sá
2022-07-15 12:28 ` [PATCH v3 03/15] iio: inkern: only return error codes in iio_channel_get_*() APIs Nuno Sá
2022-08-06 17:45 ` Jonathan Cameron
2022-07-15 12:28 ` [PATCH v3 04/15] iio: inkern: split of_iio_channel_get_by_name() Nuno Sá
2022-08-06 18:30 ` Jonathan Cameron
2022-07-15 12:28 ` [PATCH v3 05/15] iio: inkern: move to fwnode properties Nuno Sá
2022-08-06 17:59 ` Jonathan Cameron
2022-08-06 18:38 ` Jonathan Cameron
2022-07-15 12:28 ` [PATCH v3 06/15] thermal: qcom: qcom-spmi-adc-tm5: convert to IIO fwnode API Nuno Sá
2022-07-15 21:40 ` Daniel Lezcano
2022-07-15 12:28 ` [PATCH v3 07/15] iio: adc: ingenic-adc: convert to IIO fwnode interface Nuno Sá
2022-07-15 12:28 ` [PATCH v3 08/15] iio: adc: ab8500-gpadc: convert to device properties Nuno Sá
2022-08-06 18:03 ` Jonathan Cameron
2022-08-06 18:08 ` Jonathan Cameron
2022-07-15 12:28 ` [PATCH v3 09/15] iio: adc: at91-sama5d2_adc: " Nuno Sá
2022-07-18 5:21 ` Claudiu.Beznea
2022-08-06 18:49 ` Jonathan Cameron
2022-08-18 8:39 ` Claudiu.Beznea
2022-07-15 12:28 ` [PATCH v3 10/15] iio: adc: qcom-pm8xxx-xoadc: " Nuno Sá
2022-07-15 12:28 ` Nuno Sá [this message]
2022-07-15 12:29 ` [PATCH v3 12/15] iio: adc: qcom-spmi-adc5: " Nuno Sá
2022-08-06 18:20 ` Jonathan Cameron
2023-01-16 20:44 ` Marijn Suijten
2023-01-17 8:53 ` Andy Shevchenko
2023-01-17 9:06 ` Andy Shevchenko
2023-01-17 9:40 ` Andy Shevchenko
2023-01-17 22:42 ` Marijn Suijten
2022-07-15 12:29 ` [PATCH v3 13/15] iio: adc: stm32-adc: " Nuno Sá
2022-08-05 7:25 ` Fabrice Gasnier
2022-08-06 18:15 ` Jonathan Cameron
2022-08-06 18:53 ` Jonathan Cameron
2022-07-15 12:29 ` [PATCH v3 14/15] iio: inkern: remove OF dependencies Nuno Sá
2022-07-15 12:29 ` [PATCH v3 15/15] iio: inkern: fix coding style warnings Nuno Sá
2022-07-15 16:58 ` Andy Shevchenko
2022-08-06 18:56 ` [PATCH v3 00/15] make iio inkern interface firmware agnostic Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220715122903.332535-12-nuno.sa@analog.com \
--to=nuno.sa@analog.com \
--cc=Michael.Hennerich@analog.com \
--cc=agross@kernel.org \
--cc=alexandre.belloni@bootlin.com \
--cc=alexandre.torgue@foss.st.com \
--cc=amitk@kernel.org \
--cc=andy.shevchenko@gmail.com \
--cc=arnd@arndb.de \
--cc=avifishman70@gmail.com \
--cc=benjaminfair@google.com \
--cc=bjorn.andersson@linaro.org \
--cc=bleung@chromium.org \
--cc=cai.huoqing@linux.dev \
--cc=cbranchereau@gmail.com \
--cc=chrome-platform@lists.linux.dev \
--cc=claudiu.beznea@microchip.com \
--cc=daniel.lezcano@linaro.org \
--cc=eugen.hristev@microchip.com \
--cc=fabrice.gasnier@foss.st.com \
--cc=festevam@gmail.com \
--cc=groeck@chromium.org \
--cc=gwendal@chromium.org \
--cc=haibo.chen@nxp.com \
--cc=jic23@kernel.org \
--cc=kernel@pengutronix.de \
--cc=lars@metafoo.de \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-imx@nxp.com \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-mips@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=lorenzo@kernel.org \
--cc=matthias.bgg@gmail.com \
--cc=mcoquelin.stm32@gmail.com \
--cc=miquel.raynal@bootlin.com \
--cc=nicolas.ferre@microchip.com \
--cc=olivier.moysan@foss.st.com \
--cc=openbmc@lists.ozlabs.org \
--cc=paul@crapouillou.net \
--cc=prabhakar.mahadev-lad.rj@bp.renesas.com \
--cc=quic_jprakash@quicinc.com \
--cc=rafael@kernel.org \
--cc=rui.zhang@intel.com \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
--cc=sravanhome@gmail.com \
--cc=tali.perry1@gmail.com \
--cc=thara.gopinath@linaro.org \
--cc=tmaimon77@gmail.com \
--cc=venture@google.com \
--cc=yuenn@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox