Chrome platform driver development
 help / color / mirror / Atom feed
From: Dan Callaghan <dcallagh@chromium.org>
To: chrome-platform@lists.linux.dev
Cc: LKML <linux-kernel@vger.kernel.org>,
	"Sami Kyöstilä" <skyostil@chromium.org>,
	"Benson Leung" <bleung@chromium.org>,
	"Tzung-Bi Shih" <tzungbi@kernel.org>,
	"Dan Callaghan" <dcallagh@chromium.org>,
	"kernel test robot" <lkp@intel.com>
Subject: [PATCH] platform/chrome: cros_hps_i2c: make remove callback return void
Date: Wed, 19 Oct 2022 10:52:37 +1100	[thread overview]
Message-ID: <20221018235237.2274969-1-dcallagh@chromium.org> (raw)

Commit ed5c2f5fd10d ("i2c: Make remove callback return void") changed
the return type of the 'remove' callback to void, but this driver was
originally written before that change landed. Update the remove callback
to match.

Fixes: 5f9952548d91 ("platform/chrome: add a driver for HPS")
Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: Dan Callaghan <dcallagh@chromium.org>
---
 drivers/platform/chrome/cros_hps_i2c.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/drivers/platform/chrome/cros_hps_i2c.c b/drivers/platform/chrome/cros_hps_i2c.c
index 92da59d94745..62ccb1acb5de 100644
--- a/drivers/platform/chrome/cros_hps_i2c.c
+++ b/drivers/platform/chrome/cros_hps_i2c.c
@@ -95,7 +95,7 @@ static int hps_i2c_probe(struct i2c_client *client)
 	return 0;
 }
 
-static int hps_i2c_remove(struct i2c_client *client)
+static void hps_i2c_remove(struct i2c_client *client)
 {
 	struct hps_drvdata *hps = i2c_get_clientdata(client);
 
@@ -107,8 +107,6 @@ static int hps_i2c_remove(struct i2c_client *client)
 	 * (i.e. powered on).
 	 */
 	hps_set_power(hps, true);
-
-	return 0;
 }
 
 static int hps_suspend(struct device *dev)

base-commit: c7e2618e12562ba6f9d230d8ed4257dfa94d2d9d
-- 
2.38.0.413.g74048e4d9e-goog


             reply	other threads:[~2022-10-18 23:54 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-10-18 23:52 Dan Callaghan [this message]
2022-10-19  2:00 ` [PATCH] platform/chrome: cros_hps_i2c: make remove callback return void patchwork-bot+chrome-platform
2022-10-19  7:20 ` patchwork-bot+chrome-platform

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20221018235237.2274969-1-dcallagh@chromium.org \
    --to=dcallagh@chromium.org \
    --cc=bleung@chromium.org \
    --cc=chrome-platform@lists.linux.dev \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lkp@intel.com \
    --cc=skyostil@chromium.org \
    --cc=tzungbi@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox