From: Andre Przywara <andre.przywara@arm.com>
To: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
Cc: Alexandre Belloni <alexandre.belloni@bootlin.com>,
Heiko Stuebner <heiko@sntech.de>,
Linus Walleij <linus.walleij@linaro.org>,
Alexandre Torgue <alexandre.torgue@foss.st.com>,
dri-devel@lists.freedesktop.org,
Douglas Anderson <dianders@chromium.org>,
Conor Dooley <conor.dooley@microchip.com>,
Thierry Reding <thierry.reding@gmail.com>,
Satya Priya <quic_c_skakit@quicinc.com>,
Pavel Machek <pavel@ucw.cz>, Guenter Roeck <groeck@chromium.org>,
Nobuhiro Iwamatsu <nobuhiro1.iwamatsu@toshiba.co.jp>,
Fabio Estevam <festevam@gmail.com>,
linux-riscv@lists.infradead.org, linux-leds@vger.kernel.org,
Jerome Brunet <jbrunet@baylibre.com>,
chrome-platform@lists.linux.dev,
Florian Fainelli <f.fainelli@gmail.com>,
Samuel Holland <samuel@sholland.org>,
Sean Anderson <sean.anderson@seco.com>,
Kevin Hilman <khilman@baylibre.com>,
Bartosz Golaszewski <brgl@bgdev.pl>,
Michal Simek <michal.simek@xilinx.com>,
linux-stm32@st-md-mailman.stormreply.com,
Hammer Hsieh <hammerh0314@gmail.com>,
linux-rockchip@lists.infradead.org, Chen-Yu Tsai <wens@csie.org>,
Matthias Kaehlcke <mka@chromium.org>,
Broadcom internal kernel review list
<bcm-kernel-feedback-list@broadcom.com>,
NXP Linux Team <linux-imx@nxp.com>,
Orson Zhai <orsonzhai@gmail.com>,
linux-sunxi@lists.linux.dev, linux-pwm@vger.kernel.org,
Maxime Coquelin <mcoquelin.stm32@gmail.com>,
Martin Blumenstingl <martin.blumenstingl@googlemail.com>,
Ray Jui <rjui@broadcom.com>,
Sascha Hauer <s.hauer@pengutronix.de>,
Stephen Boyd <swboyd@chromium.org>,
linux-gpio@vger.kernel.org,
Fabrice Gasnier <fabrice.gasnier@foss.st.com>,
linux-mediatek@lists.infradead.org,
linux-rpi-kernel@lists.infradead.org,
Baolin Wang <baolin.wang@linux.alibaba.com>,
Paul Walmsley <paul.walmsley@sifive.com>,
Matthias Brugger <matthias.bgg@gmail.com>,
linux-amlogic@lists.infradead.org,
Benson Leung <bleung@chromium.org>,
linux-arm-kernel@lists.infradead.org,
Scott Branden <sbranden@broadcom.com>,
Bjorn Andersson <andersson@kernel.org>,
Nicolas Ferre <nicolas.ferre@microchip.com>,
Michael Walle <michael@walle.cc>,
Palmer Dabbelt <palmer@dabbelt.com>,
Pengutronix Kernel Team <kernel@pengutronix.de>,
Chunyan Zhang <zhang.lyra@gmail.com>,
Shawn Guo <shawnguo@kernel.org>,
Claudiu Beznea <claudiu.beznea@microchip.com>
Subject: Re: [PATCH v2 01/11] pwm: Make .get_state() callback return an error code
Date: Thu, 1 Dec 2022 14:17:07 +0000 [thread overview]
Message-ID: <20221201141707.28af0d1d@donnerap.cambridge.arm.com> (raw)
In-Reply-To: <20221201131604.beq4l22d42tjy6dm@pengutronix.de>
On Thu, 1 Dec 2022 14:16:04 +0100
Uwe Kleine-König <u.kleine-koenig@pengutronix.de> wrote:
Hi Uwe,
> Hello Andre,
>
> On Thu, Dec 01, 2022 at 10:22:52AM +0000, Andre Przywara wrote:
> > Just one comment: I don't see a sunxi specific patch later in the series,
> > though it seems we have at least one error error exit (see prescaler == 0
> > above). Plus potentially another exit if clk_get_rate() (at the very
> > beginning) fails.
> > Shall I send a patch for that?
>
> That would we very welcome. I mentioned that shortly in the cover
> letter, I wasn't entirely sure how to handle that prescaler = 0 case.
Ah right, sorry, I missed that.
So the Allwinner manual somehow marks those prescaler encodings as reserved
or invalid (it's just a "/" in there), and we never set those values in the
driver (there is an explicit check). So it could only be a leftover from
firmware/bootloader, or someone poking at this register behind our back.
I am tempted to just return some -EINVAL. As the current code stands, we
don't manipulate any state flags before that check, so it doesn't
really matter, but would be best practise, at least.
Cheers,
Andre
next prev parent reply other threads:[~2022-12-01 14:17 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-30 15:21 [PATCH v2 00/11] pwm: Allow .get_state to fail Uwe Kleine-König
2022-11-30 15:21 ` [PATCH v2 01/11] pwm: Make .get_state() callback return an error code Uwe Kleine-König
2022-11-30 18:36 ` Heiko Stübner
2022-12-01 1:17 ` Baolin Wang
2022-12-01 2:41 ` Tzung-Bi Shih
2022-12-01 8:03 ` Neil Armstrong
2022-12-01 9:30 ` nobuhiro1.iwamatsu
2022-12-01 10:22 ` Andre Przywara
2022-12-01 13:16 ` Uwe Kleine-König
2022-12-01 14:17 ` Andre Przywara [this message]
2022-12-01 10:43 ` Dave Stevenson
2022-12-01 15:37 ` Doug Anderson
2022-12-05 20:50 ` Jernej Škrabec
2022-12-05 22:30 ` Pavel Machek
2022-11-30 15:21 ` [PATCH v2 06/11] pwm: cros-ec: Propagate errors in .get_state() to the caller Uwe Kleine-König
2022-12-01 2:41 ` Tzung-Bi Shih
2022-12-01 11:11 ` [PATCH v2 00/11] pwm: Allow .get_state to fail Conor Dooley
2022-12-01 13:19 ` Uwe Kleine-König
2022-12-01 13:28 ` Conor Dooley
2022-12-09 21:47 ` Andy Shevchenko
2022-12-10 9:18 ` Uwe Kleine-König
2022-12-10 20:57 ` Andy Shevchenko
2022-12-10 22:41 ` Uwe Kleine-König
2022-12-11 13:31 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221201141707.28af0d1d@donnerap.cambridge.arm.com \
--to=andre.przywara@arm.com \
--cc=alexandre.belloni@bootlin.com \
--cc=alexandre.torgue@foss.st.com \
--cc=andersson@kernel.org \
--cc=baolin.wang@linux.alibaba.com \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=bleung@chromium.org \
--cc=brgl@bgdev.pl \
--cc=chrome-platform@lists.linux.dev \
--cc=claudiu.beznea@microchip.com \
--cc=conor.dooley@microchip.com \
--cc=dianders@chromium.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=f.fainelli@gmail.com \
--cc=fabrice.gasnier@foss.st.com \
--cc=festevam@gmail.com \
--cc=groeck@chromium.org \
--cc=hammerh0314@gmail.com \
--cc=heiko@sntech.de \
--cc=jbrunet@baylibre.com \
--cc=kernel@pengutronix.de \
--cc=khilman@baylibre.com \
--cc=linus.walleij@linaro.org \
--cc=linux-amlogic@lists.infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-imx@nxp.com \
--cc=linux-leds@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-pwm@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=linux-rpi-kernel@lists.infradead.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=linux-sunxi@lists.linux.dev \
--cc=martin.blumenstingl@googlemail.com \
--cc=matthias.bgg@gmail.com \
--cc=mcoquelin.stm32@gmail.com \
--cc=michael@walle.cc \
--cc=michal.simek@xilinx.com \
--cc=mka@chromium.org \
--cc=nicolas.ferre@microchip.com \
--cc=nobuhiro1.iwamatsu@toshiba.co.jp \
--cc=orsonzhai@gmail.com \
--cc=palmer@dabbelt.com \
--cc=paul.walmsley@sifive.com \
--cc=pavel@ucw.cz \
--cc=quic_c_skakit@quicinc.com \
--cc=rjui@broadcom.com \
--cc=s.hauer@pengutronix.de \
--cc=samuel@sholland.org \
--cc=sbranden@broadcom.com \
--cc=sean.anderson@seco.com \
--cc=shawnguo@kernel.org \
--cc=swboyd@chromium.org \
--cc=thierry.reding@gmail.com \
--cc=u.kleine-koenig@pengutronix.de \
--cc=wens@csie.org \
--cc=zhang.lyra@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox