Chrome platform driver development
 help / color / mirror / Atom feed
From: Rob Barnes <robbarnes@google.com>
To: groeck@chromium.org, pmalani@chromium.org
Cc: chrome-platform@lists.linux.dev, dtor@chromium.org,
	 Rob Barnes <robbarnes@google.com>
Subject: [PATCH v2 0/2] Handle CrOS EC Panics
Date: Tue,  3 Jan 2023 22:52:01 +0000	[thread overview]
Message-ID: <20230103225204.346088-1-robbarnes@google.com> (raw)
In-Reply-To: <CACeCKafGg5=1MQQdCtXDm-3LE2VsixHPsUDngRwQXUvAwQ=u=Q@mail.gmail.com>

Currently the OS ignores EC panics when they occur.
After reporting a panic, the EC will force a hard reset,
possibly after a short delay. This may cause loss of data.

These patches add a handler for CrOS EC panics. When
a panic is detected the OS will attempt to flush critical
data for debugging purposes and attempt an orderly shutdown.

Changelog since v1:
- Updated commit messages
- Split into two patches
- Moved panic handle before mkbp loop
- Switched to dev_emerg

Rob Barnes (2):
  platform/chrome: cros_ec: Poll EC log on EC panic
  platform/chrome: cros_ec: Shutdown on EC Panic

 drivers/platform/chrome/cros_ec_debugfs.c   | 23 +++++++++++++++++++++
 drivers/platform/chrome/cros_ec_lpc.c       | 10 +++++++++
 include/linux/platform_data/cros_ec_proto.h |  9 ++++++++
 3 files changed, 42 insertions(+)

-- 
2.39.0.314.g84b9a713c41-goog


  reply	other threads:[~2023-01-03 22:52 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-12-21 18:55 [PATCH] drivers/cros_ec: Handle CrOS EC panics Rob Barnes
2022-12-21 19:23 ` Prashant Malani
2022-12-21 23:55   ` Rob Barnes
2022-12-22  0:38     ` Prashant Malani
2023-01-03 22:52       ` Rob Barnes [this message]
2023-01-03 22:52         ` [PATCH v2 1/2] platform/chrome: cros_ec: Poll EC log on EC panic Rob Barnes
2023-01-03 23:14           ` Brian Norris
2023-01-03 23:17             ` Rob Barnes
2023-01-03 22:52         ` [PATCH v2 2/2] platform/chrome: cros_ec: Shutdown on EC Panic Rob Barnes
2023-01-03 23:14       ` [PATCH] drivers/cros_ec: Handle CrOS EC panics Rob Barnes
2023-01-03 23:27         ` Prashant Malani
2023-01-04  1:19           ` Rob Barnes
2022-12-21 20:07 ` Guenter Roeck
2022-12-21 23:55   ` Rob Barnes
2022-12-22  0:08     ` Guenter Roeck

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230103225204.346088-1-robbarnes@google.com \
    --to=robbarnes@google.com \
    --cc=chrome-platform@lists.linux.dev \
    --cc=dtor@chromium.org \
    --cc=groeck@chromium.org \
    --cc=pmalani@chromium.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox