From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D85F8748E for ; Sat, 21 Jan 2023 17:03:32 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id AC6A7C433D2; Sat, 21 Jan 2023 17:03:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1674320612; bh=KDw/+vNJAi/mknOa0WX6Ng3Q/0RA2pHOSwGQq7+EYNo=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=HuAvhLjB/S0zc04GEtF9VGWcCB7qG5XdOX/vEN1tGnJurqUyU5Va8pjleX2BpqDMx 1DBYEjVEnjBFx5TMJxCJXI7zrpQMWIMOexR1+df1B4bLny8/4vt2pzpJZmJyEfGgpQ VaalUoUBfg8Dg4BGmjUOzfEOW1RNNXiRf2hG+bdlbc+nqCoVFoQYaZC7SIcN3wQKYS vl/n8mO8rxnNzKFz6fOMO41bk802GYjzq+d/1MlwM8VFj0YnJsDTSbb/R2tuxHnaxy qtLkTzSJsB5UF4h5o5eq5Uixb94jhF7dkj3tZNB291jWt2N+6/jKr2Cl253RK7dQIq Y9ouSKjMPjr8g== Date: Sat, 21 Jan 2023 17:17:09 +0000 From: Jonathan Cameron To: Krzysztof Kozlowski Cc: Lars-Peter Clausen , Michael Hennerich , Rob Herring , Krzysztof Kozlowski , Lucas Stankus , Puranjay Mohan , Dmitry Rokosov , Alexandru Tachici , Marcelo Schmitt , Renato Lui Geh , Eugen Hristev , Nicolas Ferre , Alexandre Belloni , Claudiu Beznea , Andreas Klinger , Marcus Folkesson , Kent Gustavsson , Lad Prabhakar , Alim Akhtar , Maxime Coquelin , Alexandre Torgue , Oleksij Rempel , kernel@pengutronix.de, Nuno =?UTF-8?B?U8Oh?= , Nishant Malpani , Rui Miguel Silva , Dragos Bogdan , Jean-Baptiste Maneyrol , Lorenzo Bianconi , Benson Leung , Guenter Roeck , Stefan Popa , Robert Yang , Sean Nyekjaer , Artur Rojek , Miquel Raynal , Philippe Reynes , Alexandru Lazar , Linus Walleij , Caleb Connolly , Fabrice Gasnier , Stefan Agner , Daniel Baluta , Harald Geyer , Eugene Zaikonnikov , Phil Reid , Matt Ranostay , Stephen Boyd , Sankar Velliangiri , linux-iio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-fbdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-renesas-soc@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, chrome-platform@lists.linux.dev Subject: Re: [PATCH 3/5] dt-bindings: iio: correct node names in examples Message-ID: <20230121171709.5eb75e94@jic23-huawei> In-Reply-To: <20230118184413.395820-3-krzysztof.kozlowski@linaro.org> References: <20230118184413.395820-1-krzysztof.kozlowski@linaro.org> <20230118184413.395820-3-krzysztof.kozlowski@linaro.org> X-Mailer: Claws Mail 4.1.1 (GTK 3.24.36; x86_64-pc-linux-gnu) Precedence: bulk X-Mailing-List: chrome-platform@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Wed, 18 Jan 2023 19:44:11 +0100 Krzysztof Kozlowski wrote: > Do not use underscores and unneeded suffixes (e.g. i2c0) in node name in > examples. > > Signed-off-by: Krzysztof Kozlowski > --- > diff --git a/Documentation/devicetree/bindings/iio/health/ti,afe4403.yaml b/Documentation/devicetree/bindings/iio/health/ti,afe4403.yaml > index 6c5ad426a016..12f75ddc4a70 100644 > --- a/Documentation/devicetree/bindings/iio/health/ti,afe4403.yaml > +++ b/Documentation/devicetree/bindings/iio/health/ti,afe4403.yaml > @@ -42,7 +42,7 @@ examples: > #address-cells = <1>; > #size-cells = <0>; > > - heart_mon@0 { > + heart-rate@0 { These are both heart-rate and pulse oximeters so measure more than just the rate (oxygen saturation in the blood). Reality is they actually measure light absorption over time, but you can calculate an estimate of both rate and oxygen saturation from that. I don't really mind simplifying that to heart-rate, but wanted to call this out for possible discussion. > compatible = "ti,afe4403"; > reg = <0>; > spi-max-frequency = <10000000>; > diff --git a/Documentation/devicetree/bindings/iio/health/ti,afe4404.yaml b/Documentation/devicetree/bindings/iio/health/ti,afe4404.yaml > index c0e815d9999e..b334f3e356ad 100644 > --- a/Documentation/devicetree/bindings/iio/health/ti,afe4404.yaml > +++ b/Documentation/devicetree/bindings/iio/health/ti,afe4404.yaml > @@ -39,7 +39,7 @@ examples: > #address-cells = <1>; > #size-cells = <0>; > > - heart_mon@58 { > + heart-rate@58 { > compatible = "ti,afe4404"; > reg = <0x58>; > tx-supply = <&vbat>; The rest are all fine. If no one comments I'll pick this up as it is in a few days. Jonathan