From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7C859138D for ; Sun, 22 Jan 2023 16:47:28 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 2D688C433EF; Sun, 22 Jan 2023 16:47:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1674406048; bh=SvajHjiCSIBlcZUdVxMgRSWO0gJsGtBYT+mr1EHeu0o=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=HJZbJrnWcLLnDqOiDRQFyTuKeSBq7CbUfFHZzlhHwR68aZIpTBcnnH7lrVDHATIJ5 w/Mzn1otM7LO+JhZgcF1eRjNkHrIX6kH73HUxsbtJpGx+ipM17Qa0hyxxMfQoix/Tf r1748utHDH2gwfl5+RJVcuDS4ArHPfoVaxwDRawNux1S9sdh2RCaapXMO7IYw2RywK 8xy5xC0S7ec1wTzznrVHpd5sWmDaTKeuBj9DX4zXAVFJbGtMB2BbVg9U+46uDVAwvb mW3+T17DR98iKb/CTcKr2rU5fUJe4wEpXkmpsi/iTJG+Z0//Kr2KoAJJpvWkIqgRKh kv6ZWW4lNc7Nw== Date: Sun, 22 Jan 2023 17:01:05 +0000 From: Jonathan Cameron To: Krzysztof Kozlowski Cc: Lars-Peter Clausen , Michael Hennerich , Rob Herring , Krzysztof Kozlowski , Lucas Stankus , Puranjay Mohan , Dmitry Rokosov , Alexandru Tachici , Marcelo Schmitt , Renato Lui Geh , Eugen Hristev , Nicolas Ferre , Alexandre Belloni , Claudiu Beznea , Andreas Klinger , Marcus Folkesson , Kent Gustavsson , Lad Prabhakar , Alim Akhtar , Maxime Coquelin , Alexandre Torgue , Oleksij Rempel , kernel@pengutronix.de, Nuno =?UTF-8?B?U8Oh?= , Nishant Malpani , Rui Miguel Silva , Dragos Bogdan , Jean-Baptiste Maneyrol , Lorenzo Bianconi , Benson Leung , Guenter Roeck , Stefan Popa , Robert Yang , Sean Nyekjaer , Artur Rojek , Miquel Raynal , Philippe Reynes , Alexandru Lazar , Linus Walleij , Caleb Connolly , Fabrice Gasnier , Stefan Agner , Daniel Baluta , Harald Geyer , Eugene Zaikonnikov , Phil Reid , Matt Ranostay , Stephen Boyd , Sankar Velliangiri , linux-iio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-fbdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-renesas-soc@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, chrome-platform@lists.linux.dev Subject: Re: [PATCH 3/5] dt-bindings: iio: correct node names in examples Message-ID: <20230122170105.6a1a9766@jic23-huawei> In-Reply-To: <45b9b378-6619-c47a-b5ea-6b6b7edca785@linaro.org> References: <20230118184413.395820-1-krzysztof.kozlowski@linaro.org> <20230118184413.395820-3-krzysztof.kozlowski@linaro.org> <20230121171709.5eb75e94@jic23-huawei> <45b9b378-6619-c47a-b5ea-6b6b7edca785@linaro.org> X-Mailer: Claws Mail 4.1.1 (GTK 3.24.36; x86_64-pc-linux-gnu) Precedence: bulk X-Mailing-List: chrome-platform@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Sat, 21 Jan 2023 19:31:23 +0100 Krzysztof Kozlowski wrote: > On 21/01/2023 18:17, Jonathan Cameron wrote: > > On Wed, 18 Jan 2023 19:44:11 +0100 > > Krzysztof Kozlowski wrote: > > > >> Do not use underscores and unneeded suffixes (e.g. i2c0) in node name in > >> examples. > >> > >> Signed-off-by: Krzysztof Kozlowski > >> --- > > > >> diff --git a/Documentation/devicetree/bindings/iio/health/ti,afe4403.yaml b/Documentation/devicetree/bindings/iio/health/ti,afe4403.yaml > >> index 6c5ad426a016..12f75ddc4a70 100644 > >> --- a/Documentation/devicetree/bindings/iio/health/ti,afe4403.yaml > >> +++ b/Documentation/devicetree/bindings/iio/health/ti,afe4403.yaml > >> @@ -42,7 +42,7 @@ examples: > >> #address-cells = <1>; > >> #size-cells = <0>; > >> > >> - heart_mon@0 { > >> + heart-rate@0 { > > > > These are both heart-rate and pulse oximeters so measure more than just > > the rate (oxygen saturation in the blood). Reality is they actually > > measure light absorption over time, but you can calculate an estimate > > of both rate and oxygen saturation from that. > > > > I don't really mind simplifying that to heart-rate, but wanted to > > call this out for possible discussion. > > They could be heart-mon. The fix is mostly around the underscore. I > don't have any arguments for changing it to heart-rate, thus we can go > with whatever you prefer. I'm fine with either and as we have a patch with heart-rate that wins currently. I'll just let this sit for a little longer than normal to see if we get any other responses! Thanks, Jonathan > > Best regards, > Krzysztof >