From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-oi1-f174.google.com (mail-oi1-f174.google.com [209.85.167.174]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 279B47E2 for ; Mon, 23 Jan 2023 20:33:45 +0000 (UTC) Received: by mail-oi1-f174.google.com with SMTP id r9so11427741oig.12 for ; Mon, 23 Jan 2023 12:33:45 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=TrqI5Ij0O95gCzmKCmcYaV3PIFWC+QL1zw9c0VIbm+A=; b=PnvtVcWjNzM7y1IjtLWhv3KqnJMZcob6xuW0rW/qm5k8JCkFCRxInHhSLKn3irfE0t JAXYI/jbzMyHMoBxnKyV0rZTMKVxxw3aoICuaAZDjkIZ6ZW5shVas1sYnlgCSKjEwjV+ gLUt/jdmtqhtdykZg5XWcGKYUqy5hI4wKtuX2FMj8xnM9/feESljp+B91ODpsrCi38IE DKumEDGD24dlPtlk1llTHUOUTcH09SLvty0U8AmdIeYPd+rER4Ww/jLJNeYgsEOZqjnM kE90c77kOjaRchgfcLMRYZethKfJDSPa32YzjNk4e7/CF2a+A4g3GG9D9N/hZaYjaXN+ E0Ug== X-Gm-Message-State: AFqh2kq3cGveeXUzGsGOBIaZbMsGVVC60vawxU2W2qceqbSoSmfWlcEz 2mKDa6eE4ugkLEiPVpsuHQ== X-Google-Smtp-Source: AMrXdXsGKKWCKC87sdHRroBTg34rpaNG4pqP2GTedN+HwXhwJK32IDUo9Nlm9V/lhJeTRuJUTQ1oeQ== X-Received: by 2002:a05:6808:2819:b0:360:cd17:6968 with SMTP id et25-20020a056808281900b00360cd176968mr18783885oib.15.1674506024074; Mon, 23 Jan 2023 12:33:44 -0800 (PST) Received: from robh_at_kernel.org (66-90-144-107.dyn.grandenetworks.net. [66.90.144.107]) by smtp.gmail.com with ESMTPSA id bx35-20020a0568081b2300b0036701c185basm135326oib.55.2023.01.23.12.33.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 23 Jan 2023 12:33:43 -0800 (PST) Received: (nullmailer pid 2476342 invoked by uid 1000); Mon, 23 Jan 2023 20:33:41 -0000 Date: Mon, 23 Jan 2023 14:33:41 -0600 From: Rob Herring To: Jonathan Cameron Cc: Krzysztof Kozlowski , Lars-Peter Clausen , Michael Hennerich , Krzysztof Kozlowski , Lucas Stankus , Puranjay Mohan , Dmitry Rokosov , Alexandru Tachici , Marcelo Schmitt , Renato Lui Geh , Eugen Hristev , Nicolas Ferre , Alexandre Belloni , Claudiu Beznea , Andreas Klinger , Marcus Folkesson , Kent Gustavsson , Lad Prabhakar , Alim Akhtar , Maxime Coquelin , Alexandre Torgue , Oleksij Rempel , kernel@pengutronix.de, =?UTF-8?B?TnVubyBTw6E=?= , Nishant Malpani , Rui Miguel Silva , Dragos Bogdan , Jean-Baptiste Maneyrol , Lorenzo Bianconi , Benson Leung , Guenter Roeck , Stefan Popa , Robert Yang , Sean Nyekjaer , Artur Rojek , Miquel Raynal , Philippe Reynes , Alexandru Lazar , Linus Walleij , Caleb Connolly , Fabrice Gasnier , Stefan Agner , Daniel Baluta , Harald Geyer , Eugene Zaikonnikov , Phil Reid , Matt Ranostay , Stephen Boyd , Sankar Velliangiri , linux-iio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-fbdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-renesas-soc@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, chrome-platform@lists.linux.dev Subject: Re: [PATCH 3/5] dt-bindings: iio: correct node names in examples Message-ID: <20230123203341.GA2459877-robh@kernel.org> References: <20230118184413.395820-1-krzysztof.kozlowski@linaro.org> <20230118184413.395820-3-krzysztof.kozlowski@linaro.org> <20230121171709.5eb75e94@jic23-huawei> <45b9b378-6619-c47a-b5ea-6b6b7edca785@linaro.org> <20230122170105.6a1a9766@jic23-huawei> Precedence: bulk X-Mailing-List: chrome-platform@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230122170105.6a1a9766@jic23-huawei> On Sun, Jan 22, 2023 at 05:01:05PM +0000, Jonathan Cameron wrote: > On Sat, 21 Jan 2023 19:31:23 +0100 > Krzysztof Kozlowski wrote: > > > On 21/01/2023 18:17, Jonathan Cameron wrote: > > > On Wed, 18 Jan 2023 19:44:11 +0100 > > > Krzysztof Kozlowski wrote: > > > > > >> Do not use underscores and unneeded suffixes (e.g. i2c0) in node name in > > >> examples. > > >> > > >> Signed-off-by: Krzysztof Kozlowski > > >> --- > > > > > >> diff --git a/Documentation/devicetree/bindings/iio/health/ti,afe4403.yaml b/Documentation/devicetree/bindings/iio/health/ti,afe4403.yaml > > >> index 6c5ad426a016..12f75ddc4a70 100644 > > >> --- a/Documentation/devicetree/bindings/iio/health/ti,afe4403.yaml > > >> +++ b/Documentation/devicetree/bindings/iio/health/ti,afe4403.yaml > > >> @@ -42,7 +42,7 @@ examples: > > >> #address-cells = <1>; > > >> #size-cells = <0>; > > >> > > >> - heart_mon@0 { > > >> + heart-rate@0 { > > > > > > These are both heart-rate and pulse oximeters so measure more than just > > > the rate (oxygen saturation in the blood). Reality is they actually > > > measure light absorption over time, but you can calculate an estimate > > > of both rate and oxygen saturation from that. > > > > > > I don't really mind simplifying that to heart-rate, but wanted to > > > call this out for possible discussion. > > > > They could be heart-mon. The fix is mostly around the underscore. I > > don't have any arguments for changing it to heart-rate, thus we can go > > with whatever you prefer. > I'm fine with either and as we have a patch with heart-rate that wins > currently. I'll just let this sit for a little longer than > normal to see if we get any other responses! I don't care all that much until we've documented something. Otherwise, we may be just changing things twice. We have the list in the spec, but really I'd like that in schema form. We'd also need to figure out how to use that. There's always going to be odd things which we don't have any defined name. For now, I'd just do 's/_/-/'. Rob