From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 33FFB2E634 for ; Tue, 7 Nov 2023 12:11:47 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="hfw8FOgx" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 4AC3CC43397; Tue, 7 Nov 2023 12:11:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1699359107; bh=Gs8lRYHG/QEOT40sG68E/a1IAjmfaXVTdhAS+MD2BBY=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=hfw8FOgxTt1M/QZh0zIgsO/i08gGko3/+IZN49TubCtBfRhDTfF5Mojl0i+byULCa rhoOuyQ38rNuFoKTcDJmluxVLgpXyCbxIf2Zh7JPtwSn+73ZSAAnY/O/dw3T6RzVIv r3eOA2J1XxUC6PknAtS6163gKOPh+E/IWSrrZDkBBuezAearFXD1xKXhfTAq7OlGb3 SEiR8qSfRb0iiUjLMHxOx2lZr2rzAWwqzdB0hJfIKUIdUiHSpxDuKVhwPMKfhKJSwy gVZJ058qcDYdsxsPlUPG1fcYhGRZSOMhxX2tf34dQt/vmCfgYaT6zZ67vZfTgXeLq0 t8YHC6n88faWw== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Tzung-Bi Shih , Guenter Roeck , Sasha Levin , bleung@chromium.org, chrome-platform@lists.linux.dev Subject: [PATCH AUTOSEL 6.1 17/18] platform/chrome: kunit: initialize lock for fake ec_dev Date: Tue, 7 Nov 2023 07:10:47 -0500 Message-ID: <20231107121104.3757943-17-sashal@kernel.org> X-Mailer: git-send-email 2.42.0 In-Reply-To: <20231107121104.3757943-1-sashal@kernel.org> References: <20231107121104.3757943-1-sashal@kernel.org> Precedence: bulk X-Mailing-List: chrome-platform@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore X-stable-base: Linux 6.1.61 Content-Transfer-Encoding: 8bit From: Tzung-Bi Shih [ Upstream commit e410b4ade83d06a046f6e32b5085997502ba0559 ] cros_ec_cmd_xfer() uses ec_dev->lock. Initialize it. Otherwise, dmesg shows the following: > DEBUG_LOCKS_WARN_ON(lock->magic != lock) > ... > Call Trace: > ? __mutex_lock > ? __warn > ? __mutex_lock > ... > ? cros_ec_cmd_xfer Reviewed-by: Guenter Roeck Link: https://lore.kernel.org/r/20231003080504.4011337-1-tzungbi@kernel.org Signed-off-by: Tzung-Bi Shih Signed-off-by: Sasha Levin --- drivers/platform/chrome/cros_ec_proto_test.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/platform/chrome/cros_ec_proto_test.c b/drivers/platform/chrome/cros_ec_proto_test.c index c6a83df91ae1e..b46a8bc2196fe 100644 --- a/drivers/platform/chrome/cros_ec_proto_test.c +++ b/drivers/platform/chrome/cros_ec_proto_test.c @@ -2667,6 +2667,7 @@ static int cros_ec_proto_test_init(struct kunit *test) ec_dev->dev->release = cros_ec_proto_test_release; ec_dev->cmd_xfer = cros_kunit_ec_xfer_mock; ec_dev->pkt_xfer = cros_kunit_ec_xfer_mock; + mutex_init(&ec_dev->lock); priv->msg = (struct cros_ec_command *)priv->_msg; -- 2.42.0