Chrome platform driver development
 help / color / mirror / Atom feed
From: Dawid Niedzwiecki <dawidn@google.com>
To: Tzung-Bi Shih <tzungbi@kernel.org>, Benson Leung <bleung@chromium.org>
Cc: chrome-platform@lists.linux.dev, linux-kernel@vger.kernel.org,
	 chromeos-krk-upstreaming@google.com,
	Dawid Niedzwiecki <dawidn@google.com>
Subject: [PATCH v3 0/2] platform/chrome: cros_ec: improve probing for RWSIG
Date: Fri,  6 Dec 2024 09:15:12 +0000	[thread overview]
Message-ID: <20241206091514.2538350-1-dawidn@google.com> (raw)

V2 -> V3:
- Move exiting from `cros_ec_rwsig_continue` if `error_count` exceeds
  `RWSIG_CONTINUE_MAX_ERRORS_IN_ROW` to the `if (rev < 0)` statement when
  `error_count` is incremented.

V1 -> V2:
- Use dev_info instead of dev_warn when cros_ec_rwsig_continue returns
  an error.
- Return immediately from cros_ec_rwsig_continue, if the RWSIG_ACTION
  command fails itself, not SPI transaction.

Dawid Niedzwiecki (2):
  platform/chrome: cros_ec: jump to RW before probing
  platform/chrome: cros_ec_proto: remove unnecessary retries

 drivers/platform/chrome/cros_ec.c           |  5 ++
 drivers/platform/chrome/cros_ec_i2c.c       |  3 +-
 drivers/platform/chrome/cros_ec_ishtp.c     |  2 +-
 drivers/platform/chrome/cros_ec_lpc.c       |  2 +-
 drivers/platform/chrome/cros_ec_proto.c     | 69 ++++++++++++++++++---
 drivers/platform/chrome/cros_ec_rpmsg.c     |  2 +-
 drivers/platform/chrome/cros_ec_spi.c       |  2 +-
 drivers/platform/chrome/cros_ec_uart.c      |  2 +-
 include/linux/platform_data/cros_ec_proto.h |  2 +
 9 files changed, 74 insertions(+), 15 deletions(-)

-- 
2.47.0.338.g60cca15819-goog


             reply	other threads:[~2024-12-06  9:15 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-12-06  9:15 Dawid Niedzwiecki [this message]
2024-12-06  9:15 ` [PATCH v3 1/2] platform/chrome: cros_ec: jump to RW before probing Dawid Niedzwiecki
2024-12-06  9:15 ` [PATCH v3 2/2] platform/chrome: cros_ec_proto: remove unnecessary retries Dawid Niedzwiecki
2024-12-09  2:20 ` [PATCH v3 0/2] platform/chrome: cros_ec: improve probing for RWSIG Tzung-Bi Shih

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20241206091514.2538350-1-dawidn@google.com \
    --to=dawidn@google.com \
    --cc=bleung@chromium.org \
    --cc=chrome-platform@lists.linux.dev \
    --cc=chromeos-krk-upstreaming@google.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=tzungbi@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox