From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f179.google.com (mail-pl1-f179.google.com [209.85.214.179]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 386C3BE6C for ; Wed, 16 Apr 2025 00:02:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.179 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744761735; cv=none; b=WSr+q6zcrr4LXFzuvG+h3l/tGXZ5WBYoRgA6Rt77cRC3LszTur6l54hkMyFsRUE8HNRaQ1R2zsk81hUE16EK0D463vsWFIqO/FYdw3lCTcHD+NUoHj2PAgea6s34rShhIUlnrMlAhf78dRPQ6q6Kk1gcLISxl/VJwSEOUEN2r9w= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744761735; c=relaxed/simple; bh=9LdBVOezi3+S4+ZxOQ8+mmTVUoo6eXOCdNB3fmZA2G8=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=ArPsCF+cLuonJzTxMPFjKSdGRQZ+57xC2Oeah0tC0DRUVrO9MJr8rqdCjCxMuBes8mWhpT+hVyIJjwdCwp4X9y4ntgoT2cBt4gW7BOT5Cjs7/8w5ED8FA7Fg/R9hjsIHLNrkKYpplNQkfn08hFhxpv28DA+JJyi5SmeOX1mtgmc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org; spf=pass smtp.mailfrom=chromium.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b=dvkol6CG; arc=none smtp.client-ip=209.85.214.179 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=chromium.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="dvkol6CG" Received: by mail-pl1-f179.google.com with SMTP id d9443c01a7336-224100e9a5cso70614475ad.2 for ; Tue, 15 Apr 2025 17:02:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1744761733; x=1745366533; darn=lists.linux.dev; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=ETD26CH6iD+0uFy4hgKYmRwgyWbV2LZsUcS2ttgEWQs=; b=dvkol6CG11OQh6F3fhZRYU05Ma0kbjJGO0UUW5MZCpNCjwzpMVrnKq5uF3nlopriA1 EL7iSBGIBw6deuOYv/GUbY5snJ2jfFK/oAzxyqDtWEgkLj3QmDib6V2o2veGwFxSDGyI k/y4QWSl2XdVAXfLJpZdVrEWM8mhp/Do6sRFA= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1744761733; x=1745366533; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=ETD26CH6iD+0uFy4hgKYmRwgyWbV2LZsUcS2ttgEWQs=; b=NpLlb4CgCLVRr95VZMzvt8LjusBrDhB3T6XhQTN/9ZL5R8Yu6GEHS7WtPYzENYrEbF 3703l57wfutoAuBihZCBO4t3jEWsCPvQIVVnIo2rR2lrzf+73lbLVTg+pnbROhQq2ihY ZRsNA10vDqhpilqWXsYjB3v1eTYCxsttUqXaDf7eScNDGZAkcT/+Tc2+iEeSx5aXirrd vO0v2PTPt5OZyZR9Lt4tXSCoZOYu9nNI5vHguaGMn4PNhjWnolf1ZaaIpMCPMSqxYEai 5c3Byu5emTVJPohLuE9shmgmwyotmRGg2rPBKehJNf/Z75GFZVA5rELo0nmpDfymqMst 4lzg== X-Forwarded-Encrypted: i=1; AJvYcCVX97+OnQGDZ7hvFldurerEl34Y21BJGQbVuMJSofl7AUwszO+7NQ3wEwvkAQSNd1iXmAU7NRbgbFa7YN6uNA8=@lists.linux.dev X-Gm-Message-State: AOJu0Yy/ZVTZXp0A6W0H2U7v85g6q+/hswYuqzpsG9VkK/LW8gs8s5CN 4S4pNNp92QcmPu/j2EJZmsxpBEel7eom8+RP0bdol8sbypt4RUwUFkpys28wVg== X-Gm-Gg: ASbGnctgy0AcxxCGD4E4ZpX+tE9LjwyAylmWnVVLtUhGyiizRxL42TspuMm6KX+yNfR P/4Wn0T5tGhvquAUhybXdWcTX7wq8HDklfqqiDmvMJ5FgD6xAzjJrxxo44EkZxdzgbHXNfSrKRx O90xBklLgfFOAq/0s0XAzLHofAkoWiJGq/H5inOwBM3R10+/z0ocm1SRUIAgfcQ6QbEOSqIXymO dnhCwY0Ex02j/5aVDfsUWngeYTZmHGs9cdv1p+a19/16+FPncEbhsiMJmroOFeiGj8w5jexglPN aDwvx8dTZRKNdZ0usvybcpAEXRo+Kdq1tQQZRZOUPjPtBeNSPI1/AvI1jpzUgbXH7KoLi+9vfQU jxA== X-Google-Smtp-Source: AGHT+IGTNhPFIcDKlL3bF0SzfSJ7SIXjnXhh0YeuCFsofT603F8bPtE9D2lDaA650EUHL4OU3b5nnQ== X-Received: by 2002:a17:903:2a85:b0:220:e63c:5aff with SMTP id d9443c01a7336-22c31ae8e3emr14464865ad.47.1744761733360; Tue, 15 Apr 2025 17:02:13 -0700 (PDT) Received: from localhost (199.24.125.34.bc.googleusercontent.com. [34.125.24.199]) by smtp.gmail.com with UTF8SMTPSA id d9443c01a7336-22c33fc47e0sm1235925ad.167.2025.04.15.17.02.12 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 15 Apr 2025 17:02:13 -0700 (PDT) From: Stephen Boyd To: Tzung-Bi Shih Cc: linux-kernel@vger.kernel.org, patches@lists.linux.dev, Bjorn Andersson , Konrad Dybcio , devicetree@vger.kernel.org, Dmitry Baryshkov , Krzysztof Kozlowski , Rob Herring , linux-arm-msm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Conor Dooley , Benson Leung , chrome-platform@lists.linux.dev, Pin-yen Lin , Abhishek Pandit-Subedi , =?UTF-8?q?=C5=81ukasz=20Bartosik?= , Jameson Thies , Andrei Kuchynski Subject: [PATCH 1/7] platform/chrome: cros_ec_typec: No pending status means attention Date: Tue, 15 Apr 2025 17:02:01 -0700 Message-ID: <20250416000208.3568635-2-swboyd@chromium.org> X-Mailer: git-send-email 2.49.0.604.gff1f9ca942-goog In-Reply-To: <20250416000208.3568635-1-swboyd@chromium.org> References: <20250416000208.3568635-1-swboyd@chromium.org> Precedence: bulk X-Mailing-List: chrome-platform@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit If we aren't expecting a status update when cros_typec_displayport_status_update() is called then we're handling an attention message, like HPD high/low or IRQ. Call typec_altmode_attention() in this case so that HPD signaling works in the DP altmode driver. Cc: Benson Leung Cc: Tzung-Bi Shih Cc: Cc: Pin-yen Lin Cc: Abhishek Pandit-Subedi Cc: Łukasz Bartosik Cc: Jameson Thies Cc: Andrei Kuchynski Signed-off-by: Stephen Boyd --- drivers/platform/chrome/cros_typec_altmode.c | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/drivers/platform/chrome/cros_typec_altmode.c b/drivers/platform/chrome/cros_typec_altmode.c index 557340b53af0..c2d9c548b5e8 100644 --- a/drivers/platform/chrome/cros_typec_altmode.c +++ b/drivers/platform/chrome/cros_typec_altmode.c @@ -280,11 +280,8 @@ int cros_typec_displayport_status_update(struct typec_altmode *altmode, typec_altmode_get_drvdata(altmode); struct cros_typec_altmode_data *adata = &dp_data->adata; - if (!dp_data->pending_status_update) { - dev_dbg(&altmode->dev, - "Got DPStatus without a pending request\n"); - return 0; - } + if (!dp_data->pending_status_update) + return typec_altmode_attention(altmode, data->status); if (dp_data->configured && dp_data->data.conf != data->conf) dev_dbg(&altmode->dev, -- https://chromeos.dev