From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from relay6-d.mail.gandi.net (relay6-d.mail.gandi.net [217.70.183.198]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 09978126BF1; Thu, 22 May 2025 15:56:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=217.70.183.198 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1747929402; cv=none; b=Q2Qm8GieBcNZR7hIIG/DO80aT2qmYRmSi4ymW4VJq7dJFXVWufAMiooOd4oPAaV7DymiOojHzVp6R/XQLE3GeRz03G4gCpNyQ/FjQg9mewkOANhffqdSvAY3wL0dOw0CC5I9XSJ1IROB17OyEHmeo+WlDD2GqTx7EpCtPd6Gugk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1747929402; c=relaxed/simple; bh=wQH70eo1sPSqO0FtIIJnBv1zebflYdHlHJdMqRCxIeI=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=nd1XH85gpEgm5+NJ+crUrq9X1SltNkHbGfCKnblK80110p1OXbq3/MzCU4Hs98x05GEwF3cWgtgoSScY8idZ5Z9uAPmvreHys1WOEtJmOW+LfcB6V2J/VTErPflfHpzQDqau7NZw1YrOdDof7AWqbuSSuONZ6kQVo9zkf2W2w1E= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com; spf=pass smtp.mailfrom=bootlin.com; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b=LrOFkxjD; arc=none smtp.client-ip=217.70.183.198 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=bootlin.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b="LrOFkxjD" Received: by mail.gandi.net (Postfix) with ESMTPSA id 62288439A5; Thu, 22 May 2025 15:56:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1747929396; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=hDrRfxUh05bF14pzZXQ+mC3f/tIJuaPORyh0q5iuGpM=; b=LrOFkxjDWfPYlaJ27v0bKylFL4XWO+4kvvgStRLZlUDRYZHdyChNIb2pfDuGENtsuftdv/ wGbOCWfZtxzREyaEFwnH82wXULSKdAdYw/PBXzq/zAP46MQh+2qKay6Pd/jwy3zwxJN8dw rgJTGQYyYqHyrBnB5+bbAyyUPyuK4SQmrz1l5b6bKlFTJX3baN6Ej14byKnrUchMCQnb3+ vJDkRIAED2cQX+6NzREg8KVZNhwI6WQ0582mb8M9FYZVQz3yCa/TIqtPexDE/d9Fb/Krsm aRFHR6fwOi/MpKAjV481sgJjj5EABYXpHVIjb+acU9Q+t95PRAEbZnkSC880OA== Date: Thu, 22 May 2025 17:56:23 +0200 From: Luca Ceresoli To: Maxime Ripard Cc: Maarten Lankhorst , Thomas Zimmermann , David Airlie , Simona Vetter , Andrzej Hajda , Neil Armstrong , Robert Foss , Laurent Pinchart , Jonas Karlman , Jernej Skrabec , Jagan Teki , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Douglas Anderson , Chun-Kuang Hu , Krzysztof Kozlowski , Liu Ying , Anusha Srivatsa , Paul Kocialkowski , Dmitry Baryshkov , Hui Pu , Thomas Petazzoni , dri-devel@lists.freedesktop.org, asahi@lists.linux.dev, linux-kernel@vger.kernel.org, chrome-platform@lists.linux.dev, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-amlogic@lists.infradead.org, linux-renesas-soc@vger.kernel.org, platform-driver-x86@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-arm-msm@vger.kernel.org, freedreno@lists.freedesktop.org, linux-stm32@st-md-mailman.stormreply.com, Louis Chauvet , Alim Akhtar , Inki Dae , Kyungmin Park , Seung-Woo Kim , Manikandan Muralidharan , Adam Ford , Adrien Grassein , Aleksandr Mishin , Andy Yan , AngeloGioacchino Del Regno , Benson Leung , Biju Das , Christoph Fritz , Cristian Ciocaltea , Detlev Casanova , Dharma Balasubiramani , Guenter Roeck , Heiko Stuebner , Jani Nikula , Janne Grunau , Jerome Brunet , Jesse Van Gavere , Kevin Hilman , Kieran Bingham , Martin Blumenstingl , Matthias Brugger , Philipp Zabel , Phong LE , Sasha Finkelstein , Sugar Zhang , Sui Jingfeng , Tomi Valkeinen , Vitalii Mordan , "Rob Herring (Arm)" , Hsin-Te Yuan , Pin-yen Lin , Xin Ji , Aradhya Bhatia , Tomi Valkeinen , Ian Ray , Martyn Welch , Peter Senna Tschudin , Helge Deller , Kuninori Morimoto , Laurent Pinchart , Alexandre Torgue , Maxime Coquelin , Philippe Cornu , Raphael Gallais-Pou , Yannick Fertre , Alain Volmat , Raphael Gallais-Pou , Michal Simek , Jonathan Corbet , linux-doc@vger.kernel.org Subject: Re: [PATCH v3 00/22] drm: convert all bridges to devm_drm_bridge_alloc() Message-ID: <20250522175623.1a6d9b14@booty> In-Reply-To: <20250522-amphibian-shiny-chachalaca-cf05ba@houat> References: <20250509-drm-bridge-convert-to-alloc-api-v3-0-b8bc1f16d7aa@bootlin.com> <20250521162216.79dd3290@booty> <20250522-amphibian-shiny-chachalaca-cf05ba@houat> Organization: Bootlin X-Mailer: Claws Mail 4.3.1 (GTK 3.24.49; x86_64-redhat-linux-gnu) Precedence: bulk X-Mailing-List: chrome-platform@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-GND-State: clean X-GND-Score: -100 X-GND-Cause: gggruggvucftvghtrhhoucdtuddrgeeffedrtddtgdeifeejucdltddurdegfedvrddttddmucetufdoteggodetrfdotffvucfrrhhofhhilhgvmecuifetpfffkfdpucggtfgfnhhsuhgsshgtrhhisggvnecuuegrihhlohhuthemuceftddunecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenucfjughrpeffhffvvefukfgjfhhoofggtgfgsehtjeertdertddvnecuhfhrohhmpefnuhgtrgcuvegvrhgvshholhhiuceolhhutggrrdgtvghrvghsohhlihessghoohhtlhhinhdrtghomheqnecuggftrfgrthhtvghrnhepgfejhffgjeelkeeftdekfefgteekgefhleelueeijeffieekieeigefhledtffetnecuffhomhgrihhnpehkvghrnhgvlhdrohhrghdpfhhrvggvuggvshhkthhophdrohhrghdpsghoohhtlhhinhdrtghomhenucfkphepvdgrtddvmeeijedtmedvtddvtdemvggrtddumegsvgegudemleehvgejmeefgeefmeeludefvgenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepihhnvghtpedvrgdtvdemieejtdemvddtvddtmegvrgdtudemsggvgedumeelhegvjeemfeegfeemledufegvpdhhvghlohepsghoohhthidpmhgrihhlfhhrohhmpehluhgtrgdrtggvrhgvshholhhisegsohhothhlihhnrdgtohhmpdhnsggprhgtphhtthhopeelhedprhgtphhtthhopehmrhhiphgrrhgusehkvghrnhgvlhdrohhrghdprhgtphhtthhopehmrggrrhhtvghnrdhlrghnkhhho hhrshhtsehlihhnuhigrdhinhhtvghlrdgtohhmpdhrtghpthhtohepthiiihhmmhgvrhhmrghnnhesshhushgvrdguvgdprhgtphhtthhopegrihhrlhhivggusehgmhgrihhlrdgtohhmpdhrtghpthhtohepshhimhhonhgrsehffhiflhhlrdgthhdprhgtphhtthhopegrnhgurhiivghjrdhhrghjuggrsehinhhtvghlrdgtohhmpdhrtghpthhtohepnhgvihhlrdgrrhhmshhtrhhonhhgsehlihhnrghrohdrohhrghdprhgtphhtthhopehrfhhoshhssehkvghrnhgvlhdrohhrgh X-GND-Sasl: luca.ceresoli@bootlin.com Hi Maxime, On Thu, 22 May 2025 16:57:30 +0200 Maxime Ripard wrote: [...] > > As the commit was a mistake, I'm applying the revert by the end of this > > week (i.e. on Friday) unless there are better instructions. > > Given the lack of answers, and that it looks correct to me, just leave > it there. We can always revert later on if things turned out to be > broken. OK, I'll leave the commit and drop the revert in v4. > > > drm: convert many bridge drivers from devm_kzalloc() to devm_drm_bridge_alloc() API > > > > This patch affects multiple drivers. Running get_maintainers.pl > > points at Shawn Guo's repository. After reviewing the MAINTAINERS file, > > this looks like due to the 'N:' line in: > > > > ARM/FREESCALE IMX / MXC ARM ARCHITECTURE > > M: Shawn Guo > > M: Sascha Hauer > > R: Pengutronix Kernel Team > > ... > > T: git git://git.kernel.org/pub/scm/linux/kernel/git/shawnguo/linux.git > > N: imx > > ... > > > > (https://gitlab.freedesktop.org/drm/misc/kernel/-/blob/drm-misc-next/MAINTAINERS?ref_type=heads#L2511-2528) > > > > Here 'imx' matches the 'drivers/gpu/drm/bridge/imx/imx-legacy-bridge.c' > > file that is touched by the patch. That regexp appears overly generic to me. > > I agree, or at least, we shouldn't wait for Shawn or Sasha... > > > Shawn, can it be fixed by making it less generic? > > > > If not, can we at least add a band-aid 'X:' entry for > > drivers/gpu/drm/bridge/imx? > > > > I think the other matching entry is the one to consider: > > > > DRM DRIVERS FOR FREESCALE IMX BRIDGE > > M: Liu Ying > > L: dri-devel@lists.freedesktop.org > > S: Maintained > > F: Documentation/devicetree/bindings/display/bridge/fsl,imx8qxp-ldb.yaml > > F: Documentation/devicetree/bindings/display/bridge/fsl,imx8qxp-pixel-combiner.yaml > > F: Documentation/devicetree/bindings/display/bridge/fsl,imx8qxp-pixel-link.yaml > > F: Documentation/devicetree/bindings/display/bridge/fsl,imx8qxp-pxl2dpi.yaml > > F: drivers/gpu/drm/bridge/imx/ > > > > (https://gitlab.freedesktop.org/drm/misc/kernel/-/blob/drm-misc-next/MAINTAINERS?ref_type=heads#L7940-7948) > > ... As long as Ying is fine with it, because it does look like they are > the actual maintainer. Ack, thanks for confirming this. Bottom line, given that large patch has your Acked-by, and given the shawnguo repo was ruled out, the conclusion is it can apply it to drm-misc-next. Having that large patch applied will be relieving me a lot! I think next time I'm going to split any imilar change in per-driver patches, even if it is spatch-automated. > > > drm/todo: add entry to remove devm_drm_put_bridge() > > > > This involves documentation maintained on another tree. Where should it > > be applied? There are two matching entries in MAINTAINERS: > > > > * DRM DRIVERS -> the drm tree > > * DRM DRIVERS AND MISC GPU PATCHES -> the drm-misc tree > > > > To me it looks like the second is obviously the closest match as we are > > dealing with DRM bridges, so I'm applying this as well on Friday unless > > there are better instructions. > > Yes, they should be applied to drm-misc. OK, will do soon. > That being said, putting a two days timeout on *any* email is really > over-the-top. I doubt you reply to any of your mail in such a short > timeframe. We have rules for a reason, I'd expect you to follow them, no > matter how frustrating the lack of answers can be. Apologies if that was too much. I was indeed nervous about the revert. A patch got applied by mistake and I believe it should have been reverted very quickly, if need be. Both Louis and I didn't want to break the process again. So we asked, but not having answer after 2+ weeks I must admit I got a bit nervous about it. Sorry about that and thanks for the feedback about my questions. Luca -- Luca Ceresoli, Bootlin Embedded Linux and Kernel engineering https://bootlin.com