From: Andrei Kuchynski <akuchynski@chromium.org>
To: Heikki Krogerus <heikki.krogerus@linux.intel.com>,
Dmitry Baryshkov <lumag@kernel.org>,
Abhishek Pandit-Subedi <abhishekpandit@chromium.org>,
Jameson Thies <jthies@google.com>,
Benson Leung <bleung@chromium.org>,
Tzung-Bi Shih <tzungbi@kernel.org>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Guenter Roeck <groeck@chromium.org>,
Pooja Katiyar <pooja.katiyar@intel.com>,
Badhri Jagan Sridharan <badhri@google.com>,
RD Babiera <rdbabiera@google.com>,
linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
chrome-platform@lists.linux.dev,
Andrei Kuchynski <akuchynski@chromium.org>
Subject: [PATCH 07/10] usb: typec: Report altmode entry status via callback
Date: Mon, 16 Jun 2025 13:31:44 +0000 [thread overview]
Message-ID: <20250616133147.1835939-8-akuchynski@chromium.org> (raw)
In-Reply-To: <20250616133147.1835939-1-akuchynski@chromium.org>
The Type-C mode selection logic requires feedback on the result of an
alternate mode entry attempt.
Call the `typec_mode_selection_altmode_complete()` callback to provide
this final success or failure status.
Signed-off-by: Andrei Kuchynski <akuchynski@chromium.org>
---
drivers/usb/typec/altmodes/displayport.c | 13 +++++++++++--
drivers/usb/typec/altmodes/thunderbolt.c | 6 ++++++
include/linux/usb/typec_tbt.h | 3 +++
3 files changed, 20 insertions(+), 2 deletions(-)
diff --git a/drivers/usb/typec/altmodes/displayport.c b/drivers/usb/typec/altmodes/displayport.c
index ac84a6d64c2f..946f61b57fa0 100644
--- a/drivers/usb/typec/altmodes/displayport.c
+++ b/drivers/usb/typec/altmodes/displayport.c
@@ -274,16 +274,20 @@ static void dp_altmode_work(struct work_struct *work)
header = DP_HEADER(dp, svdm_version, DP_CMD_STATUS_UPDATE);
vdo = 1;
ret = typec_altmode_vdm(dp->alt, header, &vdo, 2);
- if (ret)
+ if (ret) {
dev_err(&dp->alt->dev,
"unable to send Status Update command (%d)\n",
ret);
+ typec_mode_selection_altmode_complete(dp->alt, ret);
+ }
break;
case DP_STATE_CONFIGURE:
ret = dp_altmode_configure_vdm(dp, dp->data.conf);
- if (ret)
+ if (ret) {
dev_err(&dp->alt->dev,
"unable to send Configure command (%d)\n", ret);
+ typec_mode_selection_altmode_complete(dp->alt, ret);
+ }
break;
case DP_STATE_CONFIGURE_PRIME:
ret = dp_altmode_configure_vdm_cable(dp, dp->data_prime.conf);
@@ -397,6 +401,9 @@ static int dp_altmode_vdm(struct typec_altmode *alt,
dp->data.conf = 0;
ret = dp_altmode_configured(dp);
break;
+ case DP_CMD_STATUS_UPDATE:
+ ret = *(int *)vdo;
+ break;
default:
break;
}
@@ -407,6 +414,8 @@ static int dp_altmode_vdm(struct typec_altmode *alt,
if (dp->state != DP_STATE_IDLE)
schedule_work(&dp->work);
+ else if (ret || cmd == DP_CMD_CONFIGURE)
+ typec_mode_selection_altmode_complete(dp->alt, ret);
err_unlock:
mutex_unlock(&dp->lock);
diff --git a/drivers/usb/typec/altmodes/thunderbolt.c b/drivers/usb/typec/altmodes/thunderbolt.c
index 6eadf7835f8f..697ab6060652 100644
--- a/drivers/usb/typec/altmodes/thunderbolt.c
+++ b/drivers/usb/typec/altmodes/thunderbolt.c
@@ -242,6 +242,9 @@ static int tbt_altmode_vdm(struct typec_altmode *alt,
else if (tbt->plug[TYPEC_PLUG_SOP_P])
tbt->state = TBT_STATE_SOP_P_EXIT;
break;
+ case TBT_CMD_STATUS_UPDATE:
+ typec_mode_selection_altmode_complete(alt, 0);
+ break;
}
break;
case CMDT_RSP_NAK:
@@ -249,6 +252,9 @@ static int tbt_altmode_vdm(struct typec_altmode *alt,
case CMD_ENTER_MODE:
dev_warn(&alt->dev, "Enter Mode refused\n");
break;
+ case TBT_CMD_STATUS_UPDATE:
+ typec_mode_selection_altmode_complete(alt, *(int *)vdo);
+ break;
default:
break;
}
diff --git a/include/linux/usb/typec_tbt.h b/include/linux/usb/typec_tbt.h
index 55dcea12082c..57cbda5292bb 100644
--- a/include/linux/usb/typec_tbt.h
+++ b/include/linux/usb/typec_tbt.h
@@ -24,6 +24,9 @@ struct typec_thunderbolt_data {
u32 enter_vdo;
};
+/* TBT3 alt mode specific commands */
+#define TBT_CMD_STATUS_UPDATE VDO_CMD_VENDOR(0)
+
/* TBT3 Device Discover Mode VDO bits */
#define TBT_MODE BIT(0)
#define TBT_ADAPTER(_vdo_) FIELD_GET(BIT(16), _vdo_)
--
2.50.0.rc1.591.g9c95f17f64-goog
next prev parent reply other threads:[~2025-06-16 13:33 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-16 13:31 [PATCH 00/10] USB Type-C mode selection Andrei Kuchynski
2025-06-16 13:31 ` [PATCH 01/10] usb: typec: Add alt_mode_override field to port property Andrei Kuchynski
2025-06-16 13:31 ` [PATCH 02/10] platform/chrome: cros_ec_typec: Set alt_mode_override flag Andrei Kuchynski
2025-06-16 13:31 ` [PATCH 03/10] usb: typec: ucsi: " Andrei Kuchynski
2025-06-16 13:31 ` [PATCH 04/10] usb: typec: Expose alternate mode priorities via sysfs Andrei Kuchynski
2025-06-17 9:50 ` Heikki Krogerus
2025-06-17 12:38 ` Andrei Kuchynski
2025-06-17 13:28 ` Greg Kroah-Hartman
2025-06-18 2:47 ` Abhishek Pandit-Subedi
2025-06-18 13:42 ` Heikki Krogerus
2025-06-18 19:00 ` Abhishek Pandit-Subedi
2025-06-16 13:31 ` [PATCH 05/10] usb: typec: Implement automated alternate mode selection Andrei Kuchynski
2025-06-16 13:31 ` [PATCH 06/10] Revert "usb: typec: displayport: Receive DP Status Update NAK request exit dp altmode" Andrei Kuchynski
2025-06-16 14:15 ` Greg Kroah-Hartman
2025-06-16 19:42 ` Andrei Kuchynski
2025-06-17 8:54 ` Heikki Krogerus
2025-06-17 12:54 ` Andrei Kuchynski
2025-06-16 13:31 ` Andrei Kuchynski [this message]
2025-06-16 13:31 ` [PATCH 08/10] usb: typec: ucsi: displayport: Propagate DP altmode entry result Andrei Kuchynski
2025-06-16 13:31 ` [PATCH 09/10] platform/chrome: cros_ec_typec: Propagate " Andrei Kuchynski
2025-06-16 13:31 ` [PATCH 10/10] platform/chrome: cros_ec_typec: Report USB4 mode entry status via callback Andrei Kuchynski
2025-06-16 13:34 ` [PATCH 00/10] USB Type-C mode selection Dmitry Baryshkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250616133147.1835939-8-akuchynski@chromium.org \
--to=akuchynski@chromium.org \
--cc=abhishekpandit@chromium.org \
--cc=badhri@google.com \
--cc=bleung@chromium.org \
--cc=chrome-platform@lists.linux.dev \
--cc=gregkh@linuxfoundation.org \
--cc=groeck@chromium.org \
--cc=heikki.krogerus@linux.intel.com \
--cc=jthies@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=lumag@kernel.org \
--cc=pooja.katiyar@intel.com \
--cc=rdbabiera@google.com \
--cc=tzungbi@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox