From: Pedro Nariyoshi <pedro.nariyoshi@gmail.com>
To: Hans Verkuil <hverkuil@xs4all.nl>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Benson Leung <bleung@chromium.org>,
Guenter Roeck <groeck@chromium.org>,
linux-media@vger.kernel.org, chrome-platform@lists.linux.dev,
linux-kernel@vger.kernel.org,
Mr Chromebox <mrchromebox@gmail.com>
Cc: Pedro Nariyoshi <pedro.nariyoshi@gmail.com>
Subject: [PATCH] media: cros-ec-cec: Add Fizz board variants, so driver can detect them
Date: Sat, 28 Jun 2025 14:14:35 -0400 [thread overview]
Message-ID: <20250628181530.873795-1-pedro.nariyoshi@gmail.com> (raw)
I recently reflashed a Chromebox (Wukong variant of the Fizz board) with
coreboot and I noticed that the cec driver refused to load with a bit of
tinkering, I realized that the dmi_match_table was expecting the product
name to be Fizz, but `dmidecode` reports `Wukong` as the product name. I
am not sure if this is the best approach, but adding this patch lets me
load the driver and it works properly.
Alternatively, we could instead match the DMI_PRODUCT_FAMILY, instead of
DMI_SYS_VENDOR and DMI_PRODUCT_NAME. In my board at least, that says
"Google_Fizz".
I am open to suggestions for alternative solutions and I hope I did't
break any rules (this is my first kernel patch). (And sorry for the
previous submissions with errors in the subject line)
Signed-off-by: Pedro Nariyoshi <pedro.nariyoshi@gmail.com>
---
drivers/media/cec/platform/cros-ec/cros-ec-cec.c | 9 ++++++++-
1 file changed, 8 insertions(+), 1 deletion(-)
diff --git a/drivers/media/cec/platform/cros-ec/cros-ec-cec.c b/drivers/media/cec/platform/cros-ec/cros-ec-cec.c
index 419b9a7abcce..a26473c3cd84 100644
--- a/drivers/media/cec/platform/cros-ec/cros-ec-cec.c
+++ b/drivers/media/cec/platform/cros-ec/cros-ec-cec.c
@@ -302,8 +302,15 @@ static const char *const port_ab_conns[] = { "Port A", "Port B", NULL };
static const char *const port_d_conns[] = { "Port D", NULL };
static const struct cec_dmi_match cec_dmi_match_table[] = {
- /* Google Fizz */
+ /* Google Fizz and variants*/
{ "Google", "Fizz", "0000:00:02.0", port_b_conns },
+ { "Google", "Bleemo", "0000:00:02.0", port_b_conns },
+ { "Google", "Excelsior", "0000:00:02.0", port_b_conns },
+ { "Google", "Jax", "0000:00:02.0", port_b_conns },
+ { "Google", "Kench", "0000:00:02.0", port_b_conns },
+ { "Google", "Sion", "0000:00:02.0", port_b_conns },
+ { "Google", "Teemo", "0000:00:02.0", port_b_conns },
+ { "Google", "Wukong", "0000:00:02.0", port_b_conns },
/* Google Brask */
{ "Google", "Brask", "0000:00:02.0", port_b_conns },
/* Google Moli */
--
2.49.0
next reply other threads:[~2025-06-28 18:15 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-28 18:14 Pedro Nariyoshi [this message]
2025-06-30 6:25 ` [PATCH] media: cros-ec-cec: Add Fizz board variants, so driver can detect them hans
[not found] ` <CAHPgyW5s8HB5op9z8cMPJPJ-9=e4Ufp6R3U3jABOxXD0Rzt06g@mail.gmail.com>
2025-06-30 13:13 ` Mr. Chromebox
2025-07-02 6:52 ` Tzung-Bi Shih
-- strict thread matches above, loose matches on Subject: below --
2025-06-26 18:03 [PATCH] media : " Pedro Nariyoshi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250628181530.873795-1-pedro.nariyoshi@gmail.com \
--to=pedro.nariyoshi@gmail.com \
--cc=bleung@chromium.org \
--cc=chrome-platform@lists.linux.dev \
--cc=groeck@chromium.org \
--cc=hverkuil@xs4all.nl \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=mrchromebox@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox