From: Greg KH <gregkh@linuxfoundation.org>
To: Tzung-Bi Shih <tzungbi@kernel.org>
Cc: bleung@chromium.org, dawidn@google.com, chrome-platform@lists.linux.dev
Subject: Re: [PATCH v3 5/8] platform/chrome: Introduce cros_ec_device_alloc()
Date: Mon, 21 Jul 2025 08:15:07 +0200 [thread overview]
Message-ID: <2025072114-unifier-screen-1594@gregkh> (raw)
In-Reply-To: <20250721044456.2736300-6-tzungbi@kernel.org>
On Mon, Jul 21, 2025 at 04:44:53AM +0000, Tzung-Bi Shih wrote:
> Prepare to decouple the lifecycle of struct cros_ec_device from specific
> device by introducing a kref.
Ick, are you sure? This is a device, so use struct device for it.
That's what it is there for.
So shouldn't this be its own 'struct device' and let the driver core
handle it correctly instead of trying to have a "child" structure with a
reference count that is not shown in sysfs at all?
thanks,
greg k-h
next prev parent reply other threads:[~2025-07-21 6:15 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-21 4:44 [PATCH v3 0/8] platform/chrome: cros_ec_chardev: Fix a possible UAF Tzung-Bi Shih
2025-07-21 4:44 ` [PATCH v3 1/8] platform/chrome: cros_ec_chardev: Remove redundant struct field Tzung-Bi Shih
2025-07-21 4:44 ` [PATCH v3 2/8] platform/chrome: cros_ec: Unregister notifier in cros_ec_unregister() Tzung-Bi Shih
2025-07-21 6:13 ` Greg KH
2025-07-21 9:30 ` Tzung-Bi Shih
2025-07-21 4:44 ` [PATCH v3 3/8] platform/chrome: cros_ec_chardev: Decouple fops from struct cros_ec_dev Tzung-Bi Shih
2025-07-21 4:44 ` [PATCH v3 4/8] platform/chrome: Disallow sending commands through unregistered ec_dev Tzung-Bi Shih
2025-07-21 5:47 ` Greg KH
2025-07-21 9:31 ` Tzung-Bi Shih
2025-07-21 10:23 ` Greg KH
2025-07-21 4:44 ` [PATCH v3 5/8] platform/chrome: Introduce cros_ec_device_alloc() Tzung-Bi Shih
2025-07-21 6:15 ` Greg KH [this message]
2025-07-24 9:58 ` Tzung-Bi Shih
2025-07-24 10:36 ` Greg KH
2025-07-24 13:32 ` Tzung-Bi Shih
2025-07-25 4:58 ` Greg KH
2025-08-01 7:25 ` Tzung-Bi Shih
2025-08-01 8:22 ` Greg KH
2025-08-01 8:41 ` Tzung-Bi Shih
2025-08-01 8:50 ` Greg KH
2025-08-14 9:24 ` Tzung-Bi Shih
2025-07-21 4:44 ` [PATCH v3 6/8] platform/chrome: Don't initialize common utilities when registering Tzung-Bi Shih
2025-07-21 4:44 ` [PATCH v3 7/8] platform/chrome: cros_ec_chardev: Hold refcount of struct cros_ec_device Tzung-Bi Shih
2025-07-21 4:44 ` [PATCH v3 8/8] platform/chrome: Manage struct cros_ec_device lifecycle by its refcount Tzung-Bi Shih
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2025072114-unifier-screen-1594@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=bleung@chromium.org \
--cc=chrome-platform@lists.linux.dev \
--cc=dawidn@google.com \
--cc=tzungbi@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).