Re: [PATCH v4 1/3] dt-bindings: chrome: Add cros-ec-ucsi compatibility to typec binding

Abhishek Pandit-Subedi
2025-11-06T18:21:43Z

On Thu, Nov 6, 2025 at 9:28 AM Benson Leung <bleung@google.com> wrote:
>
> Hi Jameson,
>
> On Mon, Oct 13, 2025 at 08:33:25PM +0000, Jameson Thies wrote:
> > Chrome OS devices with discrete power delivery controllers (PDCs) allow
> > the host to read port status and control port behavior through a USB
> > Type-C Connector System Software (UCSI) interface with the embedded
> > controller (EC). This uses a separate interface driver than other
> > Chrome OS devices with a Type-C port manager in the EC FW. Those use
> > a host command interface supported by cros-ec-typec. Add a cros-ec-ucsi
> > compatibility string to the existing cros-ec-typec binding.
> >
> > Additionally, update maintainer list to reflect cros-ec-ucsi and
> > cros-ec-typec driver maintainers.
> >
> > Signed-off-by: Jameson Thies <jthies@google.com>
> > Reviewed-by: Rob Herring (Arm) <robh@kernel.org>
>
> Reviewed-by: Benson Leung <bleung@chromium.org>
>
> > ---
> > .../bindings/chrome/google,cros-ec-typec.yaml | 19 +++++++++++++++----
> > 1 file changed, 15 insertions(+), 4 deletions(-)
> >
> > diff --git a/Documentation/devicetree/bindings/chrome/google,cros-ec-typec.yaml b/Documentation/devicetree/bindings/chrome/google,cros-ec-typec.yaml
> > index 9f9816fbecbc..fd1a459879bd 100644
> > --- a/Documentation/devicetree/bindings/chrome/google,cros-ec-typec.yaml
> > +++ b/Documentation/devicetree/bindings/chrome/google,cros-ec-typec.yaml
> > @@ -8,17 +8,28 @@ title: Google Chrome OS EC(Embedded Controller) Type C port driver.
> >
> > maintainers:
> > - Benson Leung <bleung@chromium.org>
> > - - Prashant Malani <pmalani@chromium.org>
> > + - Abhishek Pandit-Subedi <abhishekpandit@chromium.org>
> > + - Andrei Kuchynski <akuchynski@chromium.org>
> > + - Łukasz Bartosik <ukaszb@chromium.org>
> > + - Jameson Thies <jthies@google.com>
> >
> > description:
> > Chrome OS devices have an Embedded Controller(EC) which has access to
> > Type C port state. This node is intended to allow the host to read and
> > - control the Type C ports. The node for this device should be under a
> > - cros-ec node like google,cros-ec-spi.
> > + control the Type C ports. This binding is compatible with both the
> > + cros-ec-typec and cros-ec-ucsi drivers. The cros-ec-typec driver
> > + supports the host command interface used by the Chrome OS EC with a
> > + built-in Type-C port manager and external Type-C Port Controller
> > + (TCPC). The cros-ec-ucsi driver supports the USB Type-C Connector
> > + System Software (UCSI) interface used by the Chrome OS EC when the
> > + platform has a separate power delivery controller (PDC). The node for
> > + this device should be under a cros-ec node like google,cros-ec-spi.
> >
> > properties:
> > compatible:
> > - const: google,cros-ec-typec
> > + enum:
> > + - google,cros-ec-typec
> > + - google,cros-ec-ucsi
> >
> > '#address-cells':
> > const: 1
> > --
> > 2.51.0.858.gf9c4a03a3a-goog
> >

Reviewed-by: Abhishek Pandit-Subedi <abhishekpandit@chromium.org>