From: Gwendal Grignou <gwendal@chromium.org>
To: tzungbi@kernel.org
Cc: chrome-platform@lists.linux.dev, Gwendal Grignou <gwendal@google.com>
Subject: [PATCH] platform/chrome: lightbar: Optimize command size
Date: Tue, 3 Feb 2026 19:50:36 -0800 [thread overview]
Message-ID: <20260204035036.697955-1-gwendal@google.com> (raw)
Enabling tracing with:
echo 1 > /sys/kernel/debug/tracing/events/cros_ec/cros_ec_request_start/enable
To monitor the command and response size. The defaults are 194 and 128 respectively:
cros_ec_request_start: version: 0, offset: 0, command: EC_CMD_LIGHTBAR_CMD, outsize: 194, insize: 128
Reduce the sizes to the expected subcommands.
Signed-off-by: Gwendal Grignou <gwendal@google.com>
---
drivers/platform/chrome/cros_ec_lightbar.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/platform/chrome/cros_ec_lightbar.c b/drivers/platform/chrome/cros_ec_lightbar.c
index 2d1aa6edda1a..f69f2f6de276 100644
--- a/drivers/platform/chrome/cros_ec_lightbar.c
+++ b/drivers/platform/chrome/cros_ec_lightbar.c
@@ -461,6 +461,8 @@ static ssize_t sequence_store(struct device *dev, struct device_attribute *attr,
param = (struct ec_params_lightbar *)msg->data;
param->cmd = LIGHTBAR_CMD_SEQ;
param->seq.num = num;
+ msg->outsize = offsetof(typeof(*param), seq) + sizeof(param->seq);
+ msg->insize = 0;
ret = lb_throttle();
if (ret)
goto exit;
@@ -516,6 +518,7 @@ static ssize_t program_store(struct device *dev, struct device_attribute *attr,
if (ret)
goto exit;
param = (struct ec_params_lightbar *)msg->data;
+ msg->insize = 0;
if (lb_version < 3) {
dev_info(dev, "Copying %zu byte program to EC", count);
--
2.53.0.rc2.204.g2597b5adb4-goog
next reply other threads:[~2026-02-04 3:50 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-04 3:50 Gwendal Grignou [this message]
2026-02-23 7:43 ` [PATCH] platform/chrome: lightbar: Optimize command size Tzung-Bi Shih
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260204035036.697955-1-gwendal@google.com \
--to=gwendal@chromium.org \
--cc=chrome-platform@lists.linux.dev \
--cc=gwendal@google.com \
--cc=tzungbi@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox