Re: [PATCH v3 03/11] gpio: sysfs: Remove redundant check for struct gpio_chip

Tzung-Bi Shih
2026-02-23T06:18:03Z

On Fri, Feb 20, 2026 at 08:51:29AM +0100, Linus Walleij wrote:
> On Fri, Feb 13, 2026 at 10:31 AM Tzung-Bi Shih <tzungbi@kernel.org> wrote:
> > -void gpiochip_sysfs_unregister(struct gpio_device *gdev)
> > +void gpiochip_sysfs_unregister(struct gpio_chip *chip)
>
> Here it is chip
>
> > -static inline void gpiochip_sysfs_unregister(struct gpio_device *gdev)
> > +static inline void gpiochip_sysfs_unregister(struct gpio_chip *chip)
>
> And here.
>
> > @@ -1286,7 +1286,7 @@ void gpiochip_remove(struct gpio_chip *gc)
> > struct gpio_device *gdev = gc->gpiodev;
>
> But you can see that we call it "gc" (gpiochip).
>
> Chip is more ambiguous I think, can you use "gc" everywhere?

Ack, will fix in v4.