From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3794B34CFC2 for ; Mon, 23 Feb 2026 07:28:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771831688; cv=none; b=BU6kkX8ba56tgF5OwzvC3LrMJjxJL8KntkafehC0C2G1SpDZsSL32/G5ZqkNouo0263xBRYJeBSwNzONwyQOIUSDmInO93KNzPq87vi2qIxphVGfMk2+xqbVyaVK7x0crjB3qocnkZMaq/opr97c+fhwjhlgXWxdQEa0gPe8NKk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771831688; c=relaxed/simple; bh=Tz7aCKZpxvE/URE9NHfPfJCIW6o+Wox+HN1jMO8zCgg=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=Qb74g32z3ziOLljKi6vB61Fidb3zQJh5Ylcw8jYFQFIHnVeuUfH2an7OTSxNyO2CykU8XHJqa2OEqKAnhBO/Aam1P2VQCwUu/cirKV2DHB4/s0iUPgBMqisdQSmIPwkk//YgD5jq0TqNihW4wneX4mc+9aXHYNVPbvlqUtx50lw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=bqdUhSGg; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=HCzdwMRX; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="bqdUhSGg"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="HCzdwMRX" Received: from pps.filterd (m0279865.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 61MHi1cV1883531 for ; Mon, 23 Feb 2026 07:28:03 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= V13TbOnjuV6VzvANE56HZysaUseqHKiXk3Stv9fSSv0=; b=bqdUhSGg4fNXC5Tt lBynV7L5CjuSOXJESYwWx3vFyqDGDls7Zwtx7n9sISNSuMJzh7UN16lJ1w6hz4s5 2bThB4m0OzgpMqh7TiUxcmBjPWZOLk2wkaBSYBw5RNRm93k55D3BIgWqvIon0MIr ZbghUmGcXmjMY7v7Kc5oWG0gRwQRAJCmhK7yj8iTuw2EEiwBhm5GLL1E8ryEqvwp tJnt0AEfpr8xKWCvvxkvKVaIBiHl9KFAnKVTR+vOCizkWpraNxR7J5XHJNG3dOX9 mEG5mvwhpWDUHVP9s6z26/akucfbtWNRM1FpY2dp8NShJqDdJljAs+CiJj/M7ACH VitS8g== Received: from mail-qk1-f197.google.com (mail-qk1-f197.google.com [209.85.222.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4cf5wyurwq-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 23 Feb 2026 07:28:03 +0000 (GMT) Received: by mail-qk1-f197.google.com with SMTP id af79cd13be357-8cb3b6b37d8so3730446485a.3 for ; Sun, 22 Feb 2026 23:28:03 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1771831682; x=1772436482; darn=lists.linux.dev; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=V13TbOnjuV6VzvANE56HZysaUseqHKiXk3Stv9fSSv0=; b=HCzdwMRXFXOUs1v265SoClcI6N43b5TiscAp5KiFko6Uv9YUnw7r0+VV6qIpaSU6wM HYSHoYR6n2xnjqv44ip0KwAkUhHzuHdJlvwfsZaMTMqAFh/fTghIqO4fxY03W49Ls+8H 821aoYJHXrtEMy3575pyzaSNLbJz5j5yvoKW+CV4odpSHybOnUDec1cqtdZw/nyN/eER FGzAjsPFJHerLXmk0u8kZJqhrZQ9cHAsGut3nVdyVkoXsTf3DP0hsWVy9qE+lN0ELRmZ 2rkHeqNmFeJ1Ignx47bnJ7vDFy2JdErWLp09ueHuTqG0LhvdyBGNUqpUc62KAny7pdpJ RudA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1771831682; x=1772436482; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=V13TbOnjuV6VzvANE56HZysaUseqHKiXk3Stv9fSSv0=; b=FcPOxgViJgd0c3D2eoMo1sxcbQBDRCHjGE/i9JCYK7UMGRqK/0WAH9H8YW2umM6oWO zwa5NjKkDWcVq7eKN2VITEr7Hais+2qNA3hqkacw0u8XGh2NXhpHTMsn2ho8dEVHOvMH Rm0Fn1ED7v3ZlVxVqXTE9zlRDrds6Fk9AC2NNnX9K3OeXL1SR1euX01dMH2JyKlE6en9 VE3btU3Vvh5Hl4TY3XDpnhf45LbrWYCxJsCSynP1hXctt41eX++fAvCl48qbOCPOQld7 zSvOwgfcp+N5T8MvTTQMW67KAIeTlVW5RkWLNey33yHlFwnqSOYR9unogUMQnkDAPEKh NTVQ== X-Forwarded-Encrypted: i=1; AJvYcCUoQQB+zMlaVRUMi6wixd/ZvQO5zCkhjy8+ztEEYQBncj8MNlfZ1pRgvRp9gGla43fR2/DVJD1c/2r5M3lO3X8=@lists.linux.dev X-Gm-Message-State: AOJu0YzveytZrF5cy+ct7xSRamqHSkCcnYOCTf5mHL5ak0iRCVN+bCzt hV/mSRusrYOKfm0T6n5ipngzMkKMUdKGGEHUpfm+8OZ0zkdhNfDs1+6fU2LPJ+uh7a8m8zaWPr4 Z7eeu4K4DUwemMSrwkki7m78iWEJIq64hGZKretf5IKEb3SSBnExiM1VhzWBcLwjeCgVw2us= X-Gm-Gg: AZuq6aLWIaFR+8zio4HKfEGkspZCLQXClErWyWB+pK3hZGAb9/0QuFWE79Nm8OgEZaV /Yj9rC9oeMUag42jRwoO6rFzaZxuuIrfky4Jn3emL1Ld/7lj15uUhSYzK8HjI8kwcmWSImDBOmG k3Qq58tW6kn8ssHNTusdkp01hT7KkO5N2DfQ7EJ1r51aCHT6Pded0OtdWLPq7u/hI4uyjv1tXz4 lldnV/NREYtb7vkazW7pT7QiqUv5tvhM/SeH1Ou6NrwXx3FqvSrK/9ir3ldRNabbKL+NJKuYUsn T/Pd522IBCEf+737Sn8ciMvNGr/aih9Qi7GPz3cE8Ej8Ee/r6QzH6owTu/cqwoWGZfvnw7r8W59 ui46AjarsTM47pIzkHyrRbQgdfZx8TCjZSbtiPDJfbou8ew== X-Received: by 2002:a05:620a:414d:b0:8ca:3c67:8914 with SMTP id af79cd13be357-8cb8ca92dbdmr1030170385a.72.1771831682486; Sun, 22 Feb 2026 23:28:02 -0800 (PST) X-Received: by 2002:a05:620a:414d:b0:8ca:3c67:8914 with SMTP id af79cd13be357-8cb8ca92dbdmr1030168285a.72.1771831682019; Sun, 22 Feb 2026 23:28:02 -0800 (PST) Received: from [127.0.1.1] ([178.197.223.140]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-43970bf9ff5sm18550286f8f.4.2026.02.22.23.28.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 22 Feb 2026 23:28:01 -0800 (PST) From: Krzysztof Kozlowski Date: Mon, 23 Feb 2026 08:27:37 +0100 Subject: [PATCH 9/9] platform/chrome: cros_usbpd_logger: Simplify with devm Precedence: bulk X-Mailing-List: chrome-platform@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20260223-workqueue-devm-v1-9-10b3a6087586@oss.qualcomm.com> References: <20260223-workqueue-devm-v1-0-10b3a6087586@oss.qualcomm.com> In-Reply-To: <20260223-workqueue-devm-v1-0-10b3a6087586@oss.qualcomm.com> To: Greg Kroah-Hartman , "Rafael J. Wysocki" , Danilo Krummrich , Jonathan Corbet , Shuah Khan , Tejun Heo , Lai Jiangshan , Tobias Schrammm , Sebastian Reichel , Andy Shevchenko , Dan Carpenter , Krzysztof Kozlowski , Lee Jones , Dzmitry Sankouski , Matthias Brugger , AngeloGioacchino Del Regno , Benson Leung , Tzung-Bi Shih Cc: driver-core@lists.linux.dev, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, Sebastian Reichel , linux-pm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, chrome-platform@lists.linux.dev, Krzysztof Kozlowski X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=openpgp-sha256; l=2369; i=krzysztof.kozlowski@oss.qualcomm.com; h=from:subject:message-id; bh=Tz7aCKZpxvE/URE9NHfPfJCIW6o+Wox+HN1jMO8zCgg=; b=owEBbQKS/ZANAwAKAcE3ZuaGi4PXAcsmYgBpnAFu3KNp+CTKSy+V7k67mEChB+6tEknfgjT/Q 0+9orefkKyJAjMEAAEKAB0WIQTd0mIoPREbIztuuKjBN2bmhouD1wUCaZwBbgAKCRDBN2bmhouD 1wuWD/9J+JqARU6TsvU4zvVDheM7Vy4GbVVCDxKaqTn1LB64+jTh7G+qQDyEO+/8tfwnovEz32a dZfCA3g8kmt9XMucw0VfKlsZIX+GwOFNPaCzVAIUDxeJAZLU7RU0qIm5Sr9Tfvg2BRzyeDraYlT J7liSpFkaTD39Xe9e+ncf8BMH+iTwVSEDGmzCDAoM8binwflLgSFhX8+1BAAD+6dGF7I8S5Jd9F f+Yfs6XweClFjvk/QYcBtkxFZgTpt1p4s/Ksnk40iJqDUWV9nT7P4LCPGIedS+T3FPn0QWCatUy WQrnAzUWqundJe80uxqAF47q1sVAqylM2iuodrq7bUXWaR8M1DHKMOsQK60jEyt+n0BrWTqTC4X 0OvX08AJfnLsjhGl7MXfKjH+t/A+dPPQeqxzDF//csXt0QJqWoJNq9HCMfDdAkCxvlSeo4H9Z+z cYCbIcdRo8JQNn5a6H/48X2v7YhZV8tkKw2OTs2JmW54h38R8qRm/EVPRfMRk0VxUtTcZIuj/Vm qUIhXscFFPVRJCkWfps7q1UEqNoWwk6x+NdWrH7EYppRe0NRgJ7xIAgldkle635fxHyB2C0sUgo yylFHJPeufQjL0tRBOlpP0gjwNExCI+B70e1ZlGbs4mOM7RJCdTfEZLGq4326lxqaEVTZZ5aRHq kW1pfV1AjFgY8vg== X-Developer-Key: i=krzysztof.kozlowski@oss.qualcomm.com; a=openpgp; fpr=9BD07E0E0C51F8D59677B7541B93437D3B41629B X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMjIzMDA2NCBTYWx0ZWRfX5sb8hgM8RqDz KXgWytxRJsm5yTLOaCLyZvfE1u/JfjFsjmABXctJO1SGTwfBmgNJgSV1WasAocBJcsCKItuu74T zPuDSzqsRYfRAZ0hfN/Aglbs8/dqhSkVK1U+zv+QsToYjFghxAZ4pkMwFo1obc7XumQCKDnRTEe 1fgWyBRuPIux2iS9LCfpbluovRjTTL+BUbPgrTjigWZ7osW9fdJYWamHxOcNaL03S7ZTpDGNEFC 741DwSavZH/hzu8k+atzsRAAOQZsVejtas/RbkzxTQy2XbbnzvmKXIQ9YJQpALwFQRNG0EQjqUo U4FV7RfJaoGfCkz/nz5lk/k7aWA7Gu3gcdZ24hmye3HVWRa99wf/yi86vyxSTBw9auwVMvYw71T 6GNuO++GDNHXhE2jSbBar7Lb+fIcdAdqXMJZHwdODMgV0HEceJv/2yTC3NIsCWhm8EBjmAx5rly vWPap6xYctBQeGxOSyw== X-Authority-Analysis: v=2.4 cv=UO/Q3Sfy c=1 sm=1 tr=0 ts=699c0183 cx=c_pps a=50t2pK5VMbmlHzFWWp8p/g==:117 a=6nO30s3o7FuWeffXwhKHTA==:17 a=IkcTkHD0fZMA:10 a=HzLeVaNsDn8A:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=Um2Pa8k9VHT-vaBCBUpS:22 a=EUspDBNiAAAA:8 a=fg_Lw6XCFRazdZfdaoQA:9 a=QEXdDO2ut3YA:10 a=IoWCM6iH3mJn3m4BftBB:22 X-Proofpoint-GUID: lyDb2k_SN6cuLBbyPbOQVkQnV-Np91q5 X-Proofpoint-ORIG-GUID: lyDb2k_SN6cuLBbyPbOQVkQnV-Np91q5 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-02-23_01,2026-02-20_04,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 suspectscore=0 spamscore=0 lowpriorityscore=0 adultscore=0 impostorscore=0 malwarescore=0 priorityscore=1501 bulkscore=0 phishscore=0 clxscore=1015 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2602130000 definitions=main-2602230064 Simplify the driver by using devm interfaces, which allow to drop probe() error paths and the remove() callback. Signed-off-by: Krzysztof Kozlowski --- drivers/platform/chrome/cros_usbpd_logger.c | 18 +++++++----------- 1 file changed, 7 insertions(+), 11 deletions(-) diff --git a/drivers/platform/chrome/cros_usbpd_logger.c b/drivers/platform/chrome/cros_usbpd_logger.c index 7ce75e2e039e..b0d176c0f4cc 100644 --- a/drivers/platform/chrome/cros_usbpd_logger.c +++ b/drivers/platform/chrome/cros_usbpd_logger.c @@ -5,6 +5,7 @@ * Copyright 2018 Google LLC. */ +#include #include #include #include @@ -199,6 +200,7 @@ static int cros_usbpd_logger_probe(struct platform_device *pd) struct cros_ec_dev *ec_dev = dev_get_drvdata(pd->dev.parent); struct device *dev = &pd->dev; struct logger_data *logger; + int ret; logger = devm_kzalloc(dev, sizeof(*logger), GFP_KERNEL); if (!logger) @@ -210,25 +212,20 @@ static int cros_usbpd_logger_probe(struct platform_device *pd) platform_set_drvdata(pd, logger); /* Retrieve PD event logs periodically */ - INIT_DELAYED_WORK(&logger->log_work, cros_usbpd_log_check); - logger->log_workqueue = create_singlethread_workqueue("cros_usbpd_log"); + logger->log_workqueue = devm_create_singlethread_workqueue(dev, "cros_usbpd_log"); if (!logger->log_workqueue) return -ENOMEM; + ret = devm_delayed_work_autocancel(dev, &logger->log_work, cros_usbpd_log_check); + if (ret) + return ret; + queue_delayed_work(logger->log_workqueue, &logger->log_work, CROS_USBPD_LOG_UPDATE_DELAY); return 0; } -static void cros_usbpd_logger_remove(struct platform_device *pd) -{ - struct logger_data *logger = platform_get_drvdata(pd); - - cancel_delayed_work_sync(&logger->log_work); - destroy_workqueue(logger->log_workqueue); -} - static int __maybe_unused cros_usbpd_logger_resume(struct device *dev) { struct logger_data *logger = dev_get_drvdata(dev); @@ -263,7 +260,6 @@ static struct platform_driver cros_usbpd_logger_driver = { .pm = &cros_usbpd_logger_pm_ops, }, .probe = cros_usbpd_logger_probe, - .remove = cros_usbpd_logger_remove, .id_table = cros_usbpd_logger_id, }; -- 2.51.0