From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtpout-04.galae.net (smtpout-04.galae.net [185.171.202.116]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A1812478875 for ; Wed, 3 Jun 2026 12:12:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.171.202.116 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780488751; cv=none; b=BY7dRZ0dRZCkOTDoI2phhnQrqixNuoAqk8qjYXOjAmF25L6XY0pjuTLLaECgu5cELXv2/7YI9nEKwvKzJQkKqLpkWoJaJJoqKqch7ItJBBj9RxOgVPa9R8p2o/S5vNEFT54B5R7G9p6eXHfw/jui1ADn8WIm8yoDPGSAqv+BSxo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780488751; c=relaxed/simple; bh=d3EykXjPdTOzofqzcPyCOaTQ0ATiB33JeyMELyx3OOM=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=fZSLXiLP5VCE1TuBKvtSbDFNk2QKzyAAixmx4s2dVko77z/njNpyLxZ08yByhFyKtyK0aIttg0NM2Tm0+OIfNJIvg+XcdQ/D/9S0+Wwa4VlG9EeMGViThLGHu0Db1WDyBL4KjySzIjVH0k1A/hsIZQ1dQldZ4L4vp+HCm7DJrOY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com; spf=pass smtp.mailfrom=bootlin.com; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b=WqS1SiX8; arc=none smtp.client-ip=185.171.202.116 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=bootlin.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b="WqS1SiX8" Received: from smtpout-01.galae.net (smtpout-01.galae.net [212.83.139.233]) by smtpout-04.galae.net (Postfix) with ESMTPS id BE76BC63440; Wed, 3 Jun 2026 12:12:26 +0000 (UTC) Received: from mail.galae.net (mail.galae.net [212.83.136.155]) by smtpout-01.galae.net (Postfix) with ESMTPS id DFA0C6073E; Wed, 3 Jun 2026 12:12:27 +0000 (UTC) Received: from [127.0.0.1] (localhost [127.0.0.1]) by localhost (Mailerdaemon) with ESMTPSA id 48FB510888413; Wed, 3 Jun 2026 14:11:48 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=dkim; t=1780488742; h=from:subject:date:message-id:to:cc:mime-version:content-type: content-transfer-encoding:in-reply-to:references; bh=48ypl4N/Z9PEOrZi5s882vnkw+L0W6ufixnULaCX8wY=; b=WqS1SiX8JxgfCWjKbfGrN6L6Q3QYEVKtX9eatJz9iVzPqdb59EF2wfORgl6E1oiCCYOL6h 61ETQH6hQR3Buc4PxFXV8xJT2J5xNuIRWeEXwCZRhaxs5XLVqNUthCgehn5gJAgDWr5D+V EDn8WSCnJ0fr/3eDUJx++tiwrZ5WSI35nVYVUdYn3doe/iUdJ7p9DoQU59Ef1MvT6hoBjc 7jEjYscg5qvEtTKsFwWeeKNcZMVVM6zgOvZnXTK6b1ZDBo1eLL0VN631t+RjK9av9NXAVA YYmM055EJj11NnypQXGQ/iJgKGei6RU0g5MfNttmfc+5/XNEQ2JJEvOyMVoU4Q== Date: Wed, 3 Jun 2026 14:11:47 +0200 From: Herve Codina To: Kuninori Morimoto Cc: "Alvin =?UTF-8?B?xaBpcHJhZ2E=?=" , "J.M.B. Downing" , "Martin =?UTF-8?B?UG92acWhZXI=?=" , "Nuno =?UTF-8?B?U8Oh?=" , "Uwe =?UTF-8?B?S2xlaW5lLUvDtm5pZw==?= (The Capable Hub)" , Alexandre Belloni , Alexandre Torgue , AngeloGioacchino Del Regno , Arnaud Pouliquen , Baojun Xu , Bartosz Golaszewski , Ben Bright , Benson Leung , Biju Das , Binbin Zhou , Bram Vlerick , Charles Keepax , Chen-Yu Tsai , Cheng-Yi Chiang , Claudiu Beznea , Cristian Ciocaltea , Daniel Mack , Dario Binacchi , David Rhodes , Fabio Estevam , Florian Fainelli , Frank Li , Fred Treven , Geert Uytterhoeven , Guenter Roeck , Guoqing Jiang , Haojian Zhuang , HariKrishna Sagala , Heiko Stuebner , Hsieh Hung-En , James Ogletree , Jarkko Nikula , Jaroslav Kysela , Jernej Skrabec , Jerome Brunet , Jihed Chaibi , Jonathan Hunter , Kevin Cernekee , Kevin Hilman , Kevin Lu , Kirill Marinushkin , Kiseok Jo , Krzysztof Kozlowski , Kunihiko Hayashi , Lad Prabhakar , Lars-Peter Clausen , Liam Girdwood , Luca Ceresoli , M R Swami Reddy , Mark Brown , Martin Blumenstingl , Masami Hiramatsu , Matthias Brugger , Max Filippov , Maxime Coquelin , Neil Armstrong , Nicolas Ferre , Nicolas Frattaroli , Nicolin Chen , Oder Chiou , Olivier Moysan , Paul Cercueil , Peter Rosin , Piotr Wojtaszczyk , Qianfeng Rong , Ray Jui , Richard Fitzgerald , Robert Jarzmik , Samuel Holland , Sascha Hauer , Scott Branden , Sen Wang , Sharique Mohammad , Shenghao Ding , Shengjiu Wang , Steven Eckhoff , Support Opensource , Sylwester Nawrocki , Takashi Iwai , Thierry Reding , Tim Bird , Troy Mitchell , Tzung-Bi Shih , Venkata Prasad Potturu , Vijendar Mukunda , Vishwas A Deshpande , Vladimir Zapolskiy , Xiubo Li , Yixun Lan , Zhang Yi , chrome-platform@lists.linux.dev, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-mips@vger.kernel.org, linux-renesas-soc@vger.kernel.org, linux-riscv@lists.infradead.org, linux-sound@vger.kernel.org, spacemit@lists.linux.dev Subject: Re: [PATCH 03/83] ASoC: codecs: idt821034: don't use array if single pattarn Message-ID: <20260603141147.61943cf0@bootlin.com> In-Reply-To: <87y0h7hqxo.wl-kuninori.morimoto.gx@renesas.com> References: <8733zfj5jj.wl-kuninori.morimoto.gx@renesas.com> <87y0h7hqxo.wl-kuninori.morimoto.gx@renesas.com> Organization: Bootlin X-Mailer: Claws Mail 4.4.0 (GTK 3.24.52; x86_64-redhat-linux-gnu) Precedence: bulk X-Mailing-List: chrome-platform@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Last-TLS-Session-Version: TLSv1.3 Hi Kuninori, On Tue, 26 May 2026 01:58:59 +0000 Kuninori Morimoto wrote: > Because it is confusable during debugging ASoC FW update, tidyup > auto format style not to use array if single pattern case. > > Signed-off-by: Kuninori Morimoto > --- > sound/soc/codecs/idt821034.c | 9 ++++----- > 1 file changed, 4 insertions(+), 5 deletions(-) > > diff --git a/sound/soc/codecs/idt821034.c b/sound/soc/codecs/idt821034.c > index 39bafefa6a186..084090ccef77a 100644 > --- a/sound/soc/codecs/idt821034.c > +++ b/sound/soc/codecs/idt821034.c > @@ -860,18 +860,17 @@ static int idt821034_dai_startup(struct snd_pcm_substream *substream, > return 0; > } > > -static const u64 idt821034_dai_formats[] = { > +static const u64 idt821034_dai_formats = > SND_SOC_POSSIBLE_DAIFMT_DSP_A | > - SND_SOC_POSSIBLE_DAIFMT_DSP_B, > -}; > + SND_SOC_POSSIBLE_DAIFMT_DSP_B; > > static const struct snd_soc_dai_ops idt821034_dai_ops = { > .startup = idt821034_dai_startup, > .hw_params = idt821034_dai_hw_params, > .set_tdm_slot = idt821034_dai_set_tdm_slot, > .set_fmt = idt821034_dai_set_fmt, > - .auto_selectable_formats = idt821034_dai_formats, > - .num_auto_selectable_formats = ARRAY_SIZE(idt821034_dai_formats), > + .auto_selectable_formats = &idt821034_dai_formats, > + .num_auto_selectable_formats = 1, > }; > > static struct snd_soc_dai_driver idt821034_dai_driver = { Same typo in the commit title as in patch 2: s/pattarn/pattern/ Or even s/pattarn/item/ With that fixed, Reviewed-by: Herve Codina Best regards, Hervé