From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-dy1-f178.google.com (mail-dy1-f178.google.com [74.125.82.178]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F2FDF495531 for ; Wed, 17 Jun 2026 10:41:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.82.178 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781692867; cv=none; b=n4hHp6IvTAETO5NpvAT4bjbI5G+yeXq9nqgeoC7hqYcR/4dq/CFnp5+tVZcPN3HKTeCAEFs2clT4RVBzq1TKbzqD2PNdSUeOHcV97Z960eesmBmgIxWj2E0noLYNhpNB519zuX8cRNXC8b9O9QrTBZ2a/GZOhOgsa/I388LZeHg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781692867; c=relaxed/simple; bh=T5inPM0/ZembfY2Nrx+5l3rT9jXABsUVzUit1sml7qs=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=BdZ4jTUapwwRVP4Is2dia+fiIOch39bW6T+O7rEmTvbWaY3fjgNpvq+hH2PzCGliVHr0jtuZaU0BFXgtfTrEv2p0FJkEA905uvo9lI40yxiysLbVOjDPlw/xdmvVZHTPJgRXmcW7grJ7t4WSfvgUv97TSLrCp5+ptFgwjTvUjJE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=gQTCqZI3; arc=none smtp.client-ip=74.125.82.178 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="gQTCqZI3" Received: by mail-dy1-f178.google.com with SMTP id 5a478bee46e88-307d0405e07so8462795eec.1 for ; Wed, 17 Jun 2026 03:41:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1781692865; x=1782297665; darn=lists.linux.dev; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=djEuHymjWJS5SFW/o8P0inIono61ptYNHJ11jX9l3Ik=; b=gQTCqZI37FngjWe9YuZT0kkp4Z/nqek2MkdwMp//WQ4TA5jXGu/3XsvXHW1gAN/k2x 7Yo+hFB5dMFqwpvdZxuz9jyqtuFyePkEROXtm2YR6E92K7JoP1ycST13tGxVkD6A6Lrx BXlYc+g9X7dFTm6T0qBAsR4IIWdBEHAJFrMBXG2P27tj2D/icgHMKN7H+EqyJfur9ghE /JkF2xEIoE1cSItequM+CCrg87+3BxWQZz6GWcf4lsXIbs8QI60DtYQhnbT6BCo6b2xl c7u5A3bXkaxfwENHxxhwyEV6xIsMqQZ7Rn5xPUUx9ePOPcySq1Z3Ngo3FxyLU26mjE6L j60Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1781692865; x=1782297665; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=djEuHymjWJS5SFW/o8P0inIono61ptYNHJ11jX9l3Ik=; b=UE1UX5ji03F4A9i47jnMPAgHQsFNxrecB3775IbXF/CAy+a+Zi9XLJW8mH2XkkyjHW PAXNgqONi6q5zTo38p78tV7N6l1iPj6bCgTduEIAUjCiEiio21nuwFGnGMJnGlKFATIc MZ4x7Xhuk5GHVDcVMevz7ppP7SOPZcMoDjK+QocdIYfmUaRt2YiNSMRjdbWcMri6vgo4 7f5vznINIv97i+MvWIpkOKg+slUo06YMFmqbvTNqLTY+56Jp486CWsdwEJNJ7xa1c09H aLAnGZ8gP8gCn2j7nM9s/grEFS4S1E7IV5WWhEu/MEgIuIMCihtDPYWVMZNQ7uMDTWAp 5Ddg== X-Forwarded-Encrypted: i=1; AFNElJ8bHZpEN5QyYHL3viFLbt78fhXrYlQtU3V6B4XA6ZAmfarVt6KatYDRN7+kq93QtpKKdQrm+2rlI/vAx2vqLZQ=@lists.linux.dev X-Gm-Message-State: AOJu0YznLYlm82T8Qo/bmZU6mTnKW6xU5qOgPXYNaksdEndRAZUZa/cF 7K2E34CzzeeVV52+a+PlE/tx+2pC3ONis4NcY9qb7AQNysst6p/ndOiG X-Gm-Gg: AfdE7cmbseW7oj1lFg9cGTFzT0NbvZwUiYe0KF3meHpPBg2RQcl/f6a/A75LYSUeFZw nZesQ+SqwXtYP9X4RHWzw3spfP+8ZFYfY6TzPQGQNEwCi0b7tsbOjFQN0B1nYyMw99ydqHMBTBH NsmT4XTbNq7/7xE24FZyRci8sJnxhWkFdbCNv/w8ilZW2JU0hhYzO/yJ7dWrywvW4lDybxlyVcL Jh5YvkdLjg7WjAk4GmnWPvr9QW/NwbInXDb3Tcg3om5D/XgXCS4fsQplCn2tbY/yl89DVU7moBd KXzaQPr7mI7AK8SeQKuC4DmaghRsL/Ltg2/d++78TTix+FIJPQGlNYoJmRE2hu1ybnb/q9j2YkS UaWuzGSiwhK6NiZYIzuSr0XT9y7BmZwm1JYrDBtb2c3aw6ckwUPgUQxOoqxh0rwCXRygoiSwd7o JS3AGshXf0eydfywOsuzd5CSk9YMKFkSrN/ee0PpnaVfvzDCs9/KWSaUdGDg== X-Received: by 2002:a05:7300:30c8:b0:30a:e52d:fb27 with SMTP id 5a478bee46e88-30bc9df5a44mr2016767eec.11.1781692865129; Wed, 17 Jun 2026 03:41:05 -0700 (PDT) Received: from phuc-desktop.. ([183.91.15.56]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-3081e5d0828sm24616275eec.10.2026.06.17.03.40.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 17 Jun 2026 03:41:04 -0700 (PDT) From: phucduc.bui@gmail.com To: Mark Brown Cc: Liam Girdwood , Jaroslav Kysela , Takashi Iwai , Cheng-Yi Chiang , Tzung-Bi Shih , Guenter Roeck , Benson Leung , David Rhodes , Richard Fitzgerald , povik+lin@cutebit.org, Charles Keepax , Support Opensource , Nick Li , Herve Codina , Srinivas Kandagatla , Matthias Brugger , AngeloGioacchino Del Regno , Shenghao Ding , Kevin Lu , Baojun Xu , Sen Wang , Oder Chiou , Lars-Peter Clausen , nuno.sa@analog.com, Steven Eckhoff , patches@opensource.cirrus.com, chrome-platform@lists.linux.dev, asahi@lists.linux.dev, linux-arm-msm@vger.kernel.org, linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, bui duc phuc Subject: [PATCH 52/78] ASoC: codecs: sigmadsp: Use guard() for mutex locks Date: Wed, 17 Jun 2026 17:32:09 +0700 Message-ID: <20260617103235.449609-53-phucduc.bui@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260617103235.449609-1-phucduc.bui@gmail.com> References: <20260617103235.449609-1-phucduc.bui@gmail.com> Precedence: bulk X-Mailing-List: chrome-platform@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: bui duc phuc Clean up the code using guard() for mutex locks. Merely code refactoring, and no behavior change. Signed-off-by: bui duc phuc --- sound/soc/codecs/sigmadsp.c | 16 ++++++---------- 1 file changed, 6 insertions(+), 10 deletions(-) diff --git a/sound/soc/codecs/sigmadsp.c b/sound/soc/codecs/sigmadsp.c index 2e08fde3989c..592aba25de11 100644 --- a/sound/soc/codecs/sigmadsp.c +++ b/sound/soc/codecs/sigmadsp.c @@ -135,7 +135,7 @@ static int sigmadsp_ctrl_put(struct snd_kcontrol *kcontrol, uint8_t *data; int ret = 0; - mutex_lock(&sigmadsp->lock); + guard(mutex)(&sigmadsp->lock); data = ucontrol->value.bytes.data; @@ -148,8 +148,6 @@ static int sigmadsp_ctrl_put(struct snd_kcontrol *kcontrol, ctrl->cached = true; } - mutex_unlock(&sigmadsp->lock); - return ret; } @@ -160,7 +158,7 @@ static int sigmadsp_ctrl_get(struct snd_kcontrol *kcontrol, struct sigmadsp *sigmadsp = snd_kcontrol_chip(kcontrol); int ret = 0; - mutex_lock(&sigmadsp->lock); + guard(mutex)(&sigmadsp->lock); if (!ctrl->cached) { ret = sigmadsp_read(sigmadsp, ctrl->addr, ctrl->cache, @@ -174,8 +172,6 @@ static int sigmadsp_ctrl_get(struct snd_kcontrol *kcontrol, ctrl->num_bytes); } - mutex_unlock(&sigmadsp->lock); - return ret; } @@ -677,10 +673,10 @@ static void sigmadsp_activate_ctrl(struct sigmadsp *sigmadsp, return; changed = snd_ctl_activate_id(card, &ctrl->kcontrol->id, active); if (active && changed > 0) { - mutex_lock(&sigmadsp->lock); - if (ctrl->cached) - sigmadsp_ctrl_write(sigmadsp, ctrl, ctrl->cache); - mutex_unlock(&sigmadsp->lock); + scoped_guard(mutex, &sigmadsp->lock) { + if (ctrl->cached) + sigmadsp_ctrl_write(sigmadsp, ctrl, ctrl->cache); + } } } -- 2.43.0