From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-dy1-f180.google.com (mail-dy1-f180.google.com [74.125.82.180]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B2C473F786A for ; Wed, 17 Jun 2026 10:34:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.82.180 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781692448; cv=none; b=sjmduNPcfWAre0E6jd1JlOZtOSggLQ9CIgrFadO8bpTSZi9xSp5teuNMp8taejpADsxEN0/xZvSSJ+mV9kbqpRMuwtAoFRL4xdXQ2xCMQlVfeNmHl0pyViBb6H1HHgyke+JcVZOTkk7mXbA4X+rZcBki+Z6woGSyu2hgZuUlwsA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781692448; c=relaxed/simple; bh=0VKFkNlEKDw288PdSdXQHhZ6q0aNgLP3kbBRSkQ53io=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=YWJLxFrlSOzGDK34F7K39hsaiAQnByNRKF8HYoPlA2u8FzkyVW+8wCIHwVKVPEYGmueVL+lf36g/irGiB5PXgsnSht3BU8Po0w3OcMPjav7FPae8vlF0vUZLqRD0htXtDJL2oy0YReqqZwWcK5paWH6WD9Ay5U99kS/LfCsJbLM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=dtYfIclK; arc=none smtp.client-ip=74.125.82.180 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="dtYfIclK" Received: by mail-dy1-f180.google.com with SMTP id 5a478bee46e88-30bd7f4fdffso367162eec.1 for ; Wed, 17 Jun 2026 03:34:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1781692445; x=1782297245; darn=lists.linux.dev; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=yrGTC5BuLCcleWlyDxhfzmeV1rXl6zWQpWVZTTauIJk=; b=dtYfIclKegyMzFXU2iBnCRROCkrGpVgZc9ct5ZE7J63tfAQvJQTwqrsVvN6v51ElPV 0VHCYcMXiESkCvTu8IRw5/3tkbhbskzLn55u7RCQU8B3ys6vLgE3rBvXY5EJlP+3ad7o dVXX5QwgUeVA0mCWV8m/8IEyUA/Um326QXwdfppHL+KhWQkhUgvHLj3wKwIOlKfVJt7A 8rkVN1atdkEyBGHYDAvuVJhWUDsmoIOemdL+x35IIdkqI7sbesgx/fe6RybEDof/jU1k iw/esssibn+PVRsSSMNZWfnEhb3UxRqkW56b58n9eNVS/ogPd7HU/oycmya9PSRQhW+Z HCvQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1781692445; x=1782297245; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=yrGTC5BuLCcleWlyDxhfzmeV1rXl6zWQpWVZTTauIJk=; b=pPCH02px5m1T8HBoTWxjk9F50yY9tHAeFSoySF5r83Ipzy7UcrJvjKPUietBQ8cRWe Eo8OnNswD9OlCri/0xyaqVu5tebNdgXiDlOmFENmfw8nGTCPoNtCvzMnYjQmsfq+gfCu yQ33kwyaQ2w5/3bmSfSrrVSLLTkr9aYlpluEskIFLU40W7qxvhn04MFS02lJ8qnmWhzI a4hKFju/J+7e9y5IAeI61W8401wE5oF2Jz+hgs1uLP/CN2tOOtHgXD+8m4OvTB+V339L roQR1KE2FsQelYAa/R0p1Xokg1c/nbdqU25uyUZjknLP4LUF1Ez3dGkCtJGsFqNy7zqm At0Q== X-Forwarded-Encrypted: i=1; AFNElJ/FxjtztasgDSoIworTegTyiBxIR3pz77nm/H006jsFZcWm3p1eeAy9DD+LtL/y8JqKMeIUPyJMZ5pVaE2JoUg=@lists.linux.dev X-Gm-Message-State: AOJu0Ywnbrx2gtHvLD5kOxK/Ptfhv4g5sg6R9jclUufRSQuVSgtrs9LV JnYT4xXVmTmX8Jjry8p+mNTGKKboWc8rG+Bbmw+ixBAcW9fHk8TFVedp X-Gm-Gg: AfdE7cnL468qFjP8amhFr9nR5+eFqVVbuDcbSeNjL1OZPqDOiXEfwUsr/CUJKzI85Sl jGWiyxipQAqAboP+sbbNpytn0+gQj+0ElwAUbXfruRQ3SBSpMa+w6OqUgVE9vHmQFslCf7wEgs2 jkwkExkQSU1ZjdJD9sCKgLOBkli5RaMXi3j0XYkEbCA9HcO+bqVc2PrbHpbfapmIipKuBklWemO 20k0gTSuUEAY1emN0lweREUmHOAtg/ejGBt77k3puPZEzaBkAjOQZhzHnhuZwDyn0RG8O2qdaxf QZzFELvKrnP7ovMiopmrvcFx99KFT9mA1b5hHGmngS4CXAsERBrNyHu4rUiHHUfcN1dCov3ywp8 Jwje9V4EcQnYzqYHFHH96O6ERKPag/7MKP0Q6WWRt3GDowUHCvS/J4sEDUavMAsGq4xxYxhqNUo Lcioq6amIosF7ZOSZb5Q46qinPs3VqS5OYa4Pojn0zpe2m0pA= X-Received: by 2002:a05:7300:ad24:b0:30b:c502:23cc with SMTP id 5a478bee46e88-30bca07744bmr1769706eec.17.1781692444831; Wed, 17 Jun 2026 03:34:04 -0700 (PDT) Received: from phuc-desktop.. ([183.91.15.56]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-3081e5d0828sm24616275eec.10.2026.06.17.03.33.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 17 Jun 2026 03:34:04 -0700 (PDT) From: phucduc.bui@gmail.com To: Mark Brown Cc: Liam Girdwood , Jaroslav Kysela , Takashi Iwai , Cheng-Yi Chiang , Tzung-Bi Shih , Guenter Roeck , Benson Leung , David Rhodes , Richard Fitzgerald , povik+lin@cutebit.org, Charles Keepax , Support Opensource , Nick Li , Herve Codina , Srinivas Kandagatla , Matthias Brugger , AngeloGioacchino Del Regno , Shenghao Ding , Kevin Lu , Baojun Xu , Sen Wang , Oder Chiou , Lars-Peter Clausen , nuno.sa@analog.com, Steven Eckhoff , patches@opensource.cirrus.com, chrome-platform@lists.linux.dev, asahi@lists.linux.dev, linux-arm-msm@vger.kernel.org, linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, bui duc phuc Subject: [PATCH 07/78] ASoC: codecs: aw88166: Use guard() for mutex locks Date: Wed, 17 Jun 2026 17:31:24 +0700 Message-ID: <20260617103235.449609-8-phucduc.bui@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260617103235.449609-1-phucduc.bui@gmail.com> References: <20260617103235.449609-1-phucduc.bui@gmail.com> Precedence: bulk X-Mailing-List: chrome-platform@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: bui duc phuc Clean up the code using guard() for mutex locks. Merely code refactoring, and no behavior change. Signed-off-by: bui duc phuc --- sound/soc/codecs/aw88166.c | 23 +++++++++-------------- 1 file changed, 9 insertions(+), 14 deletions(-) diff --git a/sound/soc/codecs/aw88166.c b/sound/soc/codecs/aw88166.c index 3f15f4ac51f7..aa37d1a3d1fa 100644 --- a/sound/soc/codecs/aw88166.c +++ b/sound/soc/codecs/aw88166.c @@ -1173,9 +1173,8 @@ static void aw88166_startup_work(struct work_struct *work) struct aw88166 *aw88166 = container_of(work, struct aw88166, start_work.work); - mutex_lock(&aw88166->lock); + guard(mutex)(&aw88166->lock); aw88166_start_pa(aw88166); - mutex_unlock(&aw88166->lock); } static void aw88166_start(struct aw88166 *aw88166, bool sync_start) @@ -1413,11 +1412,10 @@ static int aw88166_profile_set(struct snd_kcontrol *kcontrol, struct aw88166 *aw88166 = snd_soc_component_get_drvdata(codec); int ret; - mutex_lock(&aw88166->lock); + guard(mutex)(&aw88166->lock); ret = aw88166_dev_set_profile_index(aw88166->aw_pa, ucontrol->value.integer.value[0]); if (ret) { dev_dbg(codec->dev, "profile index does not change"); - mutex_unlock(&aw88166->lock); return 0; } @@ -1426,8 +1424,6 @@ static int aw88166_profile_set(struct snd_kcontrol *kcontrol, aw88166_start(aw88166, AW88166_SYNC_START); } - mutex_unlock(&aw88166->lock); - return 1; } @@ -1607,12 +1603,12 @@ static int aw88166_request_firmware_file(struct aw88166 *aw88166) return ret; } - mutex_lock(&aw88166->lock); - /* aw device init */ - ret = aw88166_dev_init(aw88166, aw88166->aw_cfg); - if (ret) - dev_err(aw88166->aw_pa->dev, "dev init failed\n"); - mutex_unlock(&aw88166->lock); + scoped_guard(mutex, &aw88166->lock) { + /* aw device init */ + ret = aw88166_dev_init(aw88166, aw88166->aw_cfg); + if (ret) + dev_err(aw88166->aw_pa->dev, "dev init failed\n"); + } return ret; } @@ -1639,7 +1635,7 @@ static int aw88166_playback_event(struct snd_soc_dapm_widget *w, struct snd_soc_component *component = snd_soc_dapm_to_component(w->dapm); struct aw88166 *aw88166 = snd_soc_component_get_drvdata(component); - mutex_lock(&aw88166->lock); + guard(mutex)(&aw88166->lock); switch (event) { case SND_SOC_DAPM_PRE_PMU: aw88166_start(aw88166, AW88166_ASYNC_START); @@ -1650,7 +1646,6 @@ static int aw88166_playback_event(struct snd_soc_dapm_widget *w, default: break; } - mutex_unlock(&aw88166->lock); return 0; } -- 2.43.0