From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f42.google.com (mail-pj1-f42.google.com [209.85.216.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0AB363D5226 for ; Fri, 26 Jun 2026 06:15:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.42 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782454519; cv=none; b=q1UHyghpHD3tZ2o0p+N2acNXBe0fDZlyrGhuGDbEQrOTGyc0yX0jNHnkG37tgIvbqIJ/UQYAen7Gw1jgV+avTADdcxF7/LhPR/iV9h/Z3nn34npbTeWkuSn0fAWy3p8ntWo6TrriQKKcVq2Jkh5h9qIoe82k7zXMWIRdLAF5nEI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782454519; c=relaxed/simple; bh=hI8Uif9OWfUC9nJ4ryYn5lVr61cKx+hjtfZlpJoMJ0U=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=VZQncGtTZoHjJchRBqHTN+mBTUeblY9YVm5qitbeb2GS/Mr5gMAZJQiYd3GEN9YlungbFa8vUaYwoddPE9rHFNMbRQRtRjhPe5PoiyTeRnsv7+Kw8Lm42+3rBw4PwDIxUrubdmi6l7iCRJAzBTKWLYD7lyxHkxqgWi81je1hgAs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=nEhZLBIp; arc=none smtp.client-ip=209.85.216.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="nEhZLBIp" Received: by mail-pj1-f42.google.com with SMTP id 98e67ed59e1d1-36b9d265355so293197a91.2 for ; Thu, 25 Jun 2026 23:15:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1782454517; x=1783059317; darn=lists.linux.dev; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=DUaUW9hyC9Ct9STDjbyAspp3HtPck/9M1aAPJx5Uwvs=; b=nEhZLBIpfnCXZlyb5uYR0WF87yGOU9H66eUPDqqLw883IGTbY+fRYnZ1IWJeaXOdgr EJ4lRi6aBfzWbTgYxHVTdklktRrLCxCKfZ8JMHAbC7bAZLx7gHsotJOTDRRv8zM9Xmqg kGOWXHte4EYn3niCFyrVysPB5f40dqj4EVpL3wN/dCDCGyT/M3gXb3CHEWDnC1HrLRFP je4/rIwz0V4KPNX4goBdnhHMQ5OOmAjNNEIzA/gQh8wkqWn50suCb/FrjkKA2U8c7KaP ZFifdDldGiZYnzA/bCoKYZJ60NxvF3jAcm375Jk5H+0IZw5TxgkOJ67K6uu70XUJQhbN ZSaA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1782454517; x=1783059317; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=DUaUW9hyC9Ct9STDjbyAspp3HtPck/9M1aAPJx5Uwvs=; b=rVhlyBkiAXFYFhTmRm30XC3EGCYRpLvHWURPpLw5ohlfqBQM9m6lEM7uizgCvVfPey jTl0YH7yRKxe23hq/9W70KOypm34QfV8cH1OhqCYpRhrJDFLKLqFQwePkcjXKklTb1f6 g99mqgRCrNapocS8NUC44A9GZb8wn9F9k4tmVkUAG/qGr2jw/y0GV4UYgbvGSL93jjq6 nSJIqLiDcLcQoBHA+9gCDtiBCd5Mu/i/1LRjjblxXMYR0i/qQo1LJWqO9nYAXHKWuA5R FbMHVckBLRoue8wLgv8+NmTMXH6q83JKP6KQa8wMG1Zh57V2eT//qvTfarVmDzkWlH6U lypQ== X-Forwarded-Encrypted: i=1; AHgh+RqEb/7S4CYtbv9VsvsBXZoZjOZVPWLb3qctTfz+vUDEHwnSvHr4UmBcsZC7PI6j3xpWNpGfsSzsDIDCsdgdDoU=@lists.linux.dev X-Gm-Message-State: AOJu0YwI9e8ouJjVKrvkpoNBS5j6q2VBi9RY2uzZcZT+ey7TMOlhj2wX kGaIYyJlmP/7KTlM7Vs1BJMSsd5/qTcy/ziG32DYKd3zQG9mJuhAumvH X-Gm-Gg: AfdE7clcPfKhliLMWunO4Bdhfnhne97wcWgDV22kZpQyz+3NWct44+Q/ioW0Ix+RNTe XTvoy1iUm3yJPf9qS6d2YadsMMBUXUqL+AQLEivwlAyIiuXtcRVJv4KnQhjkNzSI5nynuEHQkSA 1JN93SkZ3QogiiicMp0xyt9cWcoC1jeI12DJUWHc2ToHCowmmls4s333PDp/VQlyIobL0yr2hQd 4kpGeRvTk5WPWIiDzoMoU6BBsaG3X7FdzModSDIVa51oj95hrp4iIzRau2WaQPH1HsmH/0f6N6K sM6+O2M9t5GpJu/bCvLU1qoKFUkhaWEGIR/EHz5VuwwwpFWcLo89GytBST2+e+XaD9d4mwyYv3h Q07sYPV/uEFL4DmdyTeBcX8mvAQkFdFoJYCWQq9GNzSjXlG4b6/uEjNQiUYQPDlqwh8lT4AmDm9 B6lseBPJpUhmwYeraSJ80vNaeq8VLOBOrq3Apu5fB28CuDV0Q= X-Received: by 2002:a17:90b:4acd:b0:36b:93f7:a903 with SMTP id 98e67ed59e1d1-37dfa25a0d4mr5820315a91.18.1782454517324; Thu, 25 Jun 2026 23:15:17 -0700 (PDT) Received: from phuc-desktop.. ([183.91.15.56]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-37e12da6ec4sm302051a91.2.2026.06.25.23.15.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 25 Jun 2026 23:15:17 -0700 (PDT) From: phucduc.bui@gmail.com To: Mark Brown , Takashi Iwai , Tzung-Bi Shih , David Rhodes , Charles Keepax Cc: Liam Girdwood , Jaroslav Kysela , Cheng-Yi Chiang , Guenter Roeck , Benson Leung , Richard Fitzgerald , povik+lin@cutebit.org, linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org, patches@opensource.cirrus.com, chrome-platform@lists.linux.dev, asahi@lists.linux.dev, bui duc phuc Subject: [PATCH 10/24] ASoC: codecs: aw88399: Use guard() for mutex locks Date: Fri, 26 Jun 2026 13:13:15 +0700 Message-ID: <20260626061329.23264-11-phucduc.bui@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260626061329.23264-1-phucduc.bui@gmail.com> References: <20260626061329.23264-1-phucduc.bui@gmail.com> Precedence: bulk X-Mailing-List: chrome-platform@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: bui duc phuc Clean up the code using guard() for mutex locks. Merely code refactoring, and no behavior change. Signed-off-by: bui duc phuc --- sound/soc/codecs/aw88399.c | 15 +++++---------- 1 file changed, 5 insertions(+), 10 deletions(-) diff --git a/sound/soc/codecs/aw88399.c b/sound/soc/codecs/aw88399.c index b2ec3503f7e2..67ea073abdb7 100644 --- a/sound/soc/codecs/aw88399.c +++ b/sound/soc/codecs/aw88399.c @@ -7,6 +7,7 @@ // Author: Weidong Wang // +#include #include #include #include @@ -1140,9 +1141,8 @@ static void aw88399_startup_work(struct work_struct *work) struct aw88399 *aw88399 = container_of(work, struct aw88399, start_work.work); - mutex_lock(&aw88399->lock); + guard(mutex)(&aw88399->lock); aw88399_start_pa(aw88399); - mutex_unlock(&aw88399->lock); } static void aw88399_start(struct aw88399 *aw88399, bool sync_start) @@ -1702,11 +1702,10 @@ static int aw88399_profile_set(struct snd_kcontrol *kcontrol, struct aw88399 *aw88399 = snd_soc_component_get_drvdata(codec); int ret; - mutex_lock(&aw88399->lock); + guard(mutex)(&aw88399->lock); ret = aw88399_dev_set_profile_index(aw88399->aw_pa, ucontrol->value.integer.value[0]); if (ret) { dev_dbg(codec->dev, "profile index does not change"); - mutex_unlock(&aw88399->lock); return 0; } @@ -1715,8 +1714,6 @@ static int aw88399_profile_set(struct snd_kcontrol *kcontrol, aw88399_start(aw88399, AW88399_SYNC_START); } - mutex_unlock(&aw88399->lock); - return 1; } @@ -1939,12 +1936,11 @@ static int aw88399_request_firmware_file(struct aw88399 *aw88399) return ret; } - mutex_lock(&aw88399->lock); + guard(mutex)(&aw88399->lock); /* aw device init */ ret = aw88399_dev_init(aw88399, aw88399->aw_cfg); if (ret) dev_err(aw88399->aw_pa->dev, "dev init failed"); - mutex_unlock(&aw88399->lock); return ret; } @@ -1975,7 +1971,7 @@ static int aw88399_playback_event(struct snd_soc_dapm_widget *w, struct snd_soc_component *component = snd_soc_dapm_to_component(w->dapm); struct aw88399 *aw88399 = snd_soc_component_get_drvdata(component); - mutex_lock(&aw88399->lock); + guard(mutex)(&aw88399->lock); switch (event) { case SND_SOC_DAPM_PRE_PMU: aw88399_start(aw88399, AW88399_ASYNC_START); @@ -1986,7 +1982,6 @@ static int aw88399_playback_event(struct snd_soc_dapm_widget *w, default: break; } - mutex_unlock(&aw88399->lock); return 0; } -- 2.43.0