From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f50.google.com (mail-pj1-f50.google.com [209.85.216.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B07C242B31E for ; Wed, 8 Jul 2026 12:51:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.50 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783515081; cv=none; b=AEXaiI2P7snLZK/o6MYekOvTmP7P1oK1aeAO286VwhYf7p+W8TW9WHgr3xmO8Or5X1Gq4k6sumh69ypbMB5gB591jM4ZdnXteQH7W4ua4DidAGjmij68UvzlFJ3pFLXcYv/X7YsAnjms9HS9GirLwHPpX7ICr0dhC/DpDsDnAgY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783515081; c=relaxed/simple; bh=mG5pRpfRueqPRsS1UnGChfxPg+7TVAQuLlVgN6Molhc=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=l23uQw/aJJUWedgK7ib4s71fD4jp6CRt8yEVf+eoSkVR8pBgHCklo08kFXeJ4Q2OEVz9luoBudQU3xloFC04wg6beMO94rPfihCKJ0w0O09XFI/4AbCK8qHY0vBteNdueKoPHVPSgm2/ZogoO59JhACAXzXvmhY56k1MZB6w1mM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=hYqCNZjD; arc=none smtp.client-ip=209.85.216.50 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="hYqCNZjD" Received: by mail-pj1-f50.google.com with SMTP id 98e67ed59e1d1-3856d6fbcb3so518508a91.2 for ; Wed, 08 Jul 2026 05:51:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1783515079; x=1784119879; darn=lists.linux.dev; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=b7IGUH0VtQ7qJ0ccJyHWYquIdmNZndl5qSSw0oJlA6k=; b=hYqCNZjDLY/AAPISKLd2J1Fq1Jc8jHCmvbduP3e94Xo4xR5i8tVcUnZsVv8521HnNE UDBDVSO/uQT3UdbRsF47Wsyl2O27YBOIzti8mHkArTC/MKSAS9XcrRZk4D7JbwTk8S3r P8QU3exq7LD5E3LFHXGSUSoMHlVkvsk1EeaGv95faRQCnp1sI/4qrYAuw9OGof9Wy4W6 TXWRXkDSoVvZOdCQNtj2Lul81H0c36g3fcWUVbVwbGF5E9DnCxzr7D+3F0k8wkr5sNoD Kjm/ZHJz+n2eSWP5vVT7dkMCiKSxBc8AkjS6vgRYRzRZMhAUgiZscLu+DR1HUYVCxcj/ If1A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783515079; x=1784119879; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=b7IGUH0VtQ7qJ0ccJyHWYquIdmNZndl5qSSw0oJlA6k=; b=h4pPvE+TbY8vqvvAHA6f8zxtDNszthTxd4pPPZG1btnPb+rhX6y38lNLNFL3REJ/sN yDye9TZUqsU4Kcvq8kWJnBamhRAOwZoayYViv2XA4qGhfbPPwVG/YsjU9eDkwuTmTJgd md/I77Nlw8UFgHM3IWw8gwJlYqaVU96uNF32OAAMpUJuQ9oI1oC+gX5b4PnVrZTlWmQa 4d4oeNhMbS6VE1IhCFMhrMDL3fUM7H7BlbevAn/4PY98JIEI3vzbh/3emODKlLlAFVmx oG28wUhrlNhcjy2Yid9NTUgzNDRgtobjG64ZIym1R8hXlP6bd3GZ2vaGbgbQsf0Rba85 eM1A== X-Forwarded-Encrypted: i=1; AHgh+Rr/19Y9N5TiXsMrdqoVdvvHa/kCkCKsV85dwdUBgJxX3eONaR7qXF8/hjgkGHahoIITCJ8TX5/rQb8TLsBSDA8=@lists.linux.dev X-Gm-Message-State: AOJu0Yz4pdL4o4jhdvXYfs+vR0XY/r22Sydy46DtoMylpJwZBpXFGfpV T3BvUqO2shAvDb+2c0JXas7netV9nCddnMrD6aUYNgKgGomwaT+2Y57F X-Gm-Gg: AfdE7cm4qx5jVC91Vi47j+WQX33AAHsAtAANRzh+HGM7H3qXrnsWe5ROJuNFnLcszbF pE6+jQeb42tuGpCz1IQg9c2JbrHNq3q2n0Y8ob7bllnv0kRXAGhlF8lG2wl9590156ZONn8yq5f d2m3SMbmylbqxtkQn52xz4nbMRiq/wQnf2vTVLv3hY/WPqSAjqeZ39+WW88CCPFS9nzeTz2MHpa xszSz8F7hGS5FSlGZ2ritVA6xaoTNJJVEL/+BnLgCEwRgu6fbNRq/X2rR57CHUTc1KppWMlOceI w86ELw22Xi6+F90FP0hjODesygFphaVs8uZMEmbOwibhFOStLNceYPy8wA/3xXS31VozSCKjxj2 O7J5VPFoVltqmZSAa4xH830GwnoUwicKKrZKYVqFxJ86e1RtMuVDfTDADUltWwF7QUgSOMzkuee Wx+YaQ4VPTPtEdM0YFmLSljAP2cbopgseuyi5uLTnWEO7OzQU= X-Received: by 2002:a17:90b:5605:b0:381:aff5:aa0a with SMTP id 98e67ed59e1d1-389417e5213mr2326476a91.23.1783515079058; Wed, 08 Jul 2026 05:51:19 -0700 (PDT) Received: from phuc-desktop.. ([183.91.15.56]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-387d20a2f2fsm2784349a91.13.2026.07.08.05.51.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 08 Jul 2026 05:51:18 -0700 (PDT) From: phucduc.bui@gmail.com To: Mark Brown , Takashi Iwai , Tzung-Bi Shih , David Rhodes , Charles Keepax Cc: Liam Girdwood , Jaroslav Kysela , Cheng-Yi Chiang , Guenter Roeck , Benson Leung , Richard Fitzgerald , povik+lin@cutebit.org, u.kleine-koenig@baylibre.com, kuninori.morimoto.gx@renesas.com, christian.ehrhardt@codasip.com, Linus Walleij , Arnd Bergmann , Sakari Ailus , Thorsten Blum , Chris Morgan , Dan Carpenter , Marco Crivellari , Rosen Penev , Weidong Wang , Teguh Sobirin , Val Packett , Luca Weiss , wangdicheng , linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org, patches@opensource.cirrus.com, chrome-platform@lists.linux.dev, asahi@lists.linux.dev, Cezary Rojewski , bui duc phuc Subject: [PATCH v4 06/24] ASoC: codecs: aw88081: Use guard() for mutex locks Date: Wed, 8 Jul 2026 19:49:43 +0700 Message-ID: <20260708125002.202515-7-phucduc.bui@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260708125002.202515-1-phucduc.bui@gmail.com> References: <20260708125002.202515-1-phucduc.bui@gmail.com> Precedence: bulk X-Mailing-List: chrome-platform@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: bui duc phuc Clean up the code using guard() for mutex locks. Merely code refactoring, and no behavior change. Reviewed-by: Cezary Rojewski Signed-off-by: bui duc phuc --- sound/soc/codecs/aw88081.c | 18 ++++++------------ 1 file changed, 6 insertions(+), 12 deletions(-) diff --git a/sound/soc/codecs/aw88081.c b/sound/soc/codecs/aw88081.c index d5e886a8f106..a3cc027de606 100644 --- a/sound/soc/codecs/aw88081.c +++ b/sound/soc/codecs/aw88081.c @@ -7,6 +7,7 @@ // Author: Weidong Wang // +#include #include #include #include @@ -763,9 +764,8 @@ static void aw88081_startup_work(struct work_struct *work) struct aw88081 *aw88081 = container_of(work, struct aw88081, start_work.work); - mutex_lock(&aw88081->lock); + guard(mutex)(&aw88081->lock); aw88081_start_pa(aw88081); - mutex_unlock(&aw88081->lock); } static void aw88081_start(struct aw88081 *aw88081, bool sync_start) @@ -942,11 +942,10 @@ static int aw88081_profile_set(struct snd_kcontrol *kcontrol, int ret; /* pa stop or stopping just set profile */ - mutex_lock(&aw88081->lock); + guard(mutex)(&aw88081->lock); ret = aw88081_dev_set_profile_index(aw88081->aw_pa, ucontrol->value.integer.value[0]); if (ret) { dev_dbg(codec->dev, "profile index does not change"); - mutex_unlock(&aw88081->lock); return 0; } @@ -955,8 +954,6 @@ static int aw88081_profile_set(struct snd_kcontrol *kcontrol, aw88081_start(aw88081, AW88081_SYNC_START); } - mutex_unlock(&aw88081->lock); - return 1; } @@ -1165,11 +1162,9 @@ static int aw88081_request_firmware_file(struct aw88081 *aw88081) if (ret) return ret; - mutex_lock(&aw88081->lock); - ret = aw88081_dev_init(aw88081, aw88081->aw_cfg); - mutex_unlock(&aw88081->lock); + guard(mutex)(&aw88081->lock); - return ret; + return aw88081_dev_init(aw88081, aw88081->aw_cfg); } static int aw88081_playback_event(struct snd_soc_dapm_widget *w, @@ -1178,7 +1173,7 @@ static int aw88081_playback_event(struct snd_soc_dapm_widget *w, struct snd_soc_component *component = snd_soc_dapm_to_component(w->dapm); struct aw88081 *aw88081 = snd_soc_component_get_drvdata(component); - mutex_lock(&aw88081->lock); + guard(mutex)(&aw88081->lock); switch (event) { case SND_SOC_DAPM_PRE_PMU: aw88081_start(aw88081, AW88081_ASYNC_START); @@ -1189,7 +1184,6 @@ static int aw88081_playback_event(struct snd_soc_dapm_widget *w, default: break; } - mutex_unlock(&aw88081->lock); return 0; } -- 2.43.0