From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailgw01.mediatek.com (unknown [60.244.123.138]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 810EC622 for ; Thu, 2 Jun 2022 05:21:18 +0000 (UTC) X-UUID: 45217320bfc549768738f244ebdcbd4a-20220602 X-CID-P-RULE: Release_Ham X-CID-O-INFO: VERSION:1.1.5,REQID:4c6e7e22-4ee9-40c7-a15b-1eb1ca0b54e5,OB:0,LO B:0,IP:0,URL:0,TC:0,Content:0,EDM:0,RT:0,SF:0,FILE:0,RULE:Release_Ham,ACTI ON:release,TS:0 X-CID-META: VersionHash:2a19b09,CLOUDID:1f170415-b515-4766-a72d-4514488fe823,C OID:IGNORED,Recheck:0,SF:nil,TC:nil,Content:0,EDM:-3,IP:nil,URL:0,File:nil ,QS:0,BEC:nil X-UUID: 45217320bfc549768738f244ebdcbd4a-20220602 Received: from mtkmbs10n2.mediatek.inc [(172.21.101.183)] by mailgw01.mediatek.com (envelope-from ) (Generic MTA with TLSv1.2 ECDHE-RSA-AES256-GCM-SHA384 256/256) with ESMTP id 1495350360; Thu, 02 Jun 2022 13:21:14 +0800 Received: from mtkcas11.mediatek.inc (172.21.101.40) by mtkmbs11n2.mediatek.inc (172.21.101.187) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.2.792.3; Thu, 2 Jun 2022 13:21:13 +0800 Received: from mtksdccf07 (172.21.84.99) by mtkcas11.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.0.1497.2 via Frontend Transport; Thu, 2 Jun 2022 13:21:12 +0800 Message-ID: <3c837acfbefa5b7e23e1121678b5b878f08e4ef2.camel@mediatek.com> Subject: Re: [PATCH v1 01/15] dt-binding: remoteproc: mediatek: Support dual-core SCP From: Tinghan Shen To: Krzysztof Kozlowski , Bjorn Andersson , Mathieu Poirier , Rob Herring , Krzysztof Kozlowski , Matthias Brugger , Lee Jones , Benson Leung , Guenter Roeck , Daisuke Nojiri , Sebastian Reichel , "Dustin L. Howett" , Tzung-Bi Shih , "Gustavo A. R. Silva" , Prashant Malani , "Enric Balletbo i Serra" , Brian Norris CC: , , , , , , , Date: Thu, 2 Jun 2022 13:21:12 +0800 In-Reply-To: References: <20220601112201.15510-1-tinghan.shen@mediatek.com> <20220601112201.15510-2-tinghan.shen@mediatek.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.28.5-0ubuntu0.18.04.2 Precedence: bulk X-Mailing-List: chrome-platform@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-MTK: N Hi Krzysztof, On Wed, 2022-06-01 at 13:50 +0200, Krzysztof Kozlowski wrote: > On 01/06/2022 13:21, Tinghan Shen wrote: > > The SCP co-processor is a dual-core RISC-V MCU on MT8195. > > > > Add a new property to identify each core and helps to find drivers > > through device tree API to cooperate with each other, e.g. boot flow and > > watchdog timeout flow. > > > > Add a new compatile for the driver of SCP 2nd core. > > > > Signed-off-by: Tinghan Shen > > --- > > .../devicetree/bindings/remoteproc/mtk,scp.yaml | 12 ++++++++++++ > > 1 file changed, 12 insertions(+) > > > > diff --git a/Documentation/devicetree/bindings/remoteproc/mtk,scp.yaml > > b/Documentation/devicetree/bindings/remoteproc/mtk,scp.yaml > > index eec3b9c4c713..b181786d9575 100644 > > --- a/Documentation/devicetree/bindings/remoteproc/mtk,scp.yaml > > +++ b/Documentation/devicetree/bindings/remoteproc/mtk,scp.yaml > > @@ -20,6 +20,7 @@ properties: > > - mediatek,mt8186-scp > > - mediatek,mt8192-scp > > - mediatek,mt8195-scp > > + - mediatek,mt8195-scp-dual > > > > reg: > > description: > > @@ -57,6 +58,16 @@ properties: > > memory-region: > > maxItems: 1 > > > > + mediatek,scp-core: > > + $ref: /schemas/types.yaml#/definitions/uint32-array > > + description: > > + The property value is a list with 2 items, a core id and a phandle > > uint32, not phandle. > > > + to the sibling SCP node. > > Skip this. First part is obvious from the schema, second part should be > described via items. > > The core id represents the id of the dts node contains > > + this property. The valid values of core id are 0 and 1 for dual-core SCP. > > + The phandle of sibling SCP node is used to find the register settings, > > + trigger core dependent callback, and invoke rproc API. > > Entire description did not help me to understand what's this. So far it > looks like it is not a hardware property but some programming help, so > it does not look like properly described in bindings. > > > + maxItems: 1 > > In description you said - two items. > > You need allOf:if:then disallowing this property for other variants. > > > + > > required: > > - compatible > > - reg > > @@ -115,6 +126,7 @@ examples: > > reg-names = "sram", "cfg", "l1tcm"; > > clocks = <&infracfg CLK_INFRA_SCPSYS>; > > clock-names = "main"; > > + mediatek,scp-core = <0 &scp_dual>; > > This looks like phandle, so wrong type. > > > > cros_ec { > > mediatek,rpmsg-name = "cros-ec-rpmsg"; > Thanks for your feedback. After looking for a comparable uses case, I find out a different approach. mediatek,scp-core: $ref: "/schemas/types.yaml#/definitions/phandle-array" description: Enable the dual-core support in scp driver. items: - items: - description: Assign a core id for current scp node. enum: [0, 1] - description: Phandle of another SCP node. This helps to find the scp driver of another core to trigger core dependent callback, invoke rproc subdevice API, etc. > > Best regards, > Krzysztof