From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f180.google.com (mail-pl1-f180.google.com [209.85.214.180]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9129D18BB87 for ; Sat, 2 Nov 2024 15:09:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.180 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1730560180; cv=none; b=W36POfKUFxqY6Qu06w0Eqg5ApdcCo3K36w7NGA59tc8u3AIapj/z9uFZ/+inVGWldQvdXgQiswuraq4vljBXNnGAs6DAm6sDywDLd/VMie1dycgNQnHvqDQueYpeFzc4FliWybxKP9Mbz7u2HE58FRj4xwQ8sm3AyxAjI/UeX4o= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1730560180; c=relaxed/simple; bh=L+Ocnh5eBjxxGrMYxyxEgEVGaSoGcibumMOipADOpEg=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=ihGOQY5aQjvT1NuN1PozI6g6S/bvk1krbufFYc/VdaDESNJNQLnBCKzeRv3EDgbQVISPtK1vlxraF5j9zgDSXGnUWTbskArmIuIhS+4z3utL5zDNr8HU8ziSMRkOZ/SIMJGlGAzxAPPQlhNs+eAnL3/3eNjddUykuomi65DYFTM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=tweaklogic.com; spf=pass smtp.mailfrom=tweaklogic.com; dkim=pass (2048-bit key) header.d=tweaklogic.com header.i=@tweaklogic.com header.b=VPyzKOP7; arc=none smtp.client-ip=209.85.214.180 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=tweaklogic.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=tweaklogic.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=tweaklogic.com header.i=@tweaklogic.com header.b="VPyzKOP7" Received: by mail-pl1-f180.google.com with SMTP id d9443c01a7336-20c8c50fdd9so26192095ad.0 for ; Sat, 02 Nov 2024 08:09:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tweaklogic.com; s=google; t=1730560178; x=1731164978; darn=lists.linux.dev; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=0leqICJyTXfsj1QTNtYhe89s48cLc/TfjqKKmksT/s0=; b=VPyzKOP7DJqiKBsZLzEWioEh/N3NbTY2XgrFq7yQgDWjEWNhKx2KD4ENu40hq0fzUa Pc1hwHSU9EfGAT1gew0NdhaCWhIzKYOjBvMohjFuBlbKDP0lXfqsbWklOopHfpwHefy7 Id2P9jgaxLp27M3PUujRimKmCB3f7vvmRaN/A9Mc88dvcgdgkOhh0LoPapj+kvvZSH8W f6aLkqPOpiks0odhmEaUoH/9vGyaTbBPPp/GMIPKBFjHORq/why89n5DTaHVWjHTgC9z euBHfaEFT+WTlxvtsNDxbC/xLg0o4eFkBCE5e8m9W3rH1whvALSG5xHzrdwhsTqNBMNn SS7A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1730560178; x=1731164978; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=0leqICJyTXfsj1QTNtYhe89s48cLc/TfjqKKmksT/s0=; b=DsEEbv9zSsVm86/qbLOdcgEN+lKE48HpPRN+PB1qVLgYPeKyJu4yx07SlKP4I4L9/Y Nw5+QWCfRnf4zCZmnXtONeP0Bma1UYOANlEBdt74vfdEzvI+T3V8HAlgY12fNC+5AkXW xwAF47GlHHEyuwz8F9No68fgbmtdVqYs/yqAiTBH+G+ZOI2iQa7tZxvnv+KshE6DvC3u tsZNVlWLaJDBYxEwKenpYt+FggCbVO7wyA/m/r1k9w7CHnTZ8qwtB9cMyPs3oK5TxwPJ gjL6gNgc6mtlH9VIJtmRcwE35KhghIc2+b7IgBnXuvXhrQY807fpNvxH6Z0HN3p3uQvw lWmQ== X-Forwarded-Encrypted: i=1; AJvYcCW5VTTbIgaZjPKKFbBrynYQmRaCL2tT5Ux2zzPlOg1iZD0IFdJDHMQBDeqfpZ2WXkyh20bmmZxjGGt3kioigFs=@lists.linux.dev X-Gm-Message-State: AOJu0Yx8HxIMX5OzA9nYcpr8hwednQoz02lb0sRogYrhl4LyeoVqYHKW 7mqhxWITSH2fCCF2ll6Pu558Gt3vz1NxdBrVMZdRQOZVIcjbOsReLHtuE3AfFJk= X-Google-Smtp-Source: AGHT+IGtMCKhO/lNmhTUeMJKCu6Ot50mbF1xufreQMYqVzRQWGDn7Q9Kxh30qqU37dlU6/vepIGY0Q== X-Received: by 2002:a17:902:ec8e:b0:211:2fb2:6a6 with SMTP id d9443c01a7336-2112fb206e3mr49239715ad.24.1730560177752; Sat, 02 Nov 2024 08:09:37 -0700 (PDT) Received: from [192.168.50.161] ([180.150.112.66]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-211057c0ed3sm34953685ad.216.2024.11.02.08.09.28 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 02 Nov 2024 08:09:37 -0700 (PDT) Message-ID: <43b07db2-6856-4dd2-8616-560a24d9f09a@tweaklogic.com> Date: Sun, 3 Nov 2024 01:39:25 +1030 Precedence: bulk X-Mailing-List: chrome-platform@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 13/15] iio: light: apds9306: simplifies if branch in apds9306_write_event_config To: Julien Stephan Cc: Jonathan Cameron , Mudit Sharma , Lars-Peter Clausen , Anshul Dalal , Javier Carrasco , Jean-Baptiste Maneyrol , Michael Hennerich , Cosmin Tanislav , Ramona Gradinariu , Antoniu Miclaus , Dan Robertson , Marcelo Schmitt , Matteo Martelli , Anand Ashok Dumbre , Michal Simek , Mariel Tinaco , Jagath Jog J , Lorenzo Bianconi , Kevin Tsai , Linus Walleij , Benson Leung , Guenter Roeck , linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, chrome-platform@lists.linux.dev References: <20241031-iio-fix-write-event-config-signature-v2-0-2bcacbb517a2@baylibre.com> <20241031-iio-fix-write-event-config-signature-v2-13-2bcacbb517a2@baylibre.com> <20241101164118.687be624@jic23-huawei> <4e4e5281-d489-42b5-b358-c44958cfa4f9@tweaklogic.com> Content-Language: en-US From: Subhajit Ghosh In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 3/11/24 00:59, Julien Stephan wrote: > Le sam. 2 nov. 2024 à 14:21, Subhajit Ghosh > a écrit : >> >> On 2/11/24 03:11, Jonathan Cameron wrote: >>> On Thu, 31 Oct 2024 16:27:08 +0100 >>> Julien Stephan wrote: >>> >>>> Simplifies the regmap_wite if branch in apds9306_write_event_config. >>> Applied. >>>> >>>> Signed-off-by: Julien Stephan >>>> --- >>>> drivers/iio/light/apds9306.c | 5 +---- >>>> 1 file changed, 1 insertion(+), 4 deletions(-) >>>> >>>> diff --git a/drivers/iio/light/apds9306.c b/drivers/iio/light/apds9306.c >>>> index 8adc74040db2bddf93fbb773e3519abcc726b9a6..9c08e7c3ad0c17519689a630d42fe9b90438dfe8 100644 >>>> --- a/drivers/iio/light/apds9306.c >>>> +++ b/drivers/iio/light/apds9306.c >>>> @@ -1125,10 +1125,7 @@ static int apds9306_write_event_config(struct iio_dev *indio_dev, >>>> } >>>> } >>>> case IIO_EV_TYPE_THRESH_ADAPTIVE: >>>> - if (state) >>>> - return regmap_field_write(rf->int_thresh_var_en, 1); >>>> - else >>>> - return regmap_field_write(rf->int_thresh_var_en, 0); >>>> + return regmap_field_write(rf->int_thresh_var_en, state); >>>> default: >>>> return -EINVAL; >>>> } >>>> >>> >> Hi Julien, >> Sorry for the delay. >> "int_thresh_var_en" corresponds to APDS9306_INT_CFG_REG bit 3 (Datasheet: INT_CFG, Address: 0x19) which >> is a single bit value only. If user does "echo 4 > /sys/bus/iio/devices/iio:device0/events/thresh_adaptive_either_en", >> which trickles down to the "state" variable, do we really want to write any other value except "0" or "1"? >> Correct me if I am wrong here. > > Hi Subhajit, > In drivers/iio/industrialio-event.c, iio_ev_state_store is actually > using kstrtobool to check user input, then gives the converted boolean > value to write_event_configOhh ok, that's handy. > So state is a boolean. By the way the purpose of this series is to > clean up code and use a bool instead of int for the state parameter. Thank you Julien for your efforts. > > So new code is equivalent to what was there before. > Cheers > Julien > Since it is already applied, nothing much for me to do here. Regards, Subhajit Ghosh