Re:[PATCH v2 03/34] drm/bridge: analogix-anx6345: convert to devm_drm_bridge_alloc() API

["Andy Yan" <andyshrk@163.com>]

Hi,

At 2025-04-25 02:59:10, "Luca Ceresoli" <luca.ceresoli@bootlin.com> wrote:
>This is the new API for allocating DRM bridges.
>
>Signed-off-by: Luca Ceresoli <luca.ceresoli@bootlin.com>

Reviewed-by: Andy Yan <andyshrk@163.com>

>
>---
>
>Cc: "Uwe Kleine-König" <u.kleine-koenig@baylibre.com>
>Cc: Andy Yan <andy.yan@rock-chips.com>
>Cc: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
>Cc: Jani Nikula <jani.nikula@intel.com>
>Cc: Sui Jingfeng <sui.jingfeng@linux.dev>
>---
> drivers/gpu/drm/bridge/analogix/analogix-anx6345.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
>diff --git a/drivers/gpu/drm/bridge/analogix/analogix-anx6345.c b/drivers/gpu/drm/bridge/analogix/analogix-anx6345.c
>index f2bafa6cf77956ecafc87aae3a2b6890bdb36cfa..f3fe47b12edca1f92ddd306d152be144df5649b5 100644
>--- a/drivers/gpu/drm/bridge/analogix/analogix-anx6345.c
>+++ b/drivers/gpu/drm/bridge/analogix/analogix-anx6345.c
>@@ -664,9 +664,10 @@ static int anx6345_i2c_probe(struct i2c_client *client)
> 	struct device *dev;
> 	int i, err;
> 
>-	anx6345 = devm_kzalloc(&client->dev, sizeof(*anx6345), GFP_KERNEL);
>-	if (!anx6345)
>-		return -ENOMEM;
>+	anx6345 = devm_drm_bridge_alloc(&client->dev, struct anx6345, bridge,
>+					&anx6345_bridge_funcs);
>+	if (IS_ERR(anx6345))
>+		return PTR_ERR(anx6345);
> 
> 	mutex_init(&anx6345->lock);
> 
>@@ -738,7 +739,6 @@ static int anx6345_i2c_probe(struct i2c_client *client)
> 	/* Look for supported chip ID */
> 	anx6345_poweron(anx6345);
> 	if (anx6345_get_chip_id(anx6345)) {
>-		anx6345->bridge.funcs = &anx6345_bridge_funcs;
> 		drm_bridge_add(&anx6345->bridge);
> 
> 		return 0;
>
>-- 
>2.49.0
>