From: Krzysztof Kozlowski <krzk@kernel.org>
To: Pavan Holla <pholla@chromium.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Heikki Krogerus <heikki.krogerus@linux.intel.com>,
Benson Leung <bleung@chromium.org>,
Tzung-Bi Shih <tzungbi@kernel.org>,
Guenter Roeck <groeck@chromium.org>
Cc: linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org,
Abhishek Pandit-Subedi <abhishekpandit@chromium.org>,
chrome-platform@lists.linux.dev
Subject: Re: [PATCH v2 3/3] platform/chrome: cros_ec_ucsi: Implement UCSI PDC driver
Date: Tue, 26 Mar 2024 09:46:53 +0100 [thread overview]
Message-ID: <62b2c29f-ca1a-4131-910b-7b9b62a5577e@kernel.org> (raw)
In-Reply-To: <20240325-public-ucsi-h-v2-3-a6d716968bb1@chromium.org>
On 26/03/2024 00:42, Pavan Holla wrote:
> Implementation of transport driver for UCSI. This driver will be used
> if the ChromeOS EC implements a PPM.
>
> +static struct platform_driver cros_ucsi_driver = {
> + .driver = {
> + .name = DRV_NAME,
> + .pm = &cros_ucsi_pm_ops,
> + },
> + .probe = cros_ucsi_probe,
> + .remove = cros_ucsi_remove,
> +};
> +
> +module_platform_driver(cros_ucsi_driver);
> +
> +MODULE_LICENSE("GPL");
> +MODULE_DESCRIPTION("UCSI driver for ChromeOS EC.");
> +MODULE_ALIAS("platform:" DRV_NAME);
Nothing improved.
One patchset per 24h. Allow people to actually review your code.
Best regards,
Krzysztof
next prev parent reply other threads:[~2024-03-26 8:47 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-25 23:42 [PATCH v2 0/3] usb: typec: Implement UCSI driver for ChromeOS Pavan Holla
2024-03-25 23:42 ` [PATCH v2 1/3] usb: typec: ucsi: Provide interface for UCSI transport Pavan Holla
2024-03-25 23:42 ` [PATCH v2 2/3] usb: typec: ucsi: Import " Pavan Holla
2024-03-27 11:22 ` Heikki Krogerus
2024-03-27 22:40 ` Pavan Holla
2024-03-25 23:42 ` [PATCH v2 3/3] platform/chrome: cros_ec_ucsi: Implement UCSI PDC driver Pavan Holla
2024-03-26 8:46 ` Krzysztof Kozlowski [this message]
2024-03-27 3:39 ` Pavan Holla
2024-03-27 4:59 ` Krzysztof Kozlowski
2024-03-28 2:32 ` Pavan Holla
2024-03-28 8:36 ` Krzysztof Kozlowski
2024-03-28 9:57 ` Tzung-Bi Shih
2024-03-28 12:16 ` Krzysztof Kozlowski
2024-03-29 1:37 ` Tzung-Bi Shih
2024-03-28 15:32 ` Dmitry Baryshkov
2024-03-29 15:08 ` Pavan Holla
2024-03-29 15:13 ` Dmitry Baryshkov
2024-04-01 20:32 ` Pavan Holla
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=62b2c29f-ca1a-4131-910b-7b9b62a5577e@kernel.org \
--to=krzk@kernel.org \
--cc=abhishekpandit@chromium.org \
--cc=bleung@chromium.org \
--cc=chrome-platform@lists.linux.dev \
--cc=gregkh@linuxfoundation.org \
--cc=groeck@chromium.org \
--cc=heikki.krogerus@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=pholla@chromium.org \
--cc=tzungbi@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox