Chrome platform driver development
 help / color / mirror / Atom feed
From: "Gustavo A. R. Silva" <gustavo@embeddedor.com>
To: Tzung-Bi Shih <tzungbi@kernel.org>,
	"Gustavo A. R. Silva" <gustavoars@kernel.org>
Cc: Alexandre Belloni <alexandre.belloni@bootlin.com>,
	Benson Leung <bleung@chromium.org>,
	Guenter Roeck <groeck@chromium.org>,
	linux-rtc@vger.kernel.org, chrome-platform@lists.linux.dev,
	linux-kernel@vger.kernel.org, linux-hardening@vger.kernel.org
Subject: Re: [RFC] rtc: Avoid a couple of -Wflex-array-member-not-at-end warnings
Date: Fri, 14 Mar 2025 11:17:45 +1030	[thread overview]
Message-ID: <63d0cca7-b095-4762-8ec4-5004e5c6bad1@embeddedor.com> (raw)
In-Reply-To: <Z9EZByipsNmBoVea@google.com>


> I'm not a big fan of the solution.  How about using something similar to:
> 
> struct cros_ec_command *msg = kzalloc(sizeof(*msg) +
>                                        sizeof(struct ec_response_rtc), ...);
> 

Thanks for the feedback. :) We can actually use DEFINE_RAW_FLEX():

https://lore.kernel.org/linux-hardening/Z9N8BsVJF-s6Hcvd@kspp/

--
Gustavo


      reply	other threads:[~2025-03-14  0:48 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-03-10  5:16 [RFC] rtc: Avoid a couple of -Wflex-array-member-not-at-end warnings Gustavo A. R. Silva
2025-03-12  5:17 ` Tzung-Bi Shih
2025-03-14  0:47   ` Gustavo A. R. Silva [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=63d0cca7-b095-4762-8ec4-5004e5c6bad1@embeddedor.com \
    --to=gustavo@embeddedor.com \
    --cc=alexandre.belloni@bootlin.com \
    --cc=bleung@chromium.org \
    --cc=chrome-platform@lists.linux.dev \
    --cc=groeck@chromium.org \
    --cc=gustavoars@kernel.org \
    --cc=linux-hardening@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-rtc@vger.kernel.org \
    --cc=tzungbi@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox