Chrome platform driver development
 help / color / mirror / Atom feed
From: Stephen Horvath <s.horvath@outlook.com.au>
To: Lee Jones <lee@kernel.org>, Benson Leung <bleung@chromium.org>,
	Guenter Roeck <groeck@chromium.org>,
	Tzung-Bi Shih <tzungbi@kernel.org>,
	chrome-platform@lists.linux.dev, linux-kernel@vger.kernel.org
Cc: Stephen Horvath <s.horvath@outlook.com.au>
Subject: [PATCH 0/2] platform/chrome: cros_kbd_led_backlight: Automatically enable keyboard backlight control if feature present in EC
Date: Fri, 22 Mar 2024 20:27:57 +1000	[thread overview]
Message-ID: <SY4P282MB3063CE4FBC166A68EDA40054C5312@SY4P282MB3063.AUSP282.PROD.OUTLOOK.COM> (raw)

The keyboard backlight control is not enabled by default on all devices
with a Chromium EC, e.g. my Framework 13. This patch series enables it
if the feature is present in the EC, instead of relying on
`of_match_table`s or whatever.

These patches are tested and working on my Framework 13, and KDE's
keyboard brightness slider even works. It's also gone though a couple of
reboot & sleep cycles without issue.

Also this is my first time submitting a patch to the kernel, and I'm keen
to do more, so please let me know if I've done anything wrong.

Thanks,
Steve

Stephen Horvath (2):
  platform/chrome: cros_kbd_led_backlight: Automatically enable keyboard
    backlight control if feature present in EC
  platform/chrome: cros_kbd_led_backlight: Remove obsolete commands
    (EC_CMD_PWM_*_KEYBOARD_BACKLIGHT)

 drivers/mfd/cros_ec_dev.c                     |  9 +++
 .../platform/chrome/cros_kbd_led_backlight.c  | 62 ++++++++++---------
 2 files changed, 43 insertions(+), 28 deletions(-)

-- 
2.43.0


                 reply	other threads:[~2024-03-22 10:33 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=SY4P282MB3063CE4FBC166A68EDA40054C5312@SY4P282MB3063.AUSP282.PROD.OUTLOOK.COM \
    --to=s.horvath@outlook.com.au \
    --cc=bleung@chromium.org \
    --cc=chrome-platform@lists.linux.dev \
    --cc=groeck@chromium.org \
    --cc=lee@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=tzungbi@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox