From: Brian Norris <briannorris@chromium.org>
To: Tzung-Bi Shih <tzungbi@kernel.org>
Cc: bleung@chromium.org, groeck@chromium.org,
chrome-platform@lists.linux.dev
Subject: Re: [PATCH] platform/chrome: cros_ec_lpc_mec: remove cros_ec_lpc_mec_destroy()
Date: Mon, 31 Oct 2022 09:45:57 -0700 [thread overview]
Message-ID: <Y1/7xWZDeReB7twh@google.com> (raw)
In-Reply-To: <20221031050657.3899359-1-tzungbi@kernel.org>
On Mon, Oct 31, 2022 at 01:06:57PM +0800, Tzung-Bi Shih wrote:
> It's pointless (and invalid) to destroy a statically allocated mutex in
> cros_ec_lpc_mec_destroy().
>
> Let's remove it.
>
> Signed-off-by: Tzung-Bi Shih <tzungbi@kernel.org>
This whole init()/destroy() thing hiding global state is kind of weird
in the first place, and if this ever properly becomes non-global state,
we might want to have a matching destroy() API back. But for now, this
probably makes more sense.
(Alternatively, one could leave an empty function. But I think that
might hurt someone else's sense of style.)
So:
Reviewed-by: Brian Norris <briannorris@chromium.org>
next prev parent reply other threads:[~2022-10-31 16:45 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-31 5:06 [PATCH] platform/chrome: cros_ec_lpc_mec: remove cros_ec_lpc_mec_destroy() Tzung-Bi Shih
2022-10-31 15:20 ` Guenter Roeck
2022-10-31 16:45 ` Brian Norris [this message]
2022-11-01 2:40 ` patchwork-bot+chrome-platform
2022-11-01 4:40 ` patchwork-bot+chrome-platform
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y1/7xWZDeReB7twh@google.com \
--to=briannorris@chromium.org \
--cc=bleung@chromium.org \
--cc=chrome-platform@lists.linux.dev \
--cc=groeck@chromium.org \
--cc=tzungbi@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox