From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 37BEB1C26 for ; Wed, 23 Nov 2022 08:54:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1669193643; x=1700729643; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=4BV3r9SxAr4VNWpyNtV7GXCDpxpEV3V9ULZRmjgFZwA=; b=WRV/Eg43lpSCpa9AQMRCF+HWqHpJq3ifD/6vvQdO9CHFo90aliLZy3Lg CG6zQouDfF0NAFfykw5BQtxLyUoJ8muJTkCTE/KwEzhcRmoc/JXeDM9y4 jPit0/91YAoZwxTecIlAk7fA4pxpodLwxeSM2ntVjZw14WvZld5V88aaA gotkm1nX0BVlwmqmZ04lWH2vVNlJerMCiVJApBmFferPXL5m5snG770XZ mWFbAjQq2N72GLV8uH5huXkdtd0ySxykLsxF7ovMNaMrKQZMcvd9YnXyj 0chHxjm7Xt1xMuuAs+4HO3uBr+6L8E8Kk9W1IB3MrcOzMMxjdSPG1alWI A==; X-IronPort-AV: E=McAfee;i="6500,9779,10539"; a="314051734" X-IronPort-AV: E=Sophos;i="5.96,186,1665471600"; d="scan'208";a="314051734" Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 23 Nov 2022 00:54:02 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10539"; a="784161497" X-IronPort-AV: E=Sophos;i="5.96,186,1665471600"; d="scan'208";a="784161497" Received: from kuha.fi.intel.com ([10.237.72.185]) by fmsmga001.fm.intel.com with SMTP; 23 Nov 2022 00:53:45 -0800 Received: by kuha.fi.intel.com (sSMTP sendmail emulation); Wed, 23 Nov 2022 10:53:44 +0200 Date: Wed, 23 Nov 2022 10:53:44 +0200 From: Heikki Krogerus To: Prashant Malani Cc: linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org, chrome-platform@lists.linux.dev, Benson Leung , Greg Kroah-Hartman , Guenter Roeck Subject: Re: [PATCH v2 1/2] usb: typec: Add partner PD object wrapper Message-ID: References: <20221122220538.2991775-1-pmalani@chromium.org> <20221122220538.2991775-2-pmalani@chromium.org> Precedence: bulk X-Mailing-List: chrome-platform@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20221122220538.2991775-2-pmalani@chromium.org> On Tue, Nov 22, 2022 at 10:05:36PM +0000, Prashant Malani wrote: > Some port drivers may want to set a Type-C partner as a parent for a > USB Power Delivery object, but the Type-C partner struct isn't exposed > outside of the Type-C class driver. Add a wrapper to > usb_power_delivery_register() which sets the provided Type-C partner > as a parent to the USB PD object. This helps to avoid exposing the > Type-C partner's device struct unnecessarily. > > Suggested-by: Heikki Krogerus > Cc: Benson Leung > Signed-off-by: Prashant Malani Reviewed-by: Heikki Krogerus > --- > > Changes since v1: > - Patch first introduced in v2. > > drivers/usb/typec/class.c | 19 +++++++++++++++++++ > include/linux/usb/typec.h | 4 ++++ > 2 files changed, 23 insertions(+) > > diff --git a/drivers/usb/typec/class.c b/drivers/usb/typec/class.c > index bd5e5dd70431..5897905cb4f0 100644 > --- a/drivers/usb/typec/class.c > +++ b/drivers/usb/typec/class.c > @@ -821,6 +821,25 @@ void typec_partner_set_svdm_version(struct typec_partner *partner, > } > EXPORT_SYMBOL_GPL(typec_partner_set_svdm_version); > > +/** > + * typec_partner_usb_power_delivery_register - Register Type-C partner USB Power Delivery Support > + * @partner: Type-C partner device. > + * @desc: Description of the USB PD contract. > + * > + * This routine is a wrapper around usb_power_delivery_register(). It registers > + * USB Power Delivery Capabilities for a Type-C partner device. Specifically, > + * it sets the Type-C partner device as a parent for the resulting USB Power Delivery object. > + * > + * Returns handle to struct usb_power_delivery or ERR_PTR. > + */ > +struct usb_power_delivery * > +typec_partner_usb_power_delivery_register(struct typec_partner *partner, > + struct usb_power_delivery_desc *desc) > +{ > + return usb_power_delivery_register(&partner->dev, desc); > +} > +EXPORT_SYMBOL_GPL(typec_partner_usb_power_delivery_register); > + > /** > * typec_register_partner - Register a USB Type-C Partner > * @port: The USB Type-C Port the partner is connected to > diff --git a/include/linux/usb/typec.h b/include/linux/usb/typec.h > index 7751bedcae5d..8fa781207970 100644 > --- a/include/linux/usb/typec.h > +++ b/include/linux/usb/typec.h > @@ -23,6 +23,7 @@ struct fwnode_handle; > struct device; > > struct usb_power_delivery; > +struct usb_power_delivery_desc; > > enum typec_port_type { > TYPEC_PORT_SRC, > @@ -327,6 +328,9 @@ void typec_partner_set_svdm_version(struct typec_partner *partner, > enum usb_pd_svdm_ver svdm_version); > int typec_get_negotiated_svdm_version(struct typec_port *port); > > +struct usb_power_delivery *typec_partner_usb_power_delivery_register(struct typec_partner *partner, > + struct usb_power_delivery_desc *desc); > + > int typec_port_set_usb_power_delivery(struct typec_port *port, struct usb_power_delivery *pd); > int typec_partner_set_usb_power_delivery(struct typec_partner *partner, > struct usb_power_delivery *pd); thanks, -- heikki