From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f182.google.com (mail-pl1-f182.google.com [209.85.214.182]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9134F2F53 for ; Fri, 16 Dec 2022 19:19:15 +0000 (UTC) Received: by mail-pl1-f182.google.com with SMTP id 4so3272011plj.3 for ; Fri, 16 Dec 2022 11:19:15 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=Ugxhu4FBglbjLikh6uPAoaI4HXZLlk6yZaGG1+Cep5g=; b=KpRVudeGJv5pInD4KE6reKMeoy7bEoFZkTE5+v0monRQ3zmXFq5dovn8JOTOOJ3T5F 7pdEOoZ/ewKwnFVRu67o5PjkXZ7aAgNqcKBC2WcYae4d33643212lNx+hz/BVCX5LP6r XC2Jr17sgy+Dwech521QgenQokCQjWBxZtdEyD8/ZJZmrNg9jvgLh6FXLgtAFQwcI0/5 dqhE9RKq6vKsgwlyuFwFQ9Iq0epO6Bcw+AjFB8mV7N6GeOaDY4v7RZOHXjb+AR1Dn0Js 3334OqgTu7HcG5QFf3am08OWTyDRzph8NZFekyTxPP50Bgvorb1QiMg1yOzN5emwz+JE OPTw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=Ugxhu4FBglbjLikh6uPAoaI4HXZLlk6yZaGG1+Cep5g=; b=jCB//Z7KtKb5+652JMuWzwcNvPJ01mVTgj/eNRrXRmFgBfRFKGgQAOIU2YsRoeTRWL qGfNng3kJk88mERYNPJ7k0q9A+XE2F1Wj6CnYDdnVaKAP5o/frzixRKRHh1vHQQ5RbWc 9PPWdA+FceW7ixkjoSLJ9OcN0l63w9wtEc4N+oOw5C0sbBDHKSYIcp8iPmFYCIFJM7Z1 ZM7k8NEjRVipzaLb6i4s6O5Gd6GTff4+5Y43yw0RjU/S4SkcycvswcORxYm6NrlN/fkK hS9IydBIqBhvO98syFQ7LaOqLJxt13+EZjq6cHiD8Q7XAj1HrsGIMvhgRhGfQ0sdZSbJ tvqQ== X-Gm-Message-State: ANoB5pm5skNDbL4yBE7oylkfCei8rKXmU78XYHyK83gQtY6f78V3H8So cWCTy4VCS71MsotBGuBcXYA= X-Google-Smtp-Source: AA0mqf5ys3ffyGNG5TUwnGwvLlXiSwadMSQRypX2wPbuEjQZOw8vjGmraT9nAai3RFFJWPDspwGNzg== X-Received: by 2002:a17:903:1302:b0:189:7e2f:d64c with SMTP id iy2-20020a170903130200b001897e2fd64cmr33022272plb.55.1671218354525; Fri, 16 Dec 2022 11:19:14 -0800 (PST) Received: from google.com ([2620:15c:9d:2:211:6b31:5f6:6aef]) by smtp.gmail.com with ESMTPSA id o9-20020a170903210900b00186b138706fsm2013870ple.13.2022.12.16.11.19.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 16 Dec 2022 11:19:13 -0800 (PST) Date: Fri, 16 Dec 2022 11:19:10 -0800 From: Dmitry Torokhov To: =?utf-8?B?am9ld3Uo5ZCz5Luy5oyvKQ==?= Cc: Joe Wu , LKML , Stephen Boyd , Xiang wangx , "linux-input@vger.kernel.org" , Derek Huang , Greg Kroah-Hartman , Benson Leung , Daisuke Nojiri , Prashant Malani , Furquan Shaikh , Tzung-Bi Shih , "chrome-platform@lists.linux.dev" , Douglas Anderson , "Dustin L . Howett" , Guenter Roeck , "Gustavo A . R . Silva" , Sebastian Reichel Subject: Re: [PATCH] cros_ec_keyb: Add 3 buttons for monitor function Message-ID: References: <20221215061550.18993-1-joewu@msi.corp-partner.google.com> <5f36a68518ca44aa9566a5df801bccaa@msi.com> Precedence: bulk X-Mailing-List: chrome-platform@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <5f36a68518ca44aa9566a5df801bccaa@msi.com> On Fri, Dec 16, 2022 at 01:36:24AM +0000, joewu(吳仲振) wrote: > Hi Dmitry, > > Thank you for comments. I will try to give a clear description and sent the patch again. > Actually, the function of "leave PC(cros) mode" button is to implement 'lock the screen' in chromeOS. > Google suggests us to sent 'F13' key to lock the screen, could we do it or do you have any suggestion? Is this different from the normal power button? If it is the key with "padlock" glyph you want to map it to KEY_SLEEP or KEY_SCREENLOCK. We should no longer use or recommend overriding F13 for this. Is there an internal Google bug for this? Could you add dtor@google.com there? Thanks. -- Dmitry