From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f52.google.com (mail-pj1-f52.google.com [209.85.216.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4AFDE8C09 for ; Mon, 9 Jan 2023 19:39:52 +0000 (UTC) Received: by mail-pj1-f52.google.com with SMTP id b9-20020a17090a7ac900b00226ef160dcaso9107343pjl.2 for ; Mon, 09 Jan 2023 11:39:52 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=aJ4JfCzqm6YYlndMbkGrmhDzhoFbeiRvc2+0c/UTEBY=; b=GfJQo4XYnjXMnJiUJVeuwai4J8n3rE0213VwIKTil6Ce69dza7NyAPfZUHXJiwMEEn /HSIb91fOrldGXUWSvMxDpiPvQBhOdfJ5kmoWySVuTybYhs8TS2k+WeV2STRB8Q4nQwM xg5X8JuMb1081IfyAtLBUc1/diSSSzrO7EY7Wz/MMhewoNJMMZyvMyClyNZtOkZ1dpwX +a5resVJKmPu0/eviBDfkTwxUPrdo2yFlSrUKgxFHevSqw9da9j4ht+waufLDwbKVOZo 1mJwFtxSphobpBWegKIL2bS+kfUVt7m4uF+/pYkJz8OPzwMamYKsfpcvEFcGi84DTZZ/ DEnQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=aJ4JfCzqm6YYlndMbkGrmhDzhoFbeiRvc2+0c/UTEBY=; b=wAKXktmZadi8HO7Mix2wA2vX+RjIt35YUnJvRr+S3jbkyOjvaNmk9C+vZlMAxYarrW HryEwGDMGRWJp4yTntQrSOkyw7kRzjoMvsAbHd1X8Us/kyYf3OMc9tNvgQ6QwOX6sGN3 U9jhogGdJaYg50zdNSHeWDgqaR3R8d+2V8IFD7WIitRijomFKK1nHl8O9YUggFlnCc0k a6nafu6D/Ayzwy1Z1uM70H0nheR9InzMVgSvWoJmbQQoNojx/oo6Zdhs9AQJv6gj/8NA H5p1xHIMywcuXEUdsx+pWAUs3VOSZjNb/VRzqvLl5QGHspXr2zQLqIfF+BsE0FM6C+o2 JEmw== X-Gm-Message-State: AFqh2kp4vhH4k3qUDu2JSwznTBU/plHpEYm606YX+fzVCd6EfE2m3iL+ deKAlNP0VBxDHEveExkyuAo95Q== X-Google-Smtp-Source: AMrXdXtCP4WxAZ/xFgvRZtu8jNSu0jpRtpggaFyFh53jai1TpVtfkQOcYc8I0ZcjMa/2AxO1fZxAfw== X-Received: by 2002:a17:902:9346:b0:192:8a1e:9bc7 with SMTP id g6-20020a170902934600b001928a1e9bc7mr677175plp.0.1673293191406; Mon, 09 Jan 2023 11:39:51 -0800 (PST) Received: from google.com ([2620:15c:9d:2:3529:30e5:d581:6e80]) by smtp.gmail.com with ESMTPSA id b2-20020a170902d50200b00192a96f4916sm6406049plg.259.2023.01.09.11.39.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 09 Jan 2023 11:39:50 -0800 (PST) Date: Mon, 9 Jan 2023 11:39:43 -0800 From: Benson Leung To: Prashant Malani Cc: linux-kernel@vger.kernel.org, chrome-platform@lists.linux.dev, heikki.krogerus@linux.intel.com, Benson Leung , Daisuke Nojiri , "Dustin L. Howett" , Evan Green , Greg Kroah-Hartman , Guenter Roeck , "Gustavo A. R. Silva" , Kees Cook , Lee Jones , Lee Jones , Sebastian Reichel , Stephen Boyd , Tinghan Shen , Tzung-Bi Shih , Xiang wangx Subject: Re: [PATCH 10/10] platform/chrome: cros_typec_vdm: Add VDM send support Message-ID: References: <20221228004648.793339-1-pmalani@chromium.org> <20221228004648.793339-11-pmalani@chromium.org> Precedence: bulk X-Mailing-List: chrome-platform@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="ave0XMEPWD+hATqC" Content-Disposition: inline In-Reply-To: <20221228004648.793339-11-pmalani@chromium.org> --ave0XMEPWD+hATqC Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Dec 28, 2022 at 12:45:13AM +0000, Prashant Malani wrote: > Add support to send generic VDM messages from the alt mode driver to the > partner (via the ChromeOS EC). The function introduced here is intended > to be called by the alt mode driver (via the Type-C bus logic). >=20 > Cc: Heikki Krogerus > Signed-off-by: Prashant Malani Reviewed-by: Benson Leung > --- > drivers/platform/chrome/cros_typec_vdm.c | 24 ++++++++++++++++++++++++ > 1 file changed, 24 insertions(+) >=20 > diff --git a/drivers/platform/chrome/cros_typec_vdm.c b/drivers/platform/= chrome/cros_typec_vdm.c > index fc7b602ceb37..aca9d337118e 100644 > --- a/drivers/platform/chrome/cros_typec_vdm.c > +++ b/drivers/platform/chrome/cros_typec_vdm.c > @@ -77,6 +77,30 @@ static int cros_typec_port_amode_enter(struct typec_al= tmode *amode, u32 *vdo) > sizeof(req), NULL, 0); > } > =20 > +static int cros_typec_port_amode_vdm(struct typec_altmode *amode, const = u32 hdr, > + const u32 *vdo, int cnt) > +{ > + struct cros_typec_port *port =3D typec_altmode_get_drvdata(amode); > + struct ec_params_typec_control req =3D { > + .port =3D port->port_num, > + .command =3D TYPEC_CONTROL_COMMAND_SEND_VDM_REQ, > + }; > + struct typec_vdm_req vdm_req =3D {}; > + > + vdm_req.vdm_data[0] =3D hdr; > + vdm_req.vdm_data_objects =3D cnt; > + memcpy(&vdm_req.vdm_data[1], vdo, cnt - 1); > + vdm_req.partner_type =3D TYPEC_PARTNER_SOP; > + req.vdm_req_params =3D vdm_req; > + > + dev_dbg(port->typec_data->dev, "Sending VDM, hdr: %x, num_objects: %d, = port: %d\n", > + hdr, cnt, port->port_num); > + > + return cros_ec_cmd(port->typec_data->ec, 0, EC_CMD_TYPEC_CONTROL, &req, > + sizeof(req), NULL, 0); > +} > + > struct typec_altmode_ops port_amode_ops =3D { > .enter =3D cros_typec_port_amode_enter, > + .vdm =3D cros_typec_port_amode_vdm, > }; > --=20 > 2.39.0.314.g84b9a713c41-goog >=20 >=20 --=20 Benson Leung Staff Software Engineer Chrome OS Kernel Google Inc. bleung@google.com Chromium OS Project bleung@chromium.org --ave0XMEPWD+hATqC Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYKAB0WIQQCtZK6p/AktxXfkOlzbaomhzOwwgUCY7xtfwAKCRBzbaomhzOw wgK7AQDJDYDwhW2Nb640pvBtKbu4HD8oBF2zIL+PEs6ybEUBAAD/Ut8HlwZnHQw/ Z3fB9mZO4uji9sD+BUD+TFcZxc477ws= =TD7C -----END PGP SIGNATURE----- --ave0XMEPWD+hATqC--