From: Tzung-Bi Shih <tzungbi@google.com>
To: Prashant Malani <pmalani@chromium.org>
Cc: bleung@chromium.org, groeck@chromium.org,
chrome-platform@lists.linux.dev
Subject: Re: [PATCH v3 4/6] platform/chrome: cros_ec: don't initialize `err` in cros_ec_register()
Date: Wed, 16 Feb 2022 12:12:03 +0800 [thread overview]
Message-ID: <Ygx5kzRlwlNfn13e@google.com> (raw)
In-Reply-To: <CACeCKaf3uNOtr9BUONqs7W5QCYha-3MzZGX196UtYsBdezODwA@mail.gmail.com>
On Tue, Feb 15, 2022 at 01:39:57PM -0800, Prashant Malani wrote:
> On Feb 09 17:57, Tzung-Bi Shih wrote:
> > `err` in cros_ec_register() doesn't need to be initialized because it is going
> > to be overridden in the following code soon.
>
> As mentioned in the previous version [1], please drop this patch, since
> it is not necessary (doesn't meaningfully improve readability, doesn't
> fix any bugs).
>
> [1] https://lore.kernel.org/chrome-platform/CACeCKaeRz2D-DdPRHbrvywTMr2w-MPuGZ+-mBhNtWCapgm=ZXw@mail.gmail.com/
Ack, will drop it in the next version.
next prev parent reply other threads:[~2022-02-16 4:12 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-09 9:56 [PATCH v3 0/6] platform/chrome: cros_ec: miscellaneous cleanups Tzung-Bi Shih
2022-02-09 9:56 ` [PATCH v3 1/6] platform/chrome: cros_ec: fix error handling in cros_ec_register() Tzung-Bi Shih
2022-02-15 21:39 ` Prashant Malani
2022-02-16 4:11 ` Tzung-Bi Shih
2022-02-09 9:56 ` [PATCH v3 2/6] platform/chrome: cros_ec: remove unused variable `was_wake_device` Tzung-Bi Shih
2022-02-09 9:57 ` [PATCH v3 3/6] platform/chrome: cros_ec: determine `wake_enabled` in cros_ec_suspend() Tzung-Bi Shih
2022-02-09 9:57 ` [PATCH v3 4/6] platform/chrome: cros_ec: don't initialize `err` in cros_ec_register() Tzung-Bi Shih
2022-02-15 21:39 ` Prashant Malani
2022-02-16 4:12 ` Tzung-Bi Shih [this message]
2022-02-09 9:57 ` [PATCH v3 5/6] platform/chrome: cros_ec: sort header inclusion alphabetically Tzung-Bi Shih
2022-02-15 21:40 ` Prashant Malani
2022-02-09 9:57 ` [PATCH v3 6/6] platform/chrome: cros_ec: append newline to all logs Tzung-Bi Shih
2022-02-15 21:40 ` Prashant Malani
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Ygx5kzRlwlNfn13e@google.com \
--to=tzungbi@google.com \
--cc=bleung@chromium.org \
--cc=chrome-platform@lists.linux.dev \
--cc=groeck@chromium.org \
--cc=pmalani@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox