From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f43.google.com (mail-wr1-f43.google.com [209.85.221.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E4F7A1FB8 for ; Tue, 15 Mar 2022 11:10:33 +0000 (UTC) Received: by mail-wr1-f43.google.com with SMTP id q14so28412351wrc.4 for ; Tue, 15 Mar 2022 04:10:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=6K23UjVYx8CDoSve9SilwO70F6QmU57lkW6EMzdPtH4=; b=pASCpeJpbdEbqtMdFz/LMDtOLUQPa+1SLdZdZFqouqWBEgo1UsWkoqRKyRExnrYi/j unsGxbVqZeqEYUf2dwqFptm8wPdDmnOVKIJ1HlxyAN7JPQ3iScbHAXrC1Y7rBvsLM2M6 kTXyHJVcUnBWSagMQOKoIe/O3phe6V3F9lw/t4OUA8yByQZ2x5wusYYOzZl2oP7rcpwb v4X0lR0Cq7n+5ogn4ZrrUirRjzdDHBi/i4nfjknjg7Mwri3Hf5LF0CKtEvB2s56T2aDx /9+28IDP0p9KrvwIKlwnMu8jPTNu+NdTO63CyWQQ/lafWOGDz1hWxgOjPmOKf3kAina1 XAsA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=6K23UjVYx8CDoSve9SilwO70F6QmU57lkW6EMzdPtH4=; b=2uyJFhhXzCpaixu1BLH3xZG/myw5FtodswSucjTqQb5q6OTHB7Gbt6KH1T2AkP+oUi TP5Fu6kXs62FSTSb1sGLVzD2Hc0SYjSIGjMO87zsU++1jznoLX/e5rHs3+YGmAbFaKMJ Ilw8FZeaotGhZj/FNrkjhoZKxaswaegvF7a1rsRyMXWr0E+HCy1INtTKBblCJYOF4tbV 0jg0Y81cNs+zIS8HxOJyiGV6MVy3ft/5PyzLCLSMaeu5OSnBapMpauDIDAjlWDi7Xbf2 QNO74lJ9Z5E3zBmdVp4FpMx9Hd6bn0AJbC6DJwkH2B7b+JhREMgJlX2nNV7E/ftDmr73 HJGg== X-Gm-Message-State: AOAM532M7LhKBDLOyAsa/PruEWRsvkMVjS507wXKjF7ULDMOUiU2YFfl ctL8AfCOYFRJq1tO0TtyTrcPAQ== X-Google-Smtp-Source: ABdhPJxyo8Tu+cI5LWcdBNsXhITp0l/mJqZADeSg6PkuOku8tvbq6f2IZzB1SrIHrs6Comls0FrYsw== X-Received: by 2002:a05:6000:1376:b0:1f0:4966:8d16 with SMTP id q22-20020a056000137600b001f049668d16mr19827484wrz.553.1647342632132; Tue, 15 Mar 2022 04:10:32 -0700 (PDT) Received: from google.com (cpc155339-bagu17-2-0-cust87.1-3.cable.virginm.net. [86.27.177.88]) by smtp.gmail.com with ESMTPSA id v13-20020adfe28d000000b0020375f27a5asm16182941wri.4.2022.03.15.04.10.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 15 Mar 2022 04:10:31 -0700 (PDT) Date: Tue, 15 Mar 2022 11:10:28 +0000 From: Lee Jones To: Krzysztof Kozlowski Cc: Stephen Boyd , Benson Leung , linux-kernel@vger.kernel.org, chrome-platform@lists.linux.dev, Rob Herring , devicetree@vger.kernel.org, Guenter Roeck , Douglas Anderson , Craig Hesling , Tom Hughes , Alexandru M Stan Subject: Re: [PATCH 1/2] dt-bindings: mfd: Add ChromeOS fingerprint binding Message-ID: References: <20220314232214.4183078-1-swboyd@chromium.org> <20220314232214.4183078-2-swboyd@chromium.org> Precedence: bulk X-Mailing-List: chrome-platform@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: On Tue, 15 Mar 2022, Krzysztof Kozlowski wrote: > On 15/03/2022 00:22, Stephen Boyd wrote: > > Add a binding to describe the fingerprint processor found on Chromeboks > > with a fingerprint sensor. > > > > Cc: Rob Herring > > Cc: > > Cc: Guenter Roeck > > Cc: Douglas Anderson > > Cc: Craig Hesling > > Cc: Tom Hughes > > Cc: Alexandru M Stan > > Signed-off-by: Stephen Boyd > > --- > > .../bindings/mfd/google,cros-ec-fp.yaml | 89 +++++++++++++++++++ > > 1 file changed, 89 insertions(+) > > create mode 100644 Documentation/devicetree/bindings/mfd/google,cros-ec-fp.yaml > > > > diff --git a/Documentation/devicetree/bindings/mfd/google,cros-ec-fp.yaml b/Documentation/devicetree/bindings/mfd/google,cros-ec-fp.yaml > > new file mode 100644 > > index 000000000000..05d2b2b9b713 > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/mfd/google,cros-ec-fp.yaml > > @@ -0,0 +1,89 @@ > > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > > +%YAML 1.2 > > +--- > > +$id: http://devicetree.org/schemas/mfd/google,cros-ec-fp.yaml# > > Why is this in the MFD directory? Is it really a Multi Function Device? > Description is rather opposite. You also did not CC MFD maintainer. A lot of the ChromeOS Embedded Controller support used to be located in MFD. There are still remnants, but most was moved to drivers/platform IIRC. Please see: drivers/mfd/cros_ec_dev.c However, yes, I should have been on the recipients list. -- Lee Jones [李琼斯] Principal Technical Lead - Developer Services Linaro.org │ Open source software for Arm SoCs Follow Linaro: Facebook | Twitter | Blog