From: Prashant Malani <pmalani@chromium.org>
To: Stephen Boyd <swboyd@chromium.org>
Cc: Benson Leung <bleung@chromium.org>,
linux-kernel@vger.kernel.org, patches@lists.linux.dev,
Lee Jones <lee.jones@linaro.org>,
Daisuke Nojiri <dnojiri@chromium.org>,
Guenter Roeck <groeck@chromium.org>,
chrome-platform@lists.linux.dev
Subject: Re: [PATCH 1/3] platform/chrome: cros_ec_proto: Add peripheral charger count API
Date: Mon, 18 Apr 2022 23:31:57 +0000 [thread overview]
Message-ID: <Yl307fUo09z2/M+w@chromium.org> (raw)
In-Reply-To: <CAE-0n51PX1SgqiB5vgoOLunkrxiWxH2O=jCCM5gNL97O8Ltt4Q@mail.gmail.com>
On Apr 18 16:29, Stephen Boyd wrote:
> Quoting Prashant Malani (2022-04-18 16:21:52)
> > On Apr 18 16:16, Stephen Boyd wrote:
> > >
> > > Sure. I take it that I can drop this function entirely then?
> >
> > Yeah, if it's a simple response, should be fine.
> >
> > > BTW, why is
> > > that function name the same as a struct name? It confuses my ctags.
> >
> > Yeahhh, didn't think about ctags... :/
> > Topic for another series: probably can be renamed to cros_ec_cmd() (just to keep ctags happy) ?
> >
>
> But then there'll be two cros_ec_cmd() because there's a
> cros-ec-regulator. Fun! :)
Ugh :S
I think we can get rid of that one; it looks to be the same as this
one :)
I'll write up a cleanup series if it all looks OK.
next prev parent reply other threads:[~2022-04-18 23:31 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-15 0:32 [PATCH 0/3] platform/chrome: Only register PCHG if present Stephen Boyd
2022-04-15 0:32 ` [PATCH 1/3] platform/chrome: cros_ec_proto: Add peripheral charger count API Stephen Boyd
2022-04-18 3:23 ` Tzung-Bi Shih
2022-04-18 19:43 ` Stephen Boyd
2022-04-18 23:08 ` Prashant Malani
2022-04-18 23:16 ` Stephen Boyd
2022-04-18 23:21 ` Prashant Malani
2022-04-18 23:29 ` Stephen Boyd
2022-04-18 23:31 ` Prashant Malani [this message]
2022-04-18 23:41 ` Stephen Boyd
2022-04-15 0:32 ` [PATCH 2/3] mfd: cros_ec_dev: Only register PCHG device if present Stephen Boyd
2022-04-18 3:25 ` Tzung-Bi Shih
2022-04-15 0:32 ` [PATCH 3/3] power: supply: PCHG: Use cros_ec_pchg_port_count() Stephen Boyd
2022-04-18 3:26 ` Tzung-Bi Shih
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Yl307fUo09z2/M+w@chromium.org \
--to=pmalani@chromium.org \
--cc=bleung@chromium.org \
--cc=chrome-platform@lists.linux.dev \
--cc=dnojiri@chromium.org \
--cc=groeck@chromium.org \
--cc=lee.jones@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=patches@lists.linux.dev \
--cc=swboyd@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox