From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CB13A7B for ; Mon, 9 May 2022 20:19:05 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id CCCE6C385BA; Mon, 9 May 2022 20:19:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1652127545; bh=5r+YQgeW1TpJjXQKOxfi7MiQ8NqqFPbPAU1vv/J7FQU=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=QPRDJ2bvabgYlX6LKEfpyrwMjv2jqsarmWLDw9dhI2OqL24XUdF61Nx9hDx+rXhQ7 WkiCS3JMYYQ1qAUIT+FcQwHw66hvGbYYwtmb3eVQOL+Py3/qQsQ9QaS9KlQRV3dpnD 45lw9GOYkgXr9tgJ2x7z2ooYSHURDsHH8Ce8cEDPawk76Y7IZc7PbeJAiPPbpzUMn9 HKMq7xyqPRzT+J1hcbw8O32G+l2QhZ6gXR9Q0gP0JyfFMVOaPuh2WiFYVEf9MmYhmj Gywl/y2SfFiiF7PHMwiWoBWhA/OXP5H2BEDaJGxnUF3A2+IyYvWSQ4PeUobGyYmwnR KKOee1cwb824g== Date: Mon, 9 May 2022 21:18:58 +0100 From: Mark Brown To: Kirill Marinushkin Cc: Charles Keepax , lgirdwood@gmail.com, codrin.ciubotariu@microchip.com, lars@metafoo.de, cychiang@chromium.org, tzungbi@google.com, bleung@chromium.org, matthias.bgg@gmail.com, oder_chiou@realtek.com, steven.eckhoff.opensource@gmail.com, srinivas.kandagatla@linaro.org, alexandre.belloni@bootlin.com, kuninori.morimoto.gx@renesas.com, jiaxin.yu@mediatek.com, alsa-devel@alsa-project.org, chrome-platform@lists.linux.dev, linux-mediatek@lists.infradead.org, patches@opensource.cirrus.com Subject: Re: [PATCH 01/38] ASoC: soc-component: Add comment for the endianness flag Message-ID: References: <20220504170905.332415-1-ckeepax@opensource.cirrus.com> <20220504170905.332415-2-ckeepax@opensource.cirrus.com> <20220509083729.GX38351@ediswmail.ad.cirrus.com> <901cb995-4a82-741e-00ea-a1c0b22ae749@birdec.com> <8db9f890-1513-d9ed-58e3-5b402468288e@birdec.com> Precedence: bulk X-Mailing-List: chrome-platform@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="ynGECfZ4fyGoHAyV" Content-Disposition: inline In-Reply-To: <8db9f890-1513-d9ed-58e3-5b402468288e@birdec.com> X-Cookie: Boycott meat -- suck your thumb. --ynGECfZ4fyGoHAyV Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Mon, May 09, 2022 at 10:11:03PM +0200, Kirill Marinushkin wrote: Please don't top post, reply in line with needed context. This allows readers to readily follow the flow of conversation and understand what you are talking about and also helps ensure that everything in the discussion is being addressed. > Without such a deep understanding of ASoC, as you have, I see a risk in a > bulk enable of `endianness = 1`, the way we do in this patch set. > Here, we enable an extra feature. Worst case, if some codec doesn't support > the feature, we will have a system, which thinks that it's supported, but in > reality, it doesn't work. And we will not even have a error message, because > the driver advertises the feature as supported. > Maybe my carefulness is not applicable here. I see that i don't have enough > expertise in `endianness = 1`, to participate in making the decision here. > But at least i want to ensure, that we all understand the risk. The risk here is that we expose a preexisting bug in some CPU side driver to a wider set of users, but those drivers would still be buggy no matter what and may already be causing problems on some systems even if that's not been reported so if there is a problem it's always possible that we end up helping some users who currently have issues by helping someone realise what the problem is. However most likely nobody will notice anything either way and most systems will continue using exactly the same formats they already were. --ynGECfZ4fyGoHAyV Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmJ5dzEACgkQJNaLcl1U h9C0fAf+OwC0Hyclmz9kzI3EP8ghe3HYRwAIswoc0yKCpX82o+C/6DhbMtY0/AYJ qyMt5iL5/SZwAnLjIyw+NQoHH1zPiTzEAyCaq8oxQckhVSNdr13+HSO8py2aqb1p FhtbV9i2Ca2KeoqoY8b2nlaeb/T7W/Qp/kotiDhWNs8e3vkmCDrEOnMM2YqDDKq7 oYAp/70UFzQYOTxeufAzBwLHJaoFaZr3lcjWqEqFEhwKNsUeH6tyRKrjcfk0uGBA bOqFvErmGFp/zROiWzExGJjqcMfIPsvILaAEvdk+mVS1inVzm6HtmisCIUnilBIQ +BxAMaDwZ6MRZ5nN/yRxMzzhvz7dnw== =BAa2 -----END PGP SIGNATURE----- --ynGECfZ4fyGoHAyV--