From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f43.google.com (mail-pj1-f43.google.com [209.85.216.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 15B893D9F for ; Tue, 10 May 2022 23:04:12 +0000 (UTC) Received: by mail-pj1-f43.google.com with SMTP id c1-20020a17090a558100b001dca2694f23so427659pji.3 for ; Tue, 10 May 2022 16:04:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=rpOOu3yloX9+o7QmB4b1fha0WPYoksvLJ9prqiOWMZA=; b=k00JKarFFBjlfYD+r85hwLg0trPXVpQEixLbgrBOuMBzDyi5b/kKU+CffB5c5ibqTD zxjGv7Zvu0lj5MfTWUoTgBkOspD19gvDGY+tGud+fgVwBXnUHjjkvby3B8BN9MveLS+P S6eZZopSzUB+t2aSvRryNcQnFK9X6XbfLNlJQ= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=rpOOu3yloX9+o7QmB4b1fha0WPYoksvLJ9prqiOWMZA=; b=V/bayJIXQXvm6IOqN05cCEgN9T+tIu6Tp0uKGlfdvH+NZZM1IIWLbDPpGPrtI8q+n8 okRwc73n7iA16Gb4j6449b+RBxalyCXJHDDYZzGog6tv/+5zlqcDmxfcVbYbOJOrcSLa FiOQi+ZjSSYcPxMC+ysJB7t87l89k34Qu1mtAYRZk/JOFjmT0XzI7yxlDwdJszR6cuRw B09Ujs1dZmLP76yzd/+1VPURD9e0Ti9z5OdaQpJ6o91ljW3sq+kPJLmbmUOhH2K3JKhi X9zeOBvSq6Xz90pwvrLMSMzym346RkyUEmkYGtSj57F3jmwrhg4/lSOVNzXHT9DWv/1F pZZw== X-Gm-Message-State: AOAM53095QvDDTsktiy9sBROiVFIDcGygB1dOKxrtnAXaV8YzUWx4NQ6 +MLf+oPnh0xEcMuk7bB4aQgnwg== X-Google-Smtp-Source: ABdhPJxEnJFubfWfGEANXo2HCxGCKtq5R1uXvOZ5g1XB3spi/HvrHYO1LvgE8enCGq/BukKn6rfDMw== X-Received: by 2002:a17:902:e881:b0:15e:93ac:41ba with SMTP id w1-20020a170902e88100b0015e93ac41bamr22642097plg.160.1652223851502; Tue, 10 May 2022 16:04:11 -0700 (PDT) Received: from chromium.org (157.214.185.35.bc.googleusercontent.com. [35.185.214.157]) by smtp.gmail.com with ESMTPSA id 137-20020a62178f000000b0050d4d156362sm97625pfx.1.2022.05.10.16.04.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 10 May 2022 16:04:11 -0700 (PDT) Date: Tue, 10 May 2022 23:04:09 +0000 From: Prashant Malani To: Stephen Boyd Cc: Dmitry Torokhov , linux-kernel@vger.kernel.org, patches@lists.linux.dev, chrome-platform@lists.linux.dev, Krzysztof Kozlowski , Rob Herring , devicetree@vger.kernel.org, Benson Leung , Guenter Roeck , Douglas Anderson , Hsin-Yi Wang , "Joseph S. Barrera III" Subject: Re: [PATCH v4 0/2] Input: cros-ec-keyb: Better matrixless support Message-ID: References: <20220503204212.3907925-1-swboyd@chromium.org> Precedence: bulk X-Mailing-List: chrome-platform@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220503204212.3907925-1-swboyd@chromium.org> Hi Dmitry, On May 03 13:42, Stephen Boyd wrote: > This is a followup to my previous patch[1] that skips keyboard registration > when the matrix properties aren't present. This adds a compatible string > for this scenario so we can ease existing DTBs over to the new design. > > Changes from v3 (https://lore.kernel.org/r/20220503042242.3597561-1-swboyd@chromium.org): > * s/register_keyboard/has_keyboard/ > * Pick up review tags > * Indicate properties are required in example #2 in yaml file > > Changes from v2 (https://lore.kernel.org/r/20220429233112.2851665-1-swboyd@chromium.org): > * Drop rows/cols check now that compatible schema handles it > * Make binding require rows,cols,keymap for cros-ec-keyb compatible > > Changes from v1 (https://lore.kernel.org/r/20220427203026.828183-1-swboyd@chromium.org): > * Better enforcement of properties in DT binding > * Skip registration by means of adding compatible to device id list > > Stephen Boyd (2): > dt-bindings: google,cros-ec-keyb: Introduce switches only compatible > Input: cros-ec-keyb - skip keyboard registration w/o cros-ec-keyb > compatible Do these need input maintainers Acked-by? Also, should these go through the chrome-platform branch? Thanks, -Prashant > > .../bindings/input/google,cros-ec-keyb.yaml | 87 +++++++++++++++++-- > drivers/input/keyboard/cros_ec_keyb.c | 19 ++-- > 2 files changed, 91 insertions(+), 15 deletions(-) > > Cc: Krzysztof Kozlowski > Cc: Rob Herring > Cc: > Cc: Benson Leung > Cc: Guenter Roeck > Cc: Douglas Anderson > Cc: Hsin-Yi Wang > Cc: "Joseph S. Barrera III" > > [1] https://lore.kernel.org/all/20220425210726.3813477-1-swboyd@chromium.org/ > > base-commit: 4352e23a7ff2f8a4ff229dd1283ed2f2b708ec51 > -- > https://chromeos.dev > >