From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailrelay1-1.pub.mailoutpod1-cph3.one.com (mailrelay1-1.pub.mailoutpod1-cph3.one.com [46.30.210.182]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B221933CC for ; Mon, 18 Jul 2022 18:01:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ravnborg.org; s=rsa1; h=in-reply-to:content-type:mime-version:references:message-id:subject:cc:to: from:date:from; bh=1k7ygd7TjVU/0OeLc8vN7pGFtYh4D8DdF58kU5beJu0=; b=VxuZdz71LN8l4OHMA30tuoiK0Nr/nISJyIbR4puSlqXqtLNJ3R9E8Ki5Y/fB//0ToLWnFzY6Ksx2v q15Tp+N3bjxKD5yb8cNSHhlL3Fn5bRvCp2wA20B/b8kotzJ8eyHD3W0jwgxlwEAS7y8yp9aYUCPRij D6w4iTRCC6nKQbdz1oAl9YkjdJBz4iHoVhli1MdsAc3QdBqKAH5OIBdeojkex0vvXW5oFokXNW+08W aIVUQfOp1MMmHhJ2Eo8oeIrL8vAjG4XGjO59HSG5vDKD2i9lhICvJrNx36s5unvTPFFMNLi1SgQk// otsKVYz1SQ0DcHOoKxmADC+NiOX02UA== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=ravnborg.org; s=ed1; h=in-reply-to:content-type:mime-version:references:message-id:subject:cc:to: from:date:from; bh=1k7ygd7TjVU/0OeLc8vN7pGFtYh4D8DdF58kU5beJu0=; b=jL/3JsawqxR14ggldJXwk5X9UoFKRKl4/PCzdAI+J8QjN2tXmDPVlJnoASEn5F/EpOlFEotQOERIw yI/yZMXCA== X-HalOne-Cookie: fb423e04bf4d0af1a45399369f4e4409c2acada4 X-HalOne-ID: 7dbadd68-06c3-11ed-a6c8-d0431ea8a283 Received: from mailproxy1.cst.dirpod4-cph3.one.com (2-105-2-98-cable.dk.customer.tdc.net [2.105.2.98]) by mailrelay1.pub.mailoutpod1-cph3.one.com (Halon) with ESMTPSA id 7dbadd68-06c3-11ed-a6c8-d0431ea8a283; Mon, 18 Jul 2022 18:00:22 +0000 (UTC) Date: Mon, 18 Jul 2022 20:00:20 +0200 From: Sam Ravnborg To: Dave Stevenson Cc: Dafna Hirschfeld , Neil Armstrong , David Airlie , Tomi Valkeinen , DRI Development , Laurent Pinchart , Andrzej Hajda , Guenter Roeck , chrome-platform@lists.linux.dev, Jernej Skrabec , Chun-Kuang Hu , Jitao Shi , Arnd Bergmann , Jonas Karlman , linux-mediatek@lists.infradead.org, Matthias Brugger , Linux ARM , Philip Chen , Robert Foss , linux-renesas-soc@vger.kernel.org, Kieran Bingham , Thomas Zimmermann , Enric Balletbo i Serra , Cai Huoqing Subject: Re: [PATCH v1 12/12] drm/todo: Add bridge related todo items Message-ID: References: <20220717174454.46616-1-sam@ravnborg.org> <20220717175801.78668-1-sam@ravnborg.org> <20220717175801.78668-5-sam@ravnborg.org> Precedence: bulk X-Mailing-List: chrome-platform@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Hi Dave, On Mon, Jul 18, 2022 at 11:27:37AM +0100, Dave Stevenson wrote: > Hi Sam > > On Sun, 17 Jul 2022 at 18:58, Sam Ravnborg wrote: > > > > Add todo in the hope someone will help updating the bridge drivers. > > > > v2: > > - Updated descriptions in todo.rst > > > > Signed-off-by: Sam Ravnborg > > Acked-by: Maxime Ripard > > Cc: Laurent Pinchart > > Cc: Maarten Lankhorst > > Cc: Maxime Ripard > > Cc: Thomas Zimmermann > > Cc: David Airlie > > Cc: Daniel Vetter > > --- > > Documentation/gpu/todo.rst | 20 ++++++++++++++++++++ > > 1 file changed, 20 insertions(+) > > > > diff --git a/Documentation/gpu/todo.rst b/Documentation/gpu/todo.rst > > index 10bfb50908d1..fbcc232e0bc1 100644 > > --- a/Documentation/gpu/todo.rst > > +++ b/Documentation/gpu/todo.rst > > @@ -480,6 +480,26 @@ Contact: Thomas Zimmermann > > > > Level: Starter > > > > +Drop use of deprecated operations in bridge drivers > > +-------------------------------------------------- > > + > > +&struct drm_bridge_funcs contains a number of deprecated operations > > +which can be replaced by the atomic variants. > > + > > +The following is more or less 1:1 replacements with the arguments > > +and names adjusted: > > +* pre_enable => atomic_pre_enable > > +* enable => atomic_enable > > +* disable => atomic_disable > > +* post_disable => atomic_post_disable > > + > > +* mode_set is no longer required and the implementation shall be merged > > + with atomic_enable. > > The dw-mipi-dsi and msm DSI host controller bridge drivers are > currently relying on mode_set as a convenient hook to power up the DSI > host prior to pre_enable of the bridge chain. Removing it is therefore > going to break those. > > There is a proposed mechanism to allow for the removal of this hack > [1], but it's still waiting on R-B tags and/or discussion from bridge > maintainers (gentle nudge as you are one of those maintainers). I have over time gained some knowledge of how bridges works and have applied a few patches - but the maintainer role belongs to others. I just try to help a bit. I will review the referenced series - could you then in return review this series? > > And do you mean merge with atomic_enable, or merge with > atomic_pre_enable? atomic_pre_enable would be more applicable for > almost all the bridges I'm aware of as they want to be configured > before video starts. Thanks, yes you are right. I will update the text to refer to pre_enable as this is often the right choice. Looking at how many bridges who implements mode_set, or are not yet atomic, this will take a while before we can drop it. Sam