From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(No client certificate requested)
	by smtp.subspace.kernel.org (Postfix) with ESMTPS id 40B977B
	for <chrome-platform@lists.linux.dev>; Thu, 18 Aug 2022 04:08:15 +0000 (UTC)
Received: by smtp.kernel.org (Postfix) with ESMTPSA id C6373C433C1;
	Thu, 18 Aug 2022 04:08:13 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1660795695;
	bh=pDWN1SWFQoLY+kQmDNlmfijZ8n3SHAhhTy8zIM7ERM4=;
	h=Date:From:To:Cc:Subject:References:In-Reply-To:From;
	b=XYN3YPkZZMXZ3UOhenBuHC2QYCxNpc/wlEKWq4ayEeU7OdxAWPIY02+lbPlIs+pwx
	 It6ParZnbv0Kg5FkcqgYbCWLeL7J8IRnXNSvUvIbF0coNw4WPlbHPsIyc0ISjot2SG
	 91hgjJMUyD9x+3DHn7rCKFO79ZTqfOlaEn98tU1aLhtB4qtI9ci7p8/MtZVhDv1X7h
	 l3EAD8GIyxcXU5RU96QK/iY3fKkk4m75X1byhnY7Hx2PLUfQtuOZdIXcDHy718HrQ6
	 1J6o+28rPMhahsmoCxuaduTf8dlmpURyjJfQJRcytAf/ZsNvEZ1LhGAzvoxynyvKIt
	 oAX9xCUiIjyaw==
Date: Thu, 18 Aug 2022 04:08:11 +0000
From: Tzung-Bi Shih <tzungbi@kernel.org>
To: Tim Van Patten <timvp@google.com>
Cc: rrangel@chromium.org, robbarnes@google.com,
	Benson Leung <bleung@chromium.org>,
	Guenter Roeck <groeck@chromium.org>,
	chrome-platform@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3] platform/chrome: cros_ec: Send host event for
 prepare/complete
Message-ID: <Yv27K4+rLfskcQdm@google.com>
References: <20220802113957.v3.1.I2c8c550183162e7594309b66d19af696b8d84552@changeid>
Precedence: bulk
X-Mailing-List: chrome-platform@lists.linux.dev
List-Id: <chrome-platform.lists.linux.dev>
List-Subscribe: <mailto:chrome-platform+subscribe@lists.linux.dev>
List-Unsubscribe: <mailto:chrome-platform+unsubscribe@lists.linux.dev>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20220802113957.v3.1.I2c8c550183162e7594309b66d19af696b8d84552@changeid>

On Tue, Aug 02, 2022 at 11:40:08AM -0600, Tim Van Patten wrote:
> Update cros_ec_lpc_pm_ops to call cros_ec_lpc_prepare() during PM
> .prepare() and cros_ec_lpc_complete() during .complete(). This allows the
> EC to log entry/exit of AP's suspend/resume more accurately.

As what I commented on [1], the term "host event" in the commit title is
confusing.  Also, as this is a cros_ec_lpc specific patch, please change
the prefix.

[1]: https://patchwork.kernel.org/project/chrome-platform/patch/20220706205136.v2.1.Ic7a7c81f880ab31533652e0928aa6e687bb268b5@changeid/#24934911

> -static int cros_ec_lpc_resume(struct device *dev)
> +static void cros_ec_lpc_complete(struct device *dev)
>  {
>  	struct cros_ec_device *ec_dev = dev_get_drvdata(dev);
> +	int ret;
> +
> +	ret = cros_ec_resume(ec_dev);
>  
> -	return cros_ec_resume(ec_dev);
> +	dev_info(dev, "EC resume completed: ret = %d\n", ret);

cros_ec_resume() always returns 0.