From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(No client certificate requested)
	by smtp.subspace.kernel.org (Postfix) with ESMTPS id 38BE21C32
	for <chrome-platform@lists.linux.dev>; Tue, 16 Aug 2022 05:13:12 +0000 (UTC)
Received: by smtp.kernel.org (Postfix) with ESMTPSA id 3AD42C433D6;
	Tue, 16 Aug 2022 05:13:10 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1660626792;
	bh=tKzLj6Lbsr6qspAg55d5vfym6ZkXDJIff0/0OtXmUPw=;
	h=Date:From:To:Cc:Subject:References:In-Reply-To:From;
	b=F2k4HEeAcQ+gDUO+PG3bflrli3XT93uTqRA/xIscOO3rtvRcKOl7FwPETvfFYdaUm
	 970+4IvaMI2Ck9eySfD7R31e72dt/bN4yPmwWsJswX0pHDEeJ79KApKD+6IXapyAEs
	 IFCoi8REhuM6ZV2iCJrPXPXh3dfvX4yO0bF4rBJSaJuVsk9dXVN5Z5EKm5/5LBkXPg
	 0+6LTnXZJySVHruxWq+8uCCsFZ/yIETWMB32rrj7Wzk94vZ+igSwP+Cjs7HehdBeYy
	 0s00xp4FPe0VErQ6OS9t40W9yxKKgQ2HTdyPsNA6Mt0uK3jm6FfMah40V96humc2V9
	 mdyCVZzPswVww==
Date: Tue, 16 Aug 2022 05:13:07 +0000
From: Tzung-Bi Shih <tzungbi@kernel.org>
To: Prashant Malani <pmalani@chromium.org>
Cc: linux-kernel@vger.kernel.org, chrome-platform@lists.linux.dev,
	bleung@chromium.org, Daisuke Nojiri <dnojiri@chromium.org>,
	"Dustin L. Howett" <dustin@howett.net>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Guenter Roeck <groeck@chromium.org>,
	"Gustavo A. R. Silva" <gustavoars@kernel.org>,
	Kees Cook <keescook@chromium.org>,
	Tinghan Shen <tinghan.shen@mediatek.com>,
	Xiang wangx <wangxiang@cdjrlc.com>
Subject: Re: [PATCH v5 7/7] platform/chrome: cros_ec_typec: Get retimer handle
Message-ID: <YvsnY6LwVZFibj7x@google.com>
References: <20220815063555.1384505-1-pmalani@chromium.org>
 <20220815063555.1384505-8-pmalani@chromium.org>
Precedence: bulk
X-Mailing-List: chrome-platform@lists.linux.dev
List-Id: <chrome-platform.lists.linux.dev>
List-Subscribe: <mailto:chrome-platform+subscribe@lists.linux.dev>
List-Unsubscribe: <mailto:chrome-platform+unsubscribe@lists.linux.dev>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20220815063555.1384505-8-pmalani@chromium.org>

On Mon, Aug 15, 2022 at 06:34:30AM +0000, Prashant Malani wrote:
> Where available, obtain the handle to retimer switch specified via
> firmware, and update the mux configuration callsites to add retimer
> support for supported modes.
> 
> Signed-off-by: Prashant Malani <pmalani@chromium.org>

With a nit,
Reviewed-by: Tzung-Bi Shih <tzungbi@kernel.org>

> +static int cros_typec_retimer_set(struct typec_retimer  *retimer, struct typec_mux_state state)

nit: double spaces.