Chrome platform driver development
 help / color / mirror / Atom feed
From: Heikki Krogerus <heikki.krogerus@linux.intel.com>
To: Tzung-Bi Shih <tzungbi@kernel.org>
Cc: Prashant Malani <pmalani@chromium.org>,
	linux-kernel@vger.kernel.org, chrome-platform@lists.linux.dev,
	bleung@chromium.org,
	Enric Balletbo i Serra <enric.balletbo@collabora.com>,
	Guenter Roeck <groeck@chromium.org>
Subject: Re: [PATCH 3/4] platform/chrome: cros_ec_typec: Stash port driver info
Date: Tue, 23 Aug 2022 11:17:12 +0300	[thread overview]
Message-ID: <YwSNCFt48Q9Eo02I@kuha.fi.intel.com> (raw)
In-Reply-To: <YwRa/QxA/RRtxU3P@google.com>

On Tue, Aug 23, 2022 at 04:43:41AM +0000, Tzung-Bi Shih wrote:
> On Fri, Aug 19, 2022 at 07:08:04PM +0000, Prashant Malani wrote:
> > Stash port number and a pointer to the driver-specific struct in the
> > local Type-C port struct.
> > 
> > These can be useful to the port driver to figure out how to communicate
> > with the ChromeOS EC when an altmode driver related callback is invoked
> > from the Type-C class code.
> 
> The patch looks good to me.  But I would suggest to send it in later series
> that uses the driver-specific struct (e.g. in altmode driver related callbacks)
> to make the usage clear.

I agree.

thanks,

-- 
heikki

  reply	other threads:[~2022-08-23  8:17 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-08-19 19:08 [PATCH 0/4] platform/chrome: cros_ec_typec: Altmode fixes Prashant Malani
2022-08-19 19:08 ` [PATCH 1/4] platform/chrome: cros_ec_typec: Add bit offset for DP VDO Prashant Malani
2022-08-23  4:43   ` Tzung-Bi Shih
2022-08-23  8:11   ` Heikki Krogerus
2022-08-19 19:08 ` [PATCH 2/4] platform/chrome: cros_ec_typec: Correct alt mode index Prashant Malani
2022-08-23  4:43   ` Tzung-Bi Shih
2022-08-23  8:14   ` Heikki Krogerus
2022-08-23 17:14     ` Prashant Malani
2022-08-19 19:08 ` [PATCH 3/4] platform/chrome: cros_ec_typec: Stash port driver info Prashant Malani
2022-08-23  4:43   ` Tzung-Bi Shih
2022-08-23  8:17     ` Heikki Krogerus [this message]
2022-08-23 17:52       ` Prashant Malani
2022-08-19 19:08 ` [PATCH 4/4] platform/chrome: cros_ec_typec: Use Type-C driver data Prashant Malani
2022-08-23  4:43   ` Tzung-Bi Shih
2022-08-23 17:50     ` Prashant Malani
2022-08-26 22:40 ` [PATCH 0/4] platform/chrome: cros_ec_typec: Altmode fixes patchwork-bot+chrome-platform
2022-08-26 22:41   ` Prashant Malani
2022-09-08  0:40 ` patchwork-bot+chrome-platform

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YwSNCFt48Q9Eo02I@kuha.fi.intel.com \
    --to=heikki.krogerus@linux.intel.com \
    --cc=bleung@chromium.org \
    --cc=chrome-platform@lists.linux.dev \
    --cc=enric.balletbo@collabora.com \
    --cc=groeck@chromium.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=pmalani@chromium.org \
    --cc=tzungbi@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox