From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f175.google.com (mail-pl1-f175.google.com [209.85.214.175]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D32257485 for ; Mon, 25 Nov 2024 02:50:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.175 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1732503012; cv=none; b=GaZfm5Dx8H3cvmtdAJw7ppMqARfSB1H13xE+U8nbX8RKCyDuICphpR3+dZV7N6Rg42nDhV7y4tJ5xd3+FThrk7x1ly4Ec7tKbgp/O4DcCmbXwkRz+G2Y4G2xP951AStYanG6S6AKBS7xcBloiZRVx3eqcxFiKktmv5I78dN3q8I= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1732503012; c=relaxed/simple; bh=9xWE7hQ80NTsubhmPzd5LMYo1B+VsjDN48zEUFNEFDA=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=GcTtYnbqKpbEJ4BeA8OywjnxGSybFYbYt4qIdRaabihp43bODrPDj9X9qxR3TW+iqApqZZZZC0BLR8gZhNWSb49UHK53l7DbPgFkFDKZ8cOlw77UVKesB60fg3NUzTqhYxfRbsxIFlzQDyQwFW8ZZF0M6Jnz+xSp2yJ3Bn85/7E= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org; spf=pass smtp.mailfrom=chromium.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b=iGCak7ch; arc=none smtp.client-ip=209.85.214.175 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=chromium.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="iGCak7ch" Received: by mail-pl1-f175.google.com with SMTP id d9443c01a7336-212583bd467so38933155ad.3 for ; Sun, 24 Nov 2024 18:50:10 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1732503010; x=1733107810; darn=lists.linux.dev; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=LuaL5qYMw6VKISBfy57xcOAOGx2kf2U0nHPjc0yVGaY=; b=iGCak7chJhv6jauLSHaGNnh3YKGuMpa9cUsQMDbGIDVJW+zeYKbLAyijd7s4iK4Dym 7IMcJxgoWkXnFOfLGp9kq4H3HeYn7gNukkTnwAcTy7EFAd+0HkyU9FHqIbgj2OT1Rx2w NXlLhVJo9yn5e5RtoyyG6BEOnitV3V9h6bqbo= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1732503010; x=1733107810; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=LuaL5qYMw6VKISBfy57xcOAOGx2kf2U0nHPjc0yVGaY=; b=I9PiQxgymyWsahQExt7irrmTN7c6mSK93yW8AOOFJ/pTpx2FrUgj0ZxfBUqqhEqfn+ SYhxUiafhmhJ7V9bBzFh78c340/lV8Fb8uqUkIBV2yVzYRSZuspPQz7ZanF2JOEI9H2z /IqscBNJwSMYPtSozJvzZMiJfnsfUF4ToV1GNp0Yy9up1hhokYUEZPJ3mS530KfQ1Doq Rx3bKJLH9PKAARDkg7zZHfQMDYNFObbF97XNYMAUlSGaGWNdRCXB93FkU9kcTNIKMAWq Busyu4ZJBNVev5Tt8wfBSZa78EPc99IH2cgYDMTRhaNNw1uzRX9cbemfnHejef0zIGXi +UmA== X-Forwarded-Encrypted: i=1; AJvYcCWGvUoeNN0aeErkNXw92LBn95xgeu4cGmSQJyOJMXscJp5Kljof1ut0dh742iNrQNgkNfu9G04PfRblYIQXKyc=@lists.linux.dev X-Gm-Message-State: AOJu0YxJjS4hxlwNwXHe2zjzd045fg4pirBVl+KI+tAXmUqdKPDGmeaB heVOCJWWfIn7EtJO0jT1n6nRbY4cmXEA1yvNKNW5hI3bHpaY+ZYjdAljEVo5Zg== X-Gm-Gg: ASbGncvvu5sff8bhayl65Q1O7GhaJ8Ga6qpVd0LY/q9KugFzqmI8CKdiRud385kpqfB yhewOY6dQoQIVq9JgrlPqbbbTrBnoTJNnz68G0AgyqoPozpYM+mZwKif6bsI3XntNx+RMTfbttZ ZkdOJdU5KFIXP+TxLAUkQZZr47Jrm6EhGo4cqj+VLD1R7jTLGNYleAvYsisHamnDXRNg7rBc/DU LkBmgEDPrhyqcaJQ8KN4qj0fN8qWoX0PrTm9khjOiPH X-Google-Smtp-Source: AGHT+IGheYjz/Tntpw9/GolL/DMsSlt5WgODtQmt2XRXREaZkoneuXtaerczDwb+tPVqlQ7KhsD3lA== X-Received: by 2002:a17:903:230e:b0:212:b2b:6f1d with SMTP id d9443c01a7336-2129fd23d8amr180049005ad.32.1732503010250; Sun, 24 Nov 2024 18:50:10 -0800 (PST) Received: from google.com ([2401:fa00:1:10:66a3:d18f:544f:227a]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2129dc1596esm53695155ad.189.2024.11.24.18.50.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 24 Nov 2024 18:50:09 -0800 (PST) Date: Mon, 25 Nov 2024 10:50:06 +0800 From: "Sung-Chi, Li" To: Krzysztof Kozlowski Cc: Benson Leung , Guenter Roeck , Sebastian Reichel , Lee Jones , Rob Herring , Krzysztof Kozlowski , Conor Dooley , chrome-platform@lists.linux.dev, linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org Subject: Re: [PATCH 2/2] dt-bindings: mfd: cros-ec: add properties for thermal cooling cells Message-ID: References: <20241122-extend_power_limit-v1-0-a3ecd87afa76@chromium.org> <20241122-extend_power_limit-v1-2-a3ecd87afa76@chromium.org> <4f5sahkxxqb5qonh676igaiadkxv2pbhbibu6wtx4yenplfn4o@yvidi4ujavhr> Precedence: bulk X-Mailing-List: chrome-platform@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4f5sahkxxqb5qonh676igaiadkxv2pbhbibu6wtx4yenplfn4o@yvidi4ujavhr> On Fri, Nov 22, 2024 at 08:49:14AM +0100, Krzysztof Kozlowski wrote: > On Fri, Nov 22, 2024 at 11:47:22AM +0800, Sung-Chi Li wrote: > > The cros_ec supports limiting the input current to act as a passive > > thermal cooling device. Add the property '#cooling-cells' bindings, such > > that thermal framework can recognize cros_ec as a valid thermal cooling > > device. > > > > Signed-off-by: Sung-Chi Li > > --- > > Documentation/devicetree/bindings/mfd/google,cros-ec.yaml | 3 +++ > > 1 file changed, 3 insertions(+) > > > > diff --git a/Documentation/devicetree/bindings/mfd/google,cros-ec.yaml b/Documentation/devicetree/bindings/mfd/google,cros-ec.yaml > > index aac8819bd00b..2b6f098057af 100644 > > --- a/Documentation/devicetree/bindings/mfd/google,cros-ec.yaml > > +++ b/Documentation/devicetree/bindings/mfd/google,cros-ec.yaml > > @@ -96,6 +96,9 @@ properties: > > '#gpio-cells': > > const: 2 > > > > + '#cooling-cells': > > + const: 2 > > This is not a cooling device. BTW, your commit msg is somehow circular. > "Add cooling to make it a cooling device because it will be then cooling > device." > > Power supply already provides necessary framework for managing charging > current and temperatures. If this is to stay, you need to explain why > this is suitable to be considered a thermal zone or system cooling > device (not power supply or input power cooling). > > Best regards, > Krzysztof > Thank you, I will rephrase the commit message. The reason to not to use the managing charging current and temperatures in the power supply framework is that: - The EC may not have the thermal sensor value for the charger, and there is no protocol for getting the thermal sensor value for the charger (there is command for reading thermal sensor values, but there is no specification for what sensor index is for the charger, if the charger provides thermal value). - The managing mechanism only take the charger thermal value into account, and I would like to control the current based on the thermal condition of the whole device. I will include these explanation in the following changes.