From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f45.google.com (mail-pj1-f45.google.com [209.85.216.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6CB7418B475 for ; Mon, 25 Nov 2024 08:43:45 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.45 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1732524227; cv=none; b=H+b3lfZyiFccnawvSt55k3UpgQK8z4NY6FcLCDSdGYGjhMLiQ08tC9VQ5gFMohzgZmZra8foxmncEqmejer0KXZmJu/HaqQ90FWNU0+4v/RTAKmDc0Qw7r6Kh6pAFpT5uFWkf/UjQM+F+oPlftB2eGIGwipEB6XOzYcXZZcg4Og= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1732524227; c=relaxed/simple; bh=gAVXzRO6flOMUc+jbivLLOShw9D4eUFZeiCNKksrDnw=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=D9qIFUP99kBWNG7nEsmq7EcIGWk85k2B3rF8vnQ+wHqBgig5yDYfT1TbImzHfKrGJpeMGka3SfPCtojOTxkYUsdiIIZIeWNIkhugFZR7jvvFJmwbGRYik77a0ovgRTUCcSy8zdgn1Sk4G+mVveUywaaacUOMO7LN+IdPh6V//Qc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org; spf=pass smtp.mailfrom=chromium.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b=YhdmAUlf; arc=none smtp.client-ip=209.85.216.45 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=chromium.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="YhdmAUlf" Received: by mail-pj1-f45.google.com with SMTP id 98e67ed59e1d1-2edb222a786so1012836a91.1 for ; Mon, 25 Nov 2024 00:43:45 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1732524225; x=1733129025; darn=lists.linux.dev; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=WF1SurkpJR9+d436XSidV3nIHqKYTAhhIXu+fIUsswU=; b=YhdmAUlf44d3b7wcsCKOfZDXaNwFaRPYqe7K4kV6tgYQeYhXSEvhJiwzCJ34eQ7Hqy qu0CE67RxYV5ErjkG7zDywydK6Ik+vwwsC47YXBZ+osAT1YA7j5YG/q/zOnpYe0OkiLi anC/Pwlt99UcIFNQxarIh/9jN4c1RBQTcOtj4= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1732524225; x=1733129025; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=WF1SurkpJR9+d436XSidV3nIHqKYTAhhIXu+fIUsswU=; b=UT3ahDdjWMo8ATpw2YkuDPstwiqAaC4rKL7A3vH0lxHIV6MWIX8w+id2+8DtFm6jTn kSBFSUZM8cnluo3E99Hye/hip/yaCyesU+P0g9zzjztjbssbI2pb3KRBVIQdS+A2agTL ew5mRbBYzlE8B01JJ3RRqKqNulkO1KyQtCUAzowsnUxRpbVf5bWlXxcIETPD+LeIx2Dt VmQr5dm+f2zvv7h7DyAFdH02KXAkbqonkQAJOlEnKmfpnrhQIOde+4t9/DjZ9d9rfY7+ YM4q2huE+ARPbXl+qX0CDrLX3xavv8cY/r/JDoqT5kRP72Z+jXmmi4PwGv+mS5IbAfe+ sfHg== X-Forwarded-Encrypted: i=1; AJvYcCUxILbNoh/quPzjvHG5+NzYHZMbxgy7ebk15oT8EsPtttbjB7WFyy+FDPI1iQjFj7P1gR3qrpZmmzl6YkKOhdE=@lists.linux.dev X-Gm-Message-State: AOJu0YyJofflUdzngIkUh+x2RzmdKNIG1FNqxKPczMdRqJp1ZRaJ0bE+ rTr77TEsqJ+rpqdYNEVB96mrO2XWxd4wLqF8USZrOOaxwcWKj2GoXyoVQkpdBQ== X-Gm-Gg: ASbGncsZLnanSILVlb+mePTvQXWCy0S4PTtvfhZqUIjprSxEQzFNNcsUFtPHyX49+64 TG+ptH8c/e/L88rn++rpR8VLylofHUq8OLbTgopAfJcLwSINTv8Hob+QZ5dX03mj/fBrY936S1+ KjOVsLm93ZwpRX0zp4vPvXmm++iRizQGa78XcBqb1qkll0yzvGUmhGI6zFLx0mfE8zQbVKpDDyz kuB2dZkIyrfjYlAR2xzqoLBChpLi50fE/eqQA84We0B X-Google-Smtp-Source: AGHT+IGwNB4nRJMnNhTbAeM5SVohmmw2VhsVBxq/0MFDU/T8BxbRsqUD7vI2vwEli6Gsw3VQCvNV0A== X-Received: by 2002:a17:90a:ec83:b0:2ea:5fa5:fac0 with SMTP id 98e67ed59e1d1-2eb0e332553mr16365914a91.16.1732524224785; Mon, 25 Nov 2024 00:43:44 -0800 (PST) Received: from google.com ([2401:fa00:1:10:66a3:d18f:544f:227a]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-2ead03de64asm9677264a91.41.2024.11.25.00.43.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 25 Nov 2024 00:43:44 -0800 (PST) Date: Mon, 25 Nov 2024 16:43:40 +0800 From: "Sung-Chi, Li" To: Krzysztof Kozlowski Cc: Benson Leung , Guenter Roeck , Sebastian Reichel , Lee Jones , Rob Herring , Krzysztof Kozlowski , Conor Dooley , chrome-platform@lists.linux.dev, linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org Subject: Re: [PATCH 2/2] dt-bindings: mfd: cros-ec: add properties for thermal cooling cells Message-ID: References: <20241122-extend_power_limit-v1-0-a3ecd87afa76@chromium.org> <20241122-extend_power_limit-v1-2-a3ecd87afa76@chromium.org> <4f5sahkxxqb5qonh676igaiadkxv2pbhbibu6wtx4yenplfn4o@yvidi4ujavhr> Precedence: bulk X-Mailing-List: chrome-platform@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Mon, Nov 25, 2024 at 08:32:19AM +0100, Krzysztof Kozlowski wrote: > On 25/11/2024 03:50, Sung-Chi, Li wrote: > > On Fri, Nov 22, 2024 at 08:49:14AM +0100, Krzysztof Kozlowski wrote: > >> On Fri, Nov 22, 2024 at 11:47:22AM +0800, Sung-Chi Li wrote: > >>> The cros_ec supports limiting the input current to act as a passive > >>> thermal cooling device. Add the property '#cooling-cells' bindings, such > >>> that thermal framework can recognize cros_ec as a valid thermal cooling > >>> device. > >>> > >>> Signed-off-by: Sung-Chi Li > >>> --- > >>> Documentation/devicetree/bindings/mfd/google,cros-ec.yaml | 3 +++ > >>> 1 file changed, 3 insertions(+) > >>> > >>> diff --git a/Documentation/devicetree/bindings/mfd/google,cros-ec.yaml b/Documentation/devicetree/bindings/mfd/google,cros-ec.yaml > >>> index aac8819bd00b..2b6f098057af 100644 > >>> --- a/Documentation/devicetree/bindings/mfd/google,cros-ec.yaml > >>> +++ b/Documentation/devicetree/bindings/mfd/google,cros-ec.yaml > >>> @@ -96,6 +96,9 @@ properties: > >>> '#gpio-cells': > >>> const: 2 > >>> > >>> + '#cooling-cells': > >>> + const: 2 > >> > >> This is not a cooling device. BTW, your commit msg is somehow circular. > >> "Add cooling to make it a cooling device because it will be then cooling > >> device." > >> > >> Power supply already provides necessary framework for managing charging > >> current and temperatures. If this is to stay, you need to explain why > >> this is suitable to be considered a thermal zone or system cooling > >> device (not power supply or input power cooling). > >> > >> Best regards, > >> Krzysztof > >> > > > > Thank you, I will rephrase the commit message. The reason to not to use the > > managing charging current and temperatures in the power supply framework is > > that: > > > > - The EC may not have the thermal sensor value for the charger, and there is no > > protocol for getting the thermal sensor value for the charger (there is > > command for reading thermal sensor values, but there is no specification for > > what sensor index is for the charger, if the charger provides thermal value). > > - The managing mechanism only take the charger thermal value into account, and > > I would like to control the current based on the thermal condition of the > > whole device. > > > > I will include these explanation in the following changes. > > > This does not explain me why this is supposed to be thermal zone. I > already said it, but let's repeat: This is not a thermal zone. This > isn't thermal zone sensor, either. Hi, I added the explanation in the commit message in v2, in short, I need to use different thermal sensors, and need finer thermal controls, so I have to use thermal zone. This is included in the v2 commit message. > > > Best regards, > Krzysztof