From: Brian Norris <briannorris@chromium.org>
To: "Thomas Weißschuh" <linux@weissschuh.net>
Cc: Tzung-Bi Shih <tzungbi@kernel.org>,
Julius Werner <jwerner@chromium.org>,
chrome-platform@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 0/4] firmware: google: Constify 'struct bin_attribute'
Date: Mon, 16 Dec 2024 14:09:04 -0800 [thread overview]
Message-ID: <Z2ClAB6qY5LaMuHQ@google.com> (raw)
In-Reply-To: <20241215-sysfs-const-bin_attr-google-v1-0-e5c2808f5833@weissschuh.net>
On Sun, Dec 15, 2024 at 03:49:08PM +0100, Thomas Weißschuh wrote:
> The sysfs core now allows instances of 'struct bin_attribute' to be
> moved into read-only memory. Make use of that to protect them against
> accidental or malicious modifications.
I'm not in love with all these "_new" transformations that need a second
round of cleanup, but I'm not aware of any better way to do it.
For the series:
Acked-by: Brian Norris <briannorris@chromium.org>
> Please also note the remark at the end of the vpd patch.
I don't have much opinion on the options there. It seems like it's the
difference between an extra cleanup patch or two if we go with the
current series, vs. extra work for you with possible conflicts if we go
with your alternative.
Brian
next prev parent reply other threads:[~2024-12-16 22:09 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-15 14:49 [PATCH 0/4] firmware: google: Constify 'struct bin_attribute' Thomas Weißschuh
2024-12-15 14:49 ` [PATCH 1/4] firmware: google: cbmem: " Thomas Weißschuh
2024-12-15 14:49 ` [PATCH 2/4] firmware: google: gsmi: " Thomas Weißschuh
2024-12-15 14:49 ` [PATCH 3/4] firmware: google: memconsole: Use const 'struct bin_attribute' callback Thomas Weißschuh
2024-12-15 14:49 ` [PATCH 4/4] firmware: google: vpd: " Thomas Weißschuh
2024-12-16 22:09 ` Brian Norris [this message]
2024-12-17 18:58 ` [PATCH 0/4] firmware: google: Constify 'struct bin_attribute' Thomas Weißschuh
2024-12-17 4:06 ` Tzung-Bi Shih
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z2ClAB6qY5LaMuHQ@google.com \
--to=briannorris@chromium.org \
--cc=chrome-platform@lists.linux.dev \
--cc=jwerner@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@weissschuh.net \
--cc=tzungbi@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox