From: Tzung-Bi Shih <tzungbi@kernel.org>
To: Daniel Schaefer <dhs@frame.work>
Cc: chrome-platform@lists.linux.dev,
Benson Leung <bleung@chromium.org>,
"Dustin L . Howett" <dustin@howett.net>,
linux@frame.work
Subject: Re: [PATCH] platform/chrome: cros_usbpd_logger: fail probe if HC not supported
Date: Thu, 20 Feb 2025 09:48:10 +0000 [thread overview]
Message-ID: <Z7b6Wg-Ui2p_bnCO@google.com> (raw)
In-Reply-To: <20250220023441.158615-1-dhs@frame.work>
On Thu, Feb 20, 2025 at 10:34:41AM +0800, Daniel Schaefer wrote:
> If the EC_CMD_PD_GET_LOG_ENTRY does not exist, the driver does not need
> to stay active.
>
> Framework Computer systems don't use the PD infrastructure in the chrome
> EC firmware, so it does not support this host command.
Does the firmware still report `EC_FEATURE_USB_PD` feature [1]? Similarly,
do "cros-charge-control" and "cros-usbpd-charger" need to stay active [2]?
[1]: https://elixir.bootlin.com/linux/v6.13/source/drivers/mfd/cros_ec_dev.c#L263
[2]: https://elixir.bootlin.com/linux/v6.13/source/drivers/mfd/cros_ec_dev.c#L89
next prev parent reply other threads:[~2025-02-20 9:48 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-20 2:34 [PATCH] platform/chrome: cros_usbpd_logger: fail probe if HC not supported Daniel Schaefer
2025-02-20 9:48 ` Tzung-Bi Shih [this message]
2025-03-03 7:07 ` Daniel Schaefer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z7b6Wg-Ui2p_bnCO@google.com \
--to=tzungbi@kernel.org \
--cc=bleung@chromium.org \
--cc=chrome-platform@lists.linux.dev \
--cc=dhs@frame.work \
--cc=dustin@howett.net \
--cc=linux@frame.work \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox