From: Benson Leung <bleung@google.com>
To: Tzung-Bi Shih <tzungbi@kernel.org>
Cc: bleung@chromium.org, groeck@chromium.org,
chrome-platform@lists.linux.dev, robbarnes@google.com,
kernel test robot <lkp@intel.com>
Subject: Re: [PATCH] platform/chrome: cros_ec_debugfs: fix kernel-doc warning
Date: Mon, 10 Apr 2023 23:01:35 -0700 [thread overview]
Message-ID: <ZDT3v5CqcHR/2641@google.com> (raw)
In-Reply-To: <20230411053308.1572493-1-tzungbi@kernel.org>
[-- Attachment #1: Type: text/plain, Size: 1445 bytes --]
Hi Tzung-Bi,
On Tue, Apr 11, 2023 at 01:33:08PM +0800, Tzung-Bi Shih wrote:
> Fix the following kernel-doc warning:
>
> $ ./scripts/kernel-doc -none drivers/platform/chrome/*
> [...]
> warning: This comment starts with '/**', but isn't a kernel-doc comment.
>
> Fixes: 14bb09b32f43 ("platform/chrome: cros_ec: Separate logic for getting panic info")
> Reported-by: kernel test robot <lkp@intel.com>
> Signed-off-by: Tzung-Bi Shih <tzungbi@kernel.org>
Reviewed-by: Benson Leung <bleung@chromium.org>
> ---
> I should put it in my checklist in the future before pushing patches to
> for-next.
>
> drivers/platform/chrome/cros_ec_debugfs.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/platform/chrome/cros_ec_debugfs.c b/drivers/platform/chrome/cros_ec_debugfs.c
> index 414ebfffcf83..c876120e0ebc 100644
> --- a/drivers/platform/chrome/cros_ec_debugfs.c
> +++ b/drivers/platform/chrome/cros_ec_debugfs.c
> @@ -400,7 +400,7 @@ static void cros_ec_cleanup_console_log(struct cros_ec_debugfs *debug_info)
> }
> }
>
> -/**
> +/*
> * Returns the size of the panicinfo data fetched from the EC
> */
> static int cros_ec_get_panicinfo(struct cros_ec_device *ec_dev, uint8_t *data,
> --
> 2.40.0.577.gac1e443424-goog
>
>
--
Benson Leung
Staff Software Engineer
Chrome OS Kernel
Google Inc.
bleung@google.com
Chromium OS Project
bleung@chromium.org
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
next prev parent reply other threads:[~2023-04-11 6:01 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-11 5:33 [PATCH] platform/chrome: cros_ec_debugfs: fix kernel-doc warning Tzung-Bi Shih
2023-04-11 6:01 ` Benson Leung [this message]
2023-04-11 8:40 ` patchwork-bot+chrome-platform
2023-04-11 17:38 ` Prashant Malani
2023-04-12 2:48 ` Tzung-Bi Shih
2023-04-12 2:40 ` patchwork-bot+chrome-platform
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZDT3v5CqcHR/2641@google.com \
--to=bleung@google.com \
--cc=bleung@chromium.org \
--cc=chrome-platform@lists.linux.dev \
--cc=groeck@chromium.org \
--cc=lkp@intel.com \
--cc=robbarnes@google.com \
--cc=tzungbi@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox