From: Tzung-Bi Shih <tzungbi@kernel.org>
To: Tim Van Patten <timvp@chromium.org>
Cc: LKML <linux-kernel@vger.kernel.org>,
lalithkraj@google.com, robbarnes@google.com,
rrangel@chromium.org, Tim Van Patten <timvp@google.com>,
Benson Leung <bleung@chromium.org>,
Guenter Roeck <groeck@chromium.org>,
chrome-platform@lists.linux.dev
Subject: Re: [PATCH] platform/chrome: cros_ec_lpc: Move host command to prepare/complete
Date: Mon, 15 May 2023 14:05:13 +0800 [thread overview]
Message-ID: <ZGHLmVZbpBC7pNS7@google.com> (raw)
In-Reply-To: <20230512113556.1.I55189adfdb8d025fc991a0fa820ec09078619b15@changeid>
On Fri, May 12, 2023 at 11:35:57AM -0600, Tim Van Patten wrote:
> Update cros_ec_lpc_pm_ops to call cros_ec_lpc_prepare() during PM
> .prepare() and cros_ec_lpc_complete() during .complete(). This moves the
> host command that the AP sends and allows the EC to log entry/exit of
> AP's suspend/resume more accurately.
This is an old series. It should preserve the version number and change logs
(at least until v8[5]).
Went through the series again, and put all concerns together:
* Should it print more logs during suspend/resume? See v1[1].
* Which is more like local patches for debugging some specific issues.
* Should it move the callbacks? See v2[2].
* Is it appropriate to call cros_ec_suspend() when PM is still in prepare
phase and call cros_ec_resume() when PM is already in complete phase?
* Should it print return value of cros_ec_resume()? See v3[3] and v7[4].
* By referencing other use cases, they just defer it to PM.
[1]: https://patchwork.kernel.org/project/chrome-platform/patch/20220701095421.1.I78ded92e416b55de31975686d34b2058d4761c07@changeid/
[2]: https://patchwork.kernel.org/project/chrome-platform/patch/20220706205136.v2.1.Ic7a7c81f880ab31533652e0928aa6e687bb268b5@changeid/
[3]: https://patchwork.kernel.org/project/chrome-platform/patch/20220802113957.v3.1.I2c8c550183162e7594309b66d19af696b8d84552@changeid/
[4]: https://patchwork.kernel.org/project/chrome-platform/patch/20220823095915.v7.1.I55189adfdb8d025fc991a0fa820ec09078619b15@changeid/
[5]: https://patchwork.kernel.org/project/chrome-platform/patch/20221028171820.v8.1.I55189adfdb8d025fc991a0fa820ec09078619b15@changeid/
> Signed-off-by: Tim Van Patten <timvp@chromium.org>
> Reviewed-by: Raul E Rangel <rrangel@chromium.org>
> Signed-off-by: Tim Van Patten <timvp@google.com>
It shouldn't need duplicate S-o-b.
prev parent reply other threads:[~2023-05-15 6:05 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-12 17:35 [PATCH] platform/chrome: cros_ec_lpc: Move host command to prepare/complete Tim Van Patten
2023-05-15 6:05 ` Tzung-Bi Shih [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZGHLmVZbpBC7pNS7@google.com \
--to=tzungbi@kernel.org \
--cc=bleung@chromium.org \
--cc=chrome-platform@lists.linux.dev \
--cc=groeck@chromium.org \
--cc=lalithkraj@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=robbarnes@google.com \
--cc=rrangel@chromium.org \
--cc=timvp@chromium.org \
--cc=timvp@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox