From: Sasha Levin <sashal@kernel.org>
To: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
Cc: linux-kernel@vger.kernel.org, stable@vger.kernel.org,
Hans Verkuil <hverkuil-cisco@xs4all.nl>,
mchehab@kernel.org, bleung@chromium.org, groeck@chromium.org,
kevin.chiu.17802@gmail.com,
scott_chao@wistron.corp-partner.google.com,
zoey_wu@wistron.corp-partner.google.com,
hellojacky0226@hotmail.com, linux-media@vger.kernel.org,
chrome-platform@lists.linux.dev
Subject: Re: [PATCH AUTOSEL 6.3 34/44] media: cros-ec-cec: Don't exit early in .remove() callback
Date: Thu, 18 May 2023 13:02:35 -0400 [thread overview]
Message-ID: <ZGZaK2lp8NCvyAmk@sashalap> (raw)
In-Reply-To: <20230501152632.ccsvhl2c6ihuizcf@pengutronix.de>
On Mon, May 01, 2023 at 05:26:32PM +0200, Uwe Kleine-König wrote:
>Hello,
>
>On Sun, Apr 30, 2023 at 10:56:22PM -0400, Sasha Levin wrote:
>> From: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
>>
>> [ Upstream commit 0ff7aee24e47beb4306ce050824b54147f2fabfa ]
>>
>> Exiting early in remove without releasing all acquired resources yields
>> leaks. Note that e.g. memory allocated with devm_zalloc() is freed after
>> .remove() returns, even if the return code was negative.
>>
>> While blocking_notifier_chain_unregister() won't fail and so the
>> change is somewhat cosmetic, platform driver's .remove callbacks are
>> about to be converted to return void. To prepare that, keep the error
>> message but don't return early.
>>
>> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
>> Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
>> Signed-off-by: Sasha Levin <sashal@kernel.org>
>
>While I'm positive this change doesn't break anything, it also doesn't
>fix anything and is only cosmetic (+ preparing a later change).
>
>Unless you need it as a dependency I'd say, don't backport it for
>stable.
Ack, dropped. Thanks!
--
Thanks,
Sasha
prev parent reply other threads:[~2023-05-18 17:02 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20230501025632.3253067-1-sashal@kernel.org>
2023-05-01 2:56 ` [PATCH AUTOSEL 6.3 34/44] media: cros-ec-cec: Don't exit early in .remove() callback Sasha Levin
2023-05-01 15:26 ` Uwe Kleine-König
2023-05-18 17:02 ` Sasha Levin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZGZaK2lp8NCvyAmk@sashalap \
--to=sashal@kernel.org \
--cc=bleung@chromium.org \
--cc=chrome-platform@lists.linux.dev \
--cc=groeck@chromium.org \
--cc=hellojacky0226@hotmail.com \
--cc=hverkuil-cisco@xs4all.nl \
--cc=kevin.chiu.17802@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=scott_chao@wistron.corp-partner.google.com \
--cc=stable@vger.kernel.org \
--cc=u.kleine-koenig@pengutronix.de \
--cc=zoey_wu@wistron.corp-partner.google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox