From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 229D923C90 for ; Thu, 18 May 2023 17:02:36 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 99697C433D2; Thu, 18 May 2023 17:02:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1684429356; bh=79AycYGWyrOQGPq3/yfTreinQpf172phqCKZ12EBcSI=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=spj3g1H5gdhvCnAM7rSXem86Ykpv72fmpCnJQkzgLdUgWBWH7uvG19mO4+R8d+A5I 3rc71yaT/owlcNDhqfuUiUIalXA1AfNNlk5d/uy6zOSHCztRMPpmHT6jy69q2GJQ5x DMLVRo055Y0JfHRuxHX3e07koRVko78Q8ojlCL3/tLH9kioFOwXBfLpYGaepwi7yzs 0Hplzq5p5NT/979I6Onxxt93X1YBfo4ucrSN+d8VP1n3kNvF9zlijpJnElzZFXFXf7 cQ+Hfsc2xaxcXJ2KBsdi1FmaMRbp3UW4B0pAwVbjoJsicqjGcBOGizHtXsu8lpLNTx WiTKQ5jzWMy8A== Date: Thu, 18 May 2023 13:02:35 -0400 From: Sasha Levin To: Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= Cc: linux-kernel@vger.kernel.org, stable@vger.kernel.org, Hans Verkuil , mchehab@kernel.org, bleung@chromium.org, groeck@chromium.org, kevin.chiu.17802@gmail.com, scott_chao@wistron.corp-partner.google.com, zoey_wu@wistron.corp-partner.google.com, hellojacky0226@hotmail.com, linux-media@vger.kernel.org, chrome-platform@lists.linux.dev Subject: Re: [PATCH AUTOSEL 6.3 34/44] media: cros-ec-cec: Don't exit early in .remove() callback Message-ID: References: <20230501025632.3253067-1-sashal@kernel.org> <20230501025632.3253067-34-sashal@kernel.org> <20230501152632.ccsvhl2c6ihuizcf@pengutronix.de> Precedence: bulk X-Mailing-List: chrome-platform@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1; format=flowed Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20230501152632.ccsvhl2c6ihuizcf@pengutronix.de> On Mon, May 01, 2023 at 05:26:32PM +0200, Uwe Kleine-König wrote: >Hello, > >On Sun, Apr 30, 2023 at 10:56:22PM -0400, Sasha Levin wrote: >> From: Uwe Kleine-König >> >> [ Upstream commit 0ff7aee24e47beb4306ce050824b54147f2fabfa ] >> >> Exiting early in remove without releasing all acquired resources yields >> leaks. Note that e.g. memory allocated with devm_zalloc() is freed after >> .remove() returns, even if the return code was negative. >> >> While blocking_notifier_chain_unregister() won't fail and so the >> change is somewhat cosmetic, platform driver's .remove callbacks are >> about to be converted to return void. To prepare that, keep the error >> message but don't return early. >> >> Signed-off-by: Uwe Kleine-König >> Signed-off-by: Hans Verkuil >> Signed-off-by: Sasha Levin > >While I'm positive this change doesn't break anything, it also doesn't >fix anything and is only cosmetic (+ preparing a later change). > >Unless you need it as a dependency I'd say, don't backport it for >stable. Ack, dropped. Thanks! -- Thanks, Sasha